From mboxrd@z Thu Jan 1 00:00:00 1970 From: joe@perches.com (Joe Perches) Date: Tue, 16 Aug 2016 10:08:33 -0700 Subject: [PATCH v2] ARM: Add missing newline terminators to kernel messages In-Reply-To: <1471354832-18456-1-git-send-email-geert+renesas@glider.be> References: <1471354832-18456-1-git-send-email-geert+renesas@glider.be> Message-ID: <1471367313.4075.167.camel@perches.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, 2016-08-16 at 15:40 +0200, Geert Uytterhoeven wrote: > Before commit 874f9c7da9a4acbc ("printk: create pr_ functions"), > pr_*() calls without a trailing newline characters would be printed with > a newline character appended, both on the console and in the output of > the dmesg command. Hey Geert. This doesn't apply to -next as the pr_notice/pr_cont below is properly changed to a single pr_notice. > diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c [] > @@ -1196,7 +1196,7 @@ void __init sanity_check_meminfo(void) > ? pr_notice("Truncating RAM at %pa-%pa", > ? ??&block_start, &block_end); > ? block_end = vmalloc_limit; > - pr_cont(" to -%pa", &block_end); > + pr_cont(" to -%pa\n", &block_end); > ? memblock_remove(vmalloc_limit, overlap_size); > ? should_use_highmem = true; > ? } From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752586AbcHPRJW (ORCPT ); Tue, 16 Aug 2016 13:09:22 -0400 Received: from smtprelay0120.hostedemail.com ([216.40.44.120]:46248 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751127AbcHPRJU (ORCPT ); Tue, 16 Aug 2016 13:09:20 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:960:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:4250:4321:5007:10004:10400:10848:11026:11232:11658:11783:11914:12043:12295:12296:12438:12517:12519:12740:13069:13311:13357:13439:13894:14180:14659:14721:21080:21212:21451:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: frog81_2de09d85eba32 X-Filterd-Recvd-Size: 1740 Message-ID: <1471367313.4075.167.camel@perches.com> Subject: Re: [PATCH v2] ARM: Add missing newline terminators to kernel messages From: Joe Perches To: Geert Uytterhoeven , Russell King , Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Tue, 16 Aug 2016 10:08:33 -0700 In-Reply-To: <1471354832-18456-1-git-send-email-geert+renesas@glider.be> References: <1471354832-18456-1-git-send-email-geert+renesas@glider.be> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-08-16 at 15:40 +0200, Geert Uytterhoeven wrote: > Before commit 874f9c7da9a4acbc ("printk: create pr_ functions"), > pr_*() calls without a trailing newline characters would be printed with > a newline character appended, both on the console and in the output of > the dmesg command. Hey Geert. This doesn't apply to -next as the pr_notice/pr_cont below is properly changed to a single pr_notice. > diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c [] > @@ -1196,7 +1196,7 @@ void __init sanity_check_meminfo(void) >   pr_notice("Truncating RAM at %pa-%pa", >     &block_start, &block_end); >   block_end = vmalloc_limit; > - pr_cont(" to -%pa", &block_end); > + pr_cont(" to -%pa\n", &block_end); >   memblock_remove(vmalloc_limit, overlap_size); >   should_use_highmem = true; >   }