From mboxrd@z Thu Jan 1 00:00:00 1970 From: joe@perches.com (Joe Perches) Date: Tue, 16 Aug 2016 11:01:36 -0700 Subject: [PATCH v2] ARM: Add missing newline terminators to kernel messages In-Reply-To: References: <1471354832-18456-1-git-send-email-geert+renesas@glider.be> <1471367313.4075.167.camel@perches.com> Message-ID: <1471370496.4075.170.camel@perches.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, 2016-08-16 at 19:50 +0200, Geert Uytterhoeven wrote: > Hi Joe, > > On Tue, Aug 16, 2016 at 7:08 PM, Joe Perches wrote: > > > > On Tue, 2016-08-16 at 15:40 +0200, Geert Uytterhoeven wrote: > > > > > > Before commit 874f9c7da9a4acbc ("printk: create pr_ > > > functions"), > > > pr_*() calls without a trailing newline characters would be > > > printed with > > > a newline character appended, both on the console and in the > > > output of > > > the dmesg command. > > Hey Geert. > > > > This doesn't apply to -next as the pr_notice/pr_cont below is > > properly changed to a single pr_notice. > In which -next? > > Not in next-20160816, where the patch applies cleanly. > Also not in arm/for-next. My mistake, I was in the wrong directory. It doesn't apply to Linus' tree. Still, it'd be slightly nicer to use a single pr_notice than the pr_notice/pr_cont. cheers, Joe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751936AbcHPSBm (ORCPT ); Tue, 16 Aug 2016 14:01:42 -0400 Received: from smtprelay0033.hostedemail.com ([216.40.44.33]:38296 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750803AbcHPSBl (ORCPT ); Tue, 16 Aug 2016 14:01:41 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2110:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:4321:5007:10004:10400:10848:11232:11658:11914:12295:12296:12517:12519:12555:12740:13069:13160:13229:13311:13357:13439:14096:14097:14180:14181:14659:14721:21060:21080:21212:21451:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: corn40_488904d293355 X-Filterd-Recvd-Size: 2075 Message-ID: <1471370496.4075.170.camel@perches.com> Subject: Re: [PATCH v2] ARM: Add missing newline terminators to kernel messages From: Joe Perches To: Geert Uytterhoeven Cc: Geert Uytterhoeven , Russell King , Arnd Bergmann , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Date: Tue, 16 Aug 2016 11:01:36 -0700 In-Reply-To: References: <1471354832-18456-1-git-send-email-geert+renesas@glider.be> <1471367313.4075.167.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-08-16 at 19:50 +0200, Geert Uytterhoeven wrote: > Hi Joe, > > On Tue, Aug 16, 2016 at 7:08 PM, Joe Perches wrote: > > > > On Tue, 2016-08-16 at 15:40 +0200, Geert Uytterhoeven wrote: > > > > > > Before commit 874f9c7da9a4acbc ("printk: create pr_ > > > functions"), > > > pr_*() calls without a trailing newline characters would be > > > printed with > > > a newline character appended, both on the console and in the > > > output of > > > the dmesg command. > > Hey Geert. > > > > This doesn't apply to -next as the pr_notice/pr_cont below is > > properly changed to a single pr_notice. > In which -next? > > Not in next-20160816, where the patch applies cleanly. > Also not in arm/for-next. My mistake, I was in the wrong directory. It doesn't apply to Linus' tree. Still, it'd be slightly nicer to use a single pr_notice than the pr_notice/pr_cont. cheers, Joe