diff for duplicates of <1471380303.21107.38.camel@linux.intel.com> diff --git a/a/1.txt b/N1/1.txt index d4b861d..1a3a952 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,7 +1,7 @@ -On Mon, 2016-08-15@22:41 -0300, Helen Koike wrote: +On Mon, 2016-08-15 at 22:41 -0300, Helen Koike wrote: -> ? +> > +struct nvme_doorbell_memory { > + __u8 opcode; > + __u8 flags; @@ -12,36 +12,36 @@ On Mon, 2016-08-15@22:41 -0300, Helen Koike wrote: > + __u32 rsvd12[6]; > +}; > + -> ?struct nvme_command { -> ? union { -> ? struct nvme_common_command common; +> struct nvme_command { +> union { +> struct nvme_common_command common; > @@ -845,6 +858,7 @@ struct nvme_command { -> ? struct nvmf_connect_command connect; -> ? struct nvmf_property_set_command prop_set; -> ? struct nvmf_property_get_command prop_get; +> struct nvmf_connect_command connect; +> struct nvmf_property_set_command prop_set; +> struct nvmf_property_get_command prop_get; > + struct nvme_doorbell_memory doorbell_memory; -> ? }; -> ?}; +> }; +> }; This looks like a new NVMe command being introduced, not found in the latest NVMe specs (NVMe 1.2.1 spec or NVMe-over-Fabrics 1.0 spec)? This is a big NACK, the command needs to be part of the NVMe standard before adding it to the NVMe code base (this is exactly how NVMe-over- -Fabrics standard got implemented). ?I would bring your proposal to +Fabrics standard got implemented). I would bring your proposal to nvmexpress.org. Jay -> ? +> > @@ -934,6 +948,9 @@ enum { -> ? /* -> ? ?* Media and Data Integrity Errors: -> ? ?*/ +> /* +> * Media and Data Integrity Errors: +> */ > +#ifdef CONFIG_NVME_VDB > + NVME_SC_DOORBELL_MEMORY_INVALID = 0x1C0, > +#endif -> ? NVME_SC_WRITE_FAULT = 0x280, -> ? NVME_SC_READ_ERROR = 0x281, -> ? NVME_SC_GUARD_CHECK = 0x282, +> NVME_SC_WRITE_FAULT = 0x280, +> NVME_SC_READ_ERROR = 0x281, +> NVME_SC_GUARD_CHECK = 0x282, diff --git a/a/content_digest b/N1/content_digest index 9f95984..511bb29 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,15 +1,32 @@ "ref\01460657059-21214-1-git-send-email-helen.koike@collabora.co.uk\0" "ref\0cover.1471308889.git.helen.koike@collabora.co.uk\0" "ref\0c738f3d3c14907a9074a40b1658461e008fbed9e.1471308889.git.helen.koike@collabora.co.uk\0" - "From\0james_p_freyensee@linux.intel.com (J Freyensee)\0" - "Subject\0[PATCH v3 RFC 2/2] nvme: improve performance for virtual NVMe devices\0" + "From\0J Freyensee <james_p_freyensee@linux.intel.com>\0" + "Subject\0Re: [PATCH v3 RFC 2/2] nvme: improve performance for virtual NVMe devices\0" "Date\0Tue, 16 Aug 2016 13:45:03 -0700\0" + "To\0Helen Koike <helen.koike@collabora.co.uk>" + hch@infradead.org + mlin@kernel.org + fes@google.com + keith.busch@intel.com + rlnelson@google.com + axboe@fb.com + digitaleric@google.com + tytso@mit.edu + mikew@google.com + " monish@google.com\0" + "Cc\0open list <linux-kernel@vger.kernel.org>" + open list:NVM EXPRESS DRIVER <linux-nvme@lists.infradead.org> + Huffman + Amber <amber.huffman@intel.com> + Minturn + " Dave B <dave.b.minturn@intel.com>\0" "\00:1\0" "b\0" - "On Mon, 2016-08-15@22:41 -0300, Helen Koike wrote:\n" + "On Mon, 2016-08-15 at 22:41 -0300, Helen Koike wrote:\n" "\n" "\n" - "> ?\n" + "> \302\240\n" "> +struct nvme_doorbell_memory {\n" "> +\t__u8\t\t\topcode;\n" "> +\t__u8\t\t\tflags;\n" @@ -20,38 +37,38 @@ "> +\t__u32\t\t\trsvd12[6];\n" "> +};\n" "> +\n" - "> ?struct nvme_command {\n" - "> ?\tunion {\n" - "> ?\t\tstruct nvme_common_command common;\n" + "> \302\240struct nvme_command {\n" + "> \302\240\tunion {\n" + "> \302\240\t\tstruct nvme_common_command common;\n" "> @@ -845,6 +858,7 @@ struct nvme_command {\n" - "> ?\t\tstruct nvmf_connect_command connect;\n" - "> ?\t\tstruct nvmf_property_set_command prop_set;\n" - "> ?\t\tstruct nvmf_property_get_command prop_get;\n" + "> \302\240\t\tstruct nvmf_connect_command connect;\n" + "> \302\240\t\tstruct nvmf_property_set_command prop_set;\n" + "> \302\240\t\tstruct nvmf_property_get_command prop_get;\n" "> +\t\tstruct nvme_doorbell_memory doorbell_memory;\n" - "> ?\t};\n" - "> ?};\n" + "> \302\240\t};\n" + "> \302\240};\n" "\n" "This looks like a new NVMe command being introduced, not found in the\n" "latest NVMe specs (NVMe 1.2.1 spec or NVMe-over-Fabrics 1.0 spec)?\n" "\n" "This is a big NACK, the command needs to be part of the NVMe standard\n" "before adding it to the NVMe code base (this is exactly how NVMe-over-\n" - "Fabrics standard got implemented). ?I would bring your proposal to\n" + "Fabrics standard got implemented). \302\240I would bring your proposal to\n" "nvmexpress.org.\n" "\n" "Jay\n" "\n" "\n" - "> ?\n" + "> \302\240\n" "> @@ -934,6 +948,9 @@ enum {\n" - "> ?\t/*\n" - "> ?\t?* Media and Data Integrity Errors:\n" - "> ?\t?*/\n" + "> \302\240\t/*\n" + "> \302\240\t\302\240* Media and Data Integrity Errors:\n" + "> \302\240\t\302\240*/\n" "> +#ifdef CONFIG_NVME_VDB\n" "> +\tNVME_SC_DOORBELL_MEMORY_INVALID\t= 0x1C0,\n" "> +#endif\n" - "> ?\tNVME_SC_WRITE_FAULT\t\t= 0x280,\n" - "> ?\tNVME_SC_READ_ERROR\t\t= 0x281,\n" - "> ?\tNVME_SC_GUARD_CHECK\t\t= 0x282," + "> \302\240\tNVME_SC_WRITE_FAULT\t\t= 0x280,\n" + "> \302\240\tNVME_SC_READ_ERROR\t\t= 0x281,\n" + "> \302\240\tNVME_SC_GUARD_CHECK\t\t= 0x282," -b102ddcbbd92b2f95a608c70635363b07d2dc7353a799b9fc0002230d19b84b1 +26b682a635f27c83d68136711bfee626e9284ec2454feda156f5625db2bd7025
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.