diff for duplicates of <1471407480.4989.18.camel@gmail.com> diff --git a/a/1.txt b/N1/1.txt index 15921ea..61886af 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -24,7 +24,7 @@ On Tue, 2016-08-16 at 14:27 +0200, Andrew Jones wrote: > > - start_cpu returns number of threads on cpu and number > > successfully > > started -> > - start_all_cpus checks if number of threads started = total +> > - start_all_cpus checks if number of threads started == total > > number of > > threads - 1 > > @@ -213,11 +213,11 @@ Ok I like having it > > > -> > + assert(ret = 0); +> > + assert(ret == 0); > > + > > + /* We expect that we come in with one thread already > > started */ -> > + return data.nr_started = (nr_threads - 1); +> > + return data.nr_started == (nr_threads - 1); > nit: no need for the () > > You could also init data.nr_started to 1 above, and then avoid diff --git a/a/content_digest b/N1/content_digest index cbb141c..6d1b95c 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\020160816122739.7t757ietllrihjii@kamzik.localdomain\0" "From\0Suraj Jitindar Singh <sjitindarsingh@gmail.com>\0" "Subject\0Re: [kvm-unit-tests PATCH V3 3/5] lib/powerpc: Add function to start secondary threads\0" - "Date\0Wed, 17 Aug 2016 04:18:00 +0000\0" + "Date\0Wed, 17 Aug 2016 14:18:00 +1000\0" "To\0Andrew Jones <drjones@redhat.com>\0" "Cc\0kvm@vger.kernel.org" pbonzini@redhat.com @@ -39,7 +39,7 @@ "> > \t- start_cpu returns number of threads on cpu and number\n" "> > successfully\n" "> > \t\302\240\302\240started\n" - "> > \t- start_all_cpus checks if number of threads started = total\n" + "> > \t- start_all_cpus checks if number of threads started == total\n" "> > number of\n" "> > \t\302\240\302\240threads - 1\n" "> > \n" @@ -228,11 +228,11 @@ "I like having it\n" "> \n" "> > \n" - "> > +\tassert(ret = 0);\n" + "> > +\tassert(ret == 0);\n" "> > +\n" "> > +\t/* We expect that we come in with one thread already\n" "> > started */\n" - "> > +\treturn data.nr_started = (nr_threads - 1);\n" + "> > +\treturn data.nr_started == (nr_threads - 1);\n" "> nit: no need for the ()\n" "> \n" "> You could also init data.nr_started to 1 above, and then avoid\n" @@ -262,4 +262,4 @@ "> > \302\240FLATLIBS = $(libcflat) $(LIBFDT_archive)\n" "> > \302\240%.elf: CFLAGS += $(arch_CFLAGS)" -fb249993da4872bc349bd049f55bccfbb7fd4219d30c076bce8771847310b1a9 +532c1e051696232c09f3903e8de6b91f75a885bcacd5eac59c9111f8030872f9
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.