diff for duplicates of <1471414071.4989.28.camel@gmail.com> diff --git a/a/1.txt b/N1/1.txt index d748fa8..504255f 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -190,7 +190,7 @@ Yes > > + } > > + > > + report("H_CEDE TM", pass); -> nit: with a break above you could just test for i = 500 here. +> nit: with a break above you could just test for i == 500 here. ok > > > @@ -211,8 +211,8 @@ ok > > + > > + report_prefix_push("tm"); > > + -> > + all = argc = 1 || (argc = 2 && !strcmp(argv[1], "all")); -> I'd drop the argc = 2 test. You already know argc >= 2 at this +> > + all = argc == 1 || (argc == 2 && !strcmp(argv[1], "all")); +> I'd drop the argc == 2 test. You already know argc >= 2 at this > point. And, if it's > 2, then you want to call the test function > so the "Unsupported argument" abort will fire. Sounds good @@ -220,7 +220,7 @@ Sounds good > > > > + > > + for (i = 0; hctests[i].name != NULL; i++) { -> > + if (all || strcmp(argv[1], hctests[i].name) = 0) +> > + if (all || strcmp(argv[1], hctests[i].name) == 0) > > { > > + report_prefix_push(hctests[i].name); > > + hctests[i].func(argc, argv); diff --git a/a/content_digest b/N1/content_digest index 5e36e93..db329e2 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\020160816125726.dpqyojde4ptzfhxv@kamzik.localdomain\0" "From\0Suraj Jitindar Singh <sjitindarsingh@gmail.com>\0" "Subject\0Re: [kvm-unit-tests PATCH V3 5/5] powerpc/tm: Add a test for H_CEDE while tm suspended\0" - "Date\0Wed, 17 Aug 2016 06:07:51 +0000\0" + "Date\0Wed, 17 Aug 2016 16:07:51 +1000\0" "To\0Andrew Jones <drjones@redhat.com>\0" "Cc\0kvm@vger.kernel.org" pbonzini@redhat.com @@ -205,7 +205,7 @@ "> > +\t}\n" "> > +\n" "> > +\treport(\"H_CEDE TM\", pass);\n" - "> nit: with a break above you could just test for i = 500 here.\n" + "> nit: with a break above you could just test for i == 500 here.\n" "ok\n" "> \n" "> > \n" @@ -226,8 +226,8 @@ "> > +\n" "> > +\treport_prefix_push(\"tm\");\n" "> > +\n" - "> > +\tall = argc = 1 || (argc = 2 && !strcmp(argv[1], \"all\"));\n" - "> I'd drop the argc = 2 test. You already know argc >= 2 at this\n" + "> > +\tall = argc == 1 || (argc == 2 && !strcmp(argv[1], \"all\"));\n" + "> I'd drop the argc == 2 test. You already know argc >= 2 at this\n" "> point. And, if it's > 2, then you want to call the test function\n" "> so the \"Unsupported argument\" abort will fire.\n" "Sounds good\n" @@ -235,7 +235,7 @@ "> > \n" "> > +\n" "> > +\tfor (i = 0; hctests[i].name != NULL; i++) {\n" - "> > +\t\tif (all || strcmp(argv[1], hctests[i].name) = 0)\n" + "> > +\t\tif (all || strcmp(argv[1], hctests[i].name) == 0)\n" "> > {\n" "> > +\t\t\treport_prefix_push(hctests[i].name);\n" "> > +\t\t\thctests[i].func(argc, argv);\n" @@ -260,4 +260,4 @@ "> > +extra_params = -append \"h_cede_tm\"\n" > > +groups = nodefault,h_cede_tm -ae3cda43273d243acc6a2958fe7380d39a1e46673ee84dcde81dd0c15c05089c +bd13c6c0ac2aa9a1b568519dd5ece7bc537428422998a78e5ad8460167991cab
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.