From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Joe Slater <jslater@windriver.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] systemd-compat-units: pkg_postinst() does not work
Date: Wed, 17 Aug 2016 17:48:04 +0100 [thread overview]
Message-ID: <1471452484.20391.228.camel@linuxfoundation.org> (raw)
In-Reply-To: <1471302293-16339-1-git-send-email-jslater@windriver.com>
On Mon, 2016-08-15 at 16:04 -0700, Joe Slater wrote:
> The test for various files is wrong and will always be
> true, even if init.d does not exist.
>
> Exit if init.d does not exist, and correctly test for
> file existence otherwise.
>
> Signed-off-by: Joe Slater <jslater@windriver.com>
> ---
> meta/recipes-core/systemd/systemd-compat-units.bb | 19 +++++++++++
> --------
> 1 file changed, 11 insertions(+), 8 deletions(-)
This appears to break non-systemd world builds:
https://autobuilder.yoctoproject.org/main/builders/nightly-no-x11/builds/239/steps/BuildImages/logs/stdio
We probably need to make it depend on the systemd DISTRO_FEATURE. I
appreciate its a side effect of your patch rather than a direct cause.
Cheers,
Richard
prev parent reply other threads:[~2016-08-17 16:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-15 23:04 [PATCH 1/1] systemd-compat-units: pkg_postinst() does not work Joe Slater
2016-08-17 16:48 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471452484.20391.228.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=jslater@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.