From: "Hervé Poussineau" <hpoussin@reactos.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, "Hervé Poussineau" <hpoussin@reactos.org>
Subject: [Qemu-devel] [PATCH 4/4] lsi: never set DMA FIFO Empty (DFE) bit in DSTAT register
Date: Thu, 18 Aug 2016 09:31:29 +0200 [thread overview]
Message-ID: <1471505489-1221-5-git-send-email-hpoussin@reactos.org> (raw)
In-Reply-To: <1471505489-1221-1-git-send-email-hpoussin@reactos.org>
53C895A datasheet says:
"This bit (DFE) is a pure status bit and will not cause an interrupt"
This bit is already auto-generated in lsi_read_reg when reading the DSTAT register.
This fixes IBM RS/6000 7020 firmware, which is:
- resetting the adapter
- enabling all interrupt sources (including DIP, ie interrupts from DSTAT)
- waiting for ISTAT0 to become 0 (including DIP=0, ie no interrupt coming from DSTAT)
Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
---
hw/scsi/lsi53c895a.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c
index 2e99d5e..feb1191 100644
--- a/hw/scsi/lsi53c895a.c
+++ b/hw/scsi/lsi53c895a.c
@@ -326,7 +326,7 @@ static void lsi_soft_reset(LSIState *s)
s->istat0 = 0;
s->istat1 = 0;
s->dcmd = 0x40;
- s->dstat = LSI_DSTAT_DFE;
+ s->dstat = 0;
s->dien = 0;
s->sist0 = 0;
s->sist1 = 0;
--
2.1.4
next prev parent reply other threads:[~2016-08-18 7:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-18 7:31 [Qemu-devel] [PATCH 0/4] lsi: misc fixes Hervé Poussineau
2016-08-18 7:31 ` [Qemu-devel] [PATCH 1/4] lsi: print register names in debug prints Hervé Poussineau
2016-08-18 7:31 ` [Qemu-devel] [PATCH 2/4] lsi: do not exit QEMU if reading invalid register Hervé Poussineau
2016-08-18 7:31 ` [Qemu-devel] [PATCH 3/4] lsi: implement I/O memory space for Memory Move instructions Hervé Poussineau
2016-08-18 7:31 ` Hervé Poussineau [this message]
2016-08-18 7:41 ` [Qemu-devel] [PATCH 0/4] lsi: misc fixes no-reply
2016-08-18 8:47 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471505489-1221-5-git-send-email-hpoussin@reactos.org \
--to=hpoussin@reactos.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.