From: Chunming Zhou <David1.Zhou-5C7GfCeVMHo@public.gmane.org>
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: Chunming Zhou <David1.Zhou-5C7GfCeVMHo@public.gmane.org>,
David.Mao-5C7GfCeVMHo@public.gmane.org
Subject: [PATCH 1/4] amdgpu: use drm_amdgpu_fence instead of amdgpu_cs_fence in semaphore structure
Date: Thu, 18 Aug 2016 15:55:56 +0800 [thread overview]
Message-ID: <1471506959-905-2-git-send-email-David1.Zhou@amd.com> (raw)
In-Reply-To: <1471506959-905-1-git-send-email-David1.Zhou-5C7GfCeVMHo@public.gmane.org>
semaphore just need to store ctx id not context itself,
which will bring convenience for sharing semaphore accross process.
Change-Id: I46cf54c61ee6143a77d18510c3591bcc97fa8b24
Signed-off-by: Chunming Zhou <David1.Zhou@amd.com>
---
amdgpu/amdgpu_cs.c | 20 ++++++++++----------
amdgpu/amdgpu_internal.h | 2 +-
2 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/amdgpu/amdgpu_cs.c b/amdgpu/amdgpu_cs.c
index bb0d79b..c76a675 100644
--- a/amdgpu/amdgpu_cs.c
+++ b/amdgpu/amdgpu_cs.c
@@ -284,13 +284,13 @@ static int amdgpu_cs_submit_one(amdgpu_context_handle context,
}
sem_count = 0;
LIST_FOR_EACH_ENTRY_SAFE(sem, tmp, sem_list, list) {
- struct amdgpu_cs_fence *info = &sem->signal_fence;
+ struct drm_amdgpu_fence *info = &sem->signal_fence;
struct drm_amdgpu_cs_chunk_dep *dep = &sem_dependencies[sem_count++];
dep->ip_type = info->ip_type;
dep->ip_instance = info->ip_instance;
dep->ring = info->ring;
- dep->ctx_id = info->context->id;
- dep->handle = info->fence;
+ dep->ctx_id = info->ctx_id;
+ dep->handle = info->seq_no;
list_del(&sem->list);
amdgpu_cs_reset_sem(sem);
@@ -550,14 +550,14 @@ int amdgpu_cs_signal_semaphore(amdgpu_context_handle ctx,
if (NULL == sem)
return -EINVAL;
/* sem has been signaled */
- if (sem->signal_fence.context)
+ if (sem->signal_fence.ctx_id)
return -EINVAL;
pthread_mutex_lock(&ctx->sequence_mutex);
- sem->signal_fence.context = ctx;
+ sem->signal_fence.ctx_id = ctx->id;
sem->signal_fence.ip_type = ip_type;
sem->signal_fence.ip_instance = ip_instance;
sem->signal_fence.ring = ring;
- sem->signal_fence.fence = ctx->last_seq[ip_type][ip_instance][ring];
+ sem->signal_fence.seq_no = ctx->last_seq[ip_type][ip_instance][ring];
update_references(NULL, &sem->refcount);
pthread_mutex_unlock(&ctx->sequence_mutex);
return 0;
@@ -578,7 +578,7 @@ int amdgpu_cs_wait_semaphore(amdgpu_context_handle ctx,
if (NULL == sem)
return -EINVAL;
/* must signal first */
- if (NULL == sem->signal_fence.context)
+ if (0 == sem->signal_fence.ctx_id)
return -EINVAL;
pthread_mutex_lock(&ctx->sequence_mutex);
@@ -591,14 +591,14 @@ static int amdgpu_cs_reset_sem(amdgpu_semaphore_handle sem)
{
if (NULL == sem)
return -EINVAL;
- if (NULL == sem->signal_fence.context)
+ if (0 == sem->signal_fence.ctx_id)
return -EINVAL;
- sem->signal_fence.context = NULL;;
+ sem->signal_fence.ctx_id = 0;
sem->signal_fence.ip_type = 0;
sem->signal_fence.ip_instance = 0;
sem->signal_fence.ring = 0;
- sem->signal_fence.fence = 0;
+ sem->signal_fence.seq_no = 0;
return 0;
}
diff --git a/amdgpu/amdgpu_internal.h b/amdgpu/amdgpu_internal.h
index 1160a12..ccc85d7 100644
--- a/amdgpu/amdgpu_internal.h
+++ b/amdgpu/amdgpu_internal.h
@@ -133,7 +133,7 @@ struct amdgpu_context {
struct amdgpu_semaphore {
atomic_t refcount;
struct list_head list;
- struct amdgpu_cs_fence signal_fence;
+ struct drm_amdgpu_fence signal_fence;
};
/**
--
1.9.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2016-08-18 7:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-18 7:55 [PATCH 0/4] share semaphore across process Chunming Zhou
[not found] ` <1471506959-905-1-git-send-email-David1.Zhou-5C7GfCeVMHo@public.gmane.org>
2016-08-18 7:55 ` Chunming Zhou [this message]
2016-08-18 7:55 ` [PATCH 2/4] amdgpu: add export/import semaphore apis Chunming Zhou
[not found] ` <1471506959-905-3-git-send-email-David1.Zhou-5C7GfCeVMHo@public.gmane.org>
2016-08-21 6:23 ` Edward O'Callaghan
[not found] ` <cf458d97-d40a-d363-b5c4-2ae45dde9179-dczkZgxz+BNUPWh3PAxdjQ@public.gmane.org>
2016-08-22 2:42 ` zhoucm1
[not found] ` <57BA6689.2010700-5C7GfCeVMHo@public.gmane.org>
2016-08-22 12:41 ` Edward O'Callaghan
[not found] ` <414bf811-0e72-6f79-350f-8995a2b5167c-dczkZgxz+BNUPWh3PAxdjQ@public.gmane.org>
2016-08-22 12:44 ` Edward O'Callaghan
2016-08-18 7:55 ` [PATCH 3/4] amdgpu: add mutex for across process reason Chunming Zhou
2016-08-18 7:55 ` [PATCH 4/4] tests/amdgpu: add semaphore across process test Chunming Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471506959-905-2-git-send-email-David1.Zhou@amd.com \
--to=david1.zhou-5c7gfcevmho@public.gmane.org \
--cc=David.Mao-5C7GfCeVMHo@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.