From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f198.google.com (mail-io0-f198.google.com [209.85.223.198]) by kanga.kvack.org (Postfix) with ESMTP id 4081B83094 for ; Thu, 18 Aug 2016 09:26:09 -0400 (EDT) Received: by mail-io0-f198.google.com with SMTP id e70so53354188ioi.3 for ; Thu, 18 Aug 2016 06:26:09 -0700 (PDT) Received: from smtprelay.hostedemail.com (smtprelay0161.hostedemail.com. [216.40.44.161]) by mx.google.com with ESMTPS id w2si5040557ita.105.2016.08.18.06.26.08 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Aug 2016 06:26:08 -0700 (PDT) Message-ID: <1471526765.4319.31.camel@perches.com> Subject: Re: [PATCH] proc, smaps: reduce printing overhead From: Joe Perches Date: Thu, 18 Aug 2016 06:26:05 -0700 In-Reply-To: <1471519888-13829-1-git-send-email-mhocko@kernel.org> References: <1471519888-13829-1-git-send-email-mhocko@kernel.org> Content-Type: text/plain; charset="ISO-8859-1" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko , Andrew Morton Cc: linux-mm@kvack.org, LKML , Jann Horn , Michal Hocko On Thu, 2016-08-18 at 13:31 +0200, Michal Hocko wrote: [] > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c [] > @@ -721,6 +721,13 @@ void __weak arch_show_smap(struct seq_file *m, struct vm_area_struct *vma) > { > } > > +static void print_name_value_kb(struct seq_file *m, const char *name, unsigned long val) > +{ > + seq_puts(m, name); > + seq_put_decimal_ull(m, 0, val); > + seq_puts(m, " kB\n"); > +} The seq_put_decimal_ull function has different arguments in -next, the separator is changed to const char *. $ git log --stat -p -1 49f87a2773000ced0c850639975f43134de48342 -- fs/seq_file.c Maybe this change in fs/proc/meminfo.c should be made into a public function. $ git log --stat -p -1 5e27340c20516104c38668e597b3200f339fc64d static void show_val_kb(struct seq_file *m, const char *s, unsigned long num) +{ + char v[32]; + static const char blanks[7] = {' ', ' ', ' ', ' ',' ', ' ', ' '}; + int len; + + len = num_to_str(v, sizeof(v), num << (PAGE_SHIFT - 10)); + + seq_write(m, s, 16); + + if (len > 0) { + if (len < 8) + seq_write(m, blanks, 8 - len); + + seq_write(m, v, len); + } + seq_write(m, " kB\n", 4); +} -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1947362AbcHRN0U (ORCPT ); Thu, 18 Aug 2016 09:26:20 -0400 Received: from smtprelay0237.hostedemail.com ([216.40.44.237]:54959 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1946531AbcHRN0M (ORCPT ); Thu, 18 Aug 2016 09:26:12 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3870:3871:4321:5007:10004:10400:10848:11026:11658:11783:11914:12043:12296:12438:12517:12519:12555:12740:13069:13161:13229:13311:13357:13439:13894:14659:14721:21080:21365:30029:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: twig93_6f8d7db260505 X-Filterd-Recvd-Size: 2149 Message-ID: <1471526765.4319.31.camel@perches.com> Subject: Re: [PATCH] proc, smaps: reduce printing overhead From: Joe Perches To: Michal Hocko , Andrew Morton Cc: linux-mm@kvack.org, LKML , Jann Horn , Michal Hocko Date: Thu, 18 Aug 2016 06:26:05 -0700 In-Reply-To: <1471519888-13829-1-git-send-email-mhocko@kernel.org> References: <1471519888-13829-1-git-send-email-mhocko@kernel.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-08-18 at 13:31 +0200, Michal Hocko wrote: [] > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c [] > @@ -721,6 +721,13 @@ void __weak arch_show_smap(struct seq_file *m, struct vm_area_struct *vma) >  { >  } >   > +static void print_name_value_kb(struct seq_file *m, const char *name, unsigned long val) > +{ > + seq_puts(m, name); > + seq_put_decimal_ull(m, 0, val); > + seq_puts(m, " kB\n"); > +} The seq_put_decimal_ull function has different arguments in -next, the separator is changed to const char *. $ git log --stat -p -1 49f87a2773000ced0c850639975f43134de48342 -- fs/seq_file.c Maybe this change in fs/proc/meminfo.c should be made into a public function. $ git log --stat -p -1  5e27340c20516104c38668e597b3200f339fc64d static void show_val_kb(struct seq_file *m, const char *s, unsigned long num) +{ +       char v[32]; +       static const char blanks[7] = {' ', ' ', ' ', ' ',' ', ' ', ' '}; +       int len; + +       len = num_to_str(v, sizeof(v), num << (PAGE_SHIFT - 10)); + +       seq_write(m, s, 16); + +       if (len > 0) { +               if (len < 8) +                       seq_write(m, blanks, 8 - len); + +               seq_write(m, v, len); +       } +       seq_write(m, " kB\n", 4); +}