diff for duplicates of <1471533810.4319.50.camel@perches.com> diff --git a/a/1.txt b/N1/1.txt index 7587493..0b3b312 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -17,8 +17,8 @@ On Thu, 2016-08-18 at 16:58 +0200, Michal Hocko wrote: > > Appended to is generally OK, but whitespace changed is > > not good. > OK fair enough, I will -> - seq_write(m, s, 16); -> + seq_puts(m, s); +> - seq_write(m, s, 16); +> + seq_puts(m, s); > > because smaps needs more than 16 chars and export it in > fs/proc/internal.h @@ -30,16 +30,10 @@ The shift in the meminfo case uses PAGE_SHIFT too. I suggest you make a local static instead and for that one 17 byte line do - seq_printf(m, "Private_Hugetlb: %7lu kB\n", mss.private_hugetlb >> 10); + seq_printf(m, "Private_Hugetlb: %7lu kB\n", mss.private_hugetlb >> 10); Another possible thing is to speed up all seq_puts uses with fixed chars strings by avoiding the runtime strlen and use the compiler known string length: https://lkml.org/lkml/2016/8/11/607 - --- -To unsubscribe, send a message with 'unsubscribe linux-mm' in -the body to majordomo@kvack.org. For more info on Linux MM, -see: http://www.linux-mm.org/ . -Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> diff --git a/a/content_digest b/N1/content_digest index 2b71839..71731f7 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -33,8 +33,8 @@ "> > Appended to is generally OK, but whitespace changed is\n" "> > not good.\n" "> OK fair enough, I will\n" - "> - seq_write(m, s, 16);\n" - "> + seq_puts(m, s);\n" + "> -\302\240\302\240\302\240\302\240\302\240\302\240\302\240seq_write(m, s, 16);\n" + "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240seq_puts(m, s);\n" "> \n" "> because smaps needs more than 16 chars and export it in\n" "> fs/proc/internal.h\n" @@ -46,18 +46,12 @@ "I suggest you make a local static instead and for\n" "that one 17 byte line do\n" "\n" - "\tseq_printf(m, \"Private_Hugetlb: %7lu kB\\n\", mss.private_hugetlb >> 10);\n" + "\tseq_printf(m, \"Private_Hugetlb: %7lu kB\\n\",\302\240\302\240mss.private_hugetlb >> 10);\n" "\n" "Another possible thing is to speed up all seq_puts \n" "uses with fixed chars strings by avoiding the runtime\n" "strlen and use the compiler known string length:\n" "\n" - "https://lkml.org/lkml/2016/8/11/607\n" - "\n" - "--\n" - "To unsubscribe, send a message with 'unsubscribe linux-mm' in\n" - "the body to majordomo@kvack.org. For more info on Linux MM,\n" - "see: http://www.linux-mm.org/ .\n" - "Don't email: <a href=mailto:\"dont@kvack.org\"> email@kvack.org </a>" + https://lkml.org/lkml/2016/8/11/607 -11f32f7b37739d880c1f5132cefab0ccd51c21e96700fe1c905224c6d27324a7 +19f0452b2abe3a60c65cdbf4c678a65cc4d75c87c5ab0137ab2bc1377bf7729c
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.