From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Awais Belal <awais_belal@mentor.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] insane.bbclass: handle INSANE_SKIP for license-checksum
Date: Thu, 18 Aug 2016 17:55:25 +0100 [thread overview]
Message-ID: <1471539325.16712.18.camel@linuxfoundation.org> (raw)
In-Reply-To: <1471523878-32164-1-git-send-email-awais_belal@mentor.com>
On Thu, 2016-08-18 at 17:37 +0500, Awais Belal wrote:
> The function populate_lic_qa_checksum() is used to do the
> QA test for license-checksum but it does not handle the
> scenario where a package adds license-checksum to its
> INSANE_SKIP and hence fails in such condition.
> This patch adds handling of INSANE_SKIP to the
> populate_lic_qa_checksum() function so it returns
> cleanly in such a scenario.
license-checksum is not per package. Its already handled based on
WARN_QA and ERROR_QA so I don't think we need to complicate this
further. You could for example set:
WARN_QA_remove_pn-XXX = "license-check"
ERROR_QA_remove_pn-XXX = "license-check"
Skipping license checksums is likely a bad idea anyway and not
something we want to make easier?
Cheers,
Richard
prev parent reply other threads:[~2016-08-18 16:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-18 12:37 [PATCH] insane.bbclass: handle INSANE_SKIP for license-checksum Awais Belal
2016-08-18 16:49 ` Burton, Ross
2016-08-18 16:55 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471539325.16712.18.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=awais_belal@mentor.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.