From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Verma, Vishal L" Subject: Re: [PATCH] acpi, nfit: fix acpi event notifications for nfit Date: Thu, 18 Aug 2016 20:22:29 +0000 Message-ID: <1471551711.6177.25.camel@intel.com> References: <1471546104-28520-1-git-send-email-vishal.l.verma@intel.com> <07af328e-d703-fd80-20be-725f00e54812@hpe.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US Content-ID: <1B49B1C567C3B54C9574FE8F8A2C0B5F-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: "Williams, Dan J" , "linda.knippers-ZPxbGqLxI0U@public.gmane.org" Cc: "linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "guangrong.xiao-VuQAYsv1563Yd54FQh9/CA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org" List-Id: linux-acpi@vger.kernel.org T24gVGh1LCAyMDE2LTA4LTE4IGF0IDEyOjU0IC0wNzAwLCBEYW4gV2lsbGlhbXMgd3JvdGU6DQo+ IE9uIFRodSwgQXVnIDE4LCAyMDE2IGF0IDEyOjUyIFBNLCBMaW5kYSBLbmlwcGVycyA8bGluZGEu a25pcHBlcnNAaHBlLmMNCj4gb20+IHdyb3RlOg0KPiA+IA0KPiA+IA0KPiA+IA0KPiA+IE9uIDgv MTgvMjAxNiAzOjQ4IFBNLCBEYW4gV2lsbGlhbXMgd3JvdGU6DQo+ID4gPiANCj4gPiA+IE9uIFRo dSwgQXVnIDE4LCAyMDE2IGF0IDExOjQ4IEFNLCBWaXNoYWwgVmVybWEgPHZpc2hhbC5sLnZlcm1h QGludA0KPiA+ID4gZWwuY29tPiB3cm90ZToNCj4gPiA+ID4gDQo+ID4gPiA+IFRoZSBuZml0IGRy aXZlciBoYWQgYW4gYWNwaSBldmVudCBub3RpZmljYXRpb24gaGFuZGxlciwgYnV0IGl0DQo+ID4g PiA+IG5ldmVyDQo+ID4gPiA+IHdvdWxkJ3ZlIHdvcmtlZCBiZWNhdXNlIHdlIHdlcmVuJ3Qgc2V0 dGluZyB0aGUNCj4gPiA+ID4gQUNQSV9EUklWRVJfQUxMX05PVElGWV9FVkVOVFMgZmxhZyBpbiBh Y3BpX2RyaXZlci4NCj4gPiA+IA0KPiA+ID4gTGV0J3MgdXBkYXRlIHRoZSBjaGFuZ2Vsb2cgdG8g YmUgaGVscGZ1bCBmb3Igc29tZW9uZSBpbXBsZW1lbnRpbmcNCj4gPiA+IGENCj4gPiA+IGJhY2tw b3J0IG9yIHRha2luZyB0aGlzIGJhY2sgdG8gYSAtc3RhYmxlIGJyYW5jaC7CoMKgU29tZXRoaW5n IGxpa2U6DQo+ID4gPiANCj4gPiA+IFN1YmplY3Q6IGFjcGksIG5maXQ6IGZpeCBldmVudCBub3Rp ZmljYXRpb25zDQo+ID4gPiANCj4gPiA+IENvbW1pdCAyMDk4NTE2NDlkYzQgImFjcGk6IG5maXQ6 IEFkZCBzdXBwb3J0IGZvciBob3QtYWRkIiBhZGRlZA0KPiA+ID4gc3VwcG9ydCBmb3IgX0ZJVCBu b3RpZmljYXRpb25zLCBidXQgaXQgbmVnbGVjdGVkIHRvIHNldCB0aGUNCj4gPiA+IEFDUElfRFJJ VkVSX0FMTF9OT1RJRllfRVZFTlRTIGZsYWcgdGhhdCBhY3BpX2J1c19ub3RpZnkoKSB1c2VzIHRv DQo+ID4gPiBnYXRlDQo+ID4gPiBub3RpZmljYXRpb24gZGVsaXZlcnkuDQo+ID4gDQo+ID4gV2hp bGUgd2UncmUgYXQgaXQsIHNob3VsZCB3ZSB1cGRhdGUgdGhlIG5vdGlmaWVyIGZ1bmN0aW9uIHRv DQo+ID4gZXhwbGljaXRseSBjaGVjaw0KPiA+IGZvciBldmVudCAweDgwIGJlZm9yZSByZS1ldmFs dWF0aW5nIHRoZSBfRklUP8KgwqBJJ20gdGhpbmtpbmcgYWJvdXQNCj4gPiBzb21lIHRpbWUNCj4g PiBpbiB0aGUgZnV0dXJlIHdoZW4gdGhlcmUgbWlnaHQgYmUgbW9yZSB0aGFuIG9uZSBldmVudC4N Cj4gDQo+IFllcywgZ29vZCBpZGVhLg0KDQpTb3VuZHMgZ29vZCwgcGFydCBvZiB0aGUgc2FtZSBw YXRjaCBvciBzZXBhcmF0ZWx5PwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpMaW51eC1udmRpbW0gbWFpbGluZyBsaXN0CkxpbnV4LW52ZGltbUBsaXN0cy4w MS5vcmcKaHR0cHM6Ly9saXN0cy4wMS5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1udmRpbW0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by ml01.01.org (Postfix) with ESMTP id 7A7A71A1E04 for ; Thu, 18 Aug 2016 13:22:31 -0700 (PDT) From: "Verma, Vishal L" Subject: Re: [PATCH] acpi, nfit: fix acpi event notifications for nfit Date: Thu, 18 Aug 2016 20:22:29 +0000 Message-ID: <1471551711.6177.25.camel@intel.com> References: <1471546104-28520-1-git-send-email-vishal.l.verma@intel.com> <07af328e-d703-fd80-20be-725f00e54812@hpe.com> In-Reply-To: Content-Language: en-US Content-ID: <1B49B1C567C3B54C9574FE8F8A2C0B5F@intel.com> MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: "Williams, Dan J" , "linda.knippers@hpe.com" Cc: "linux-acpi@vger.kernel.org" , "guangrong.xiao@linux.intel.com" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , "linux-nvdimm@lists.01.org" List-ID: T24gVGh1LCAyMDE2LTA4LTE4IGF0IDEyOjU0IC0wNzAwLCBEYW4gV2lsbGlhbXMgd3JvdGU6DQo+ IE9uIFRodSwgQXVnIDE4LCAyMDE2IGF0IDEyOjUyIFBNLCBMaW5kYSBLbmlwcGVycyA8bGluZGEu a25pcHBlcnNAaHBlLmMNCj4gb20+IHdyb3RlOg0KPiA+IA0KPiA+IA0KPiA+IA0KPiA+IE9uIDgv MTgvMjAxNiAzOjQ4IFBNLCBEYW4gV2lsbGlhbXMgd3JvdGU6DQo+ID4gPiANCj4gPiA+IE9uIFRo dSwgQXVnIDE4LCAyMDE2IGF0IDExOjQ4IEFNLCBWaXNoYWwgVmVybWEgPHZpc2hhbC5sLnZlcm1h QGludA0KPiA+ID4gZWwuY29tPiB3cm90ZToNCj4gPiA+ID4gDQo+ID4gPiA+IFRoZSBuZml0IGRy aXZlciBoYWQgYW4gYWNwaSBldmVudCBub3RpZmljYXRpb24gaGFuZGxlciwgYnV0IGl0DQo+ID4g PiA+IG5ldmVyDQo+ID4gPiA+IHdvdWxkJ3ZlIHdvcmtlZCBiZWNhdXNlIHdlIHdlcmVuJ3Qgc2V0 dGluZyB0aGUNCj4gPiA+ID4gQUNQSV9EUklWRVJfQUxMX05PVElGWV9FVkVOVFMgZmxhZyBpbiBh Y3BpX2RyaXZlci4NCj4gPiA+IA0KPiA+ID4gTGV0J3MgdXBkYXRlIHRoZSBjaGFuZ2Vsb2cgdG8g YmUgaGVscGZ1bCBmb3Igc29tZW9uZSBpbXBsZW1lbnRpbmcNCj4gPiA+IGENCj4gPiA+IGJhY2tw b3J0IG9yIHRha2luZyB0aGlzIGJhY2sgdG8gYSAtc3RhYmxlIGJyYW5jaC7CoMKgU29tZXRoaW5n IGxpa2U6DQo+ID4gPiANCj4gPiA+IFN1YmplY3Q6IGFjcGksIG5maXQ6IGZpeCBldmVudCBub3Rp ZmljYXRpb25zDQo+ID4gPiANCj4gPiA+IENvbW1pdCAyMDk4NTE2NDlkYzQgImFjcGk6IG5maXQ6 IEFkZCBzdXBwb3J0IGZvciBob3QtYWRkIiBhZGRlZA0KPiA+ID4gc3VwcG9ydCBmb3IgX0ZJVCBu b3RpZmljYXRpb25zLCBidXQgaXQgbmVnbGVjdGVkIHRvIHNldCB0aGUNCj4gPiA+IEFDUElfRFJJ VkVSX0FMTF9OT1RJRllfRVZFTlRTIGZsYWcgdGhhdCBhY3BpX2J1c19ub3RpZnkoKSB1c2VzIHRv DQo+ID4gPiBnYXRlDQo+ID4gPiBub3RpZmljYXRpb24gZGVsaXZlcnkuDQo+ID4gDQo+ID4gV2hp bGUgd2UncmUgYXQgaXQsIHNob3VsZCB3ZSB1cGRhdGUgdGhlIG5vdGlmaWVyIGZ1bmN0aW9uIHRv DQo+ID4gZXhwbGljaXRseSBjaGVjaw0KPiA+IGZvciBldmVudCAweDgwIGJlZm9yZSByZS1ldmFs dWF0aW5nIHRoZSBfRklUP8KgwqBJJ20gdGhpbmtpbmcgYWJvdXQNCj4gPiBzb21lIHRpbWUNCj4g PiBpbiB0aGUgZnV0dXJlIHdoZW4gdGhlcmUgbWlnaHQgYmUgbW9yZSB0aGFuIG9uZSBldmVudC4N Cj4gDQo+IFllcywgZ29vZCBpZGVhLg0KDQpTb3VuZHMgZ29vZCwgcGFydCBvZiB0aGUgc2FtZSBw YXRjaCBvciBzZXBhcmF0ZWx5PwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpMaW51eC1udmRpbW0gbWFpbGluZyBsaXN0CkxpbnV4LW52ZGltbUBsaXN0cy4w MS5vcmcKaHR0cHM6Ly9saXN0cy4wMS5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1udmRpbW0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754993AbcHSByM (ORCPT ); Thu, 18 Aug 2016 21:54:12 -0400 Received: from mga04.intel.com ([192.55.52.120]:63278 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751701AbcHSBsg (ORCPT ); Thu, 18 Aug 2016 21:48:36 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,541,1464678000"; d="scan'208";a="867820049" From: "Verma, Vishal L" To: "Williams, Dan J" , "linda.knippers@hpe.com" CC: "linux-kernel@vger.kernel.org" , "linux-nvdimm@lists.01.org" , "guangrong.xiao@linux.intel.com" , "linux-acpi@vger.kernel.org" , "stable@vger.kernel.org" Subject: Re: [PATCH] acpi, nfit: fix acpi event notifications for nfit Thread-Topic: [PATCH] acpi, nfit: fix acpi event notifications for nfit Thread-Index: AQHR+YFE+xZLg8KnNEeMDunKT/JTZaBPlWqAgAABHACAAACbAIAAB4OA Date: Thu, 18 Aug 2016 20:22:29 +0000 Message-ID: <1471551711.6177.25.camel@intel.com> References: <1471546104-28520-1-git-send-email-vishal.l.verma@intel.com> <07af328e-d703-fd80-20be-725f00e54812@hpe.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.232.112.171] Content-Type: text/plain; charset="utf-8" Content-ID: <1B49B1C567C3B54C9574FE8F8A2C0B5F@intel.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u7J1sGsD029231 On Thu, 2016-08-18 at 12:54 -0700, Dan Williams wrote: > On Thu, Aug 18, 2016 at 12:52 PM, Linda Knippers om> wrote: > > > > > > > > On 8/18/2016 3:48 PM, Dan Williams wrote: > > > > > > On Thu, Aug 18, 2016 at 11:48 AM, Vishal Verma > > el.com> wrote: > > > > > > > > The nfit driver had an acpi event notification handler, but it > > > > never > > > > would've worked because we weren't setting the > > > > ACPI_DRIVER_ALL_NOTIFY_EVENTS flag in acpi_driver. > > > > > > Let's update the changelog to be helpful for someone implementing > > > a > > > backport or taking this back to a -stable branch.  Something like: > > > > > > Subject: acpi, nfit: fix event notifications > > > > > > Commit 209851649dc4 "acpi: nfit: Add support for hot-add" added > > > support for _FIT notifications, but it neglected to set the > > > ACPI_DRIVER_ALL_NOTIFY_EVENTS flag that acpi_bus_notify() uses to > > > gate > > > notification delivery. > > > > While we're at it, should we update the notifier function to > > explicitly check > > for event 0x80 before re-evaluating the _FIT?  I'm thinking about > > some time > > in the future when there might be more than one event. > > Yes, good idea. Sounds good, part of the same patch or separately? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com ([192.55.52.120]:63278 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751701AbcHSBsg (ORCPT ); Thu, 18 Aug 2016 21:48:36 -0400 From: "Verma, Vishal L" To: "Williams, Dan J" , "linda.knippers@hpe.com" CC: "linux-kernel@vger.kernel.org" , "linux-nvdimm@lists.01.org" , "guangrong.xiao@linux.intel.com" , "linux-acpi@vger.kernel.org" , "stable@vger.kernel.org" Subject: Re: [PATCH] acpi, nfit: fix acpi event notifications for nfit Date: Thu, 18 Aug 2016 20:22:29 +0000 Message-ID: <1471551711.6177.25.camel@intel.com> References: <1471546104-28520-1-git-send-email-vishal.l.verma@intel.com> <07af328e-d703-fd80-20be-725f00e54812@hpe.com> In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-ID: <1B49B1C567C3B54C9574FE8F8A2C0B5F@intel.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org List-ID: T24gVGh1LCAyMDE2LTA4LTE4IGF0IDEyOjU0IC0wNzAwLCBEYW4gV2lsbGlhbXMgd3JvdGU6DQo+ IE9uIFRodSwgQXVnIDE4LCAyMDE2IGF0IDEyOjUyIFBNLCBMaW5kYSBLbmlwcGVycyA8bGluZGEu a25pcHBlcnNAaHBlLmMNCj4gb20+IHdyb3RlOg0KPiA+IA0KPiA+IA0KPiA+IA0KPiA+IE9uIDgv MTgvMjAxNiAzOjQ4IFBNLCBEYW4gV2lsbGlhbXMgd3JvdGU6DQo+ID4gPiANCj4gPiA+IE9uIFRo dSwgQXVnIDE4LCAyMDE2IGF0IDExOjQ4IEFNLCBWaXNoYWwgVmVybWEgPHZpc2hhbC5sLnZlcm1h QGludA0KPiA+ID4gZWwuY29tPiB3cm90ZToNCj4gPiA+ID4gDQo+ID4gPiA+IFRoZSBuZml0IGRy aXZlciBoYWQgYW4gYWNwaSBldmVudCBub3RpZmljYXRpb24gaGFuZGxlciwgYnV0IGl0DQo+ID4g PiA+IG5ldmVyDQo+ID4gPiA+IHdvdWxkJ3ZlIHdvcmtlZCBiZWNhdXNlIHdlIHdlcmVuJ3Qgc2V0 dGluZyB0aGUNCj4gPiA+ID4gQUNQSV9EUklWRVJfQUxMX05PVElGWV9FVkVOVFMgZmxhZyBpbiBh Y3BpX2RyaXZlci4NCj4gPiA+IA0KPiA+ID4gTGV0J3MgdXBkYXRlIHRoZSBjaGFuZ2Vsb2cgdG8g YmUgaGVscGZ1bCBmb3Igc29tZW9uZSBpbXBsZW1lbnRpbmcNCj4gPiA+IGENCj4gPiA+IGJhY2tw b3J0IG9yIHRha2luZyB0aGlzIGJhY2sgdG8gYSAtc3RhYmxlIGJyYW5jaC7CoMKgU29tZXRoaW5n IGxpa2U6DQo+ID4gPiANCj4gPiA+IFN1YmplY3Q6IGFjcGksIG5maXQ6IGZpeCBldmVudCBub3Rp ZmljYXRpb25zDQo+ID4gPiANCj4gPiA+IENvbW1pdCAyMDk4NTE2NDlkYzQgImFjcGk6IG5maXQ6 IEFkZCBzdXBwb3J0IGZvciBob3QtYWRkIiBhZGRlZA0KPiA+ID4gc3VwcG9ydCBmb3IgX0ZJVCBu b3RpZmljYXRpb25zLCBidXQgaXQgbmVnbGVjdGVkIHRvIHNldCB0aGUNCj4gPiA+IEFDUElfRFJJ VkVSX0FMTF9OT1RJRllfRVZFTlRTIGZsYWcgdGhhdCBhY3BpX2J1c19ub3RpZnkoKSB1c2VzIHRv DQo+ID4gPiBnYXRlDQo+ID4gPiBub3RpZmljYXRpb24gZGVsaXZlcnkuDQo+ID4gDQo+ID4gV2hp bGUgd2UncmUgYXQgaXQsIHNob3VsZCB3ZSB1cGRhdGUgdGhlIG5vdGlmaWVyIGZ1bmN0aW9uIHRv DQo+ID4gZXhwbGljaXRseSBjaGVjaw0KPiA+IGZvciBldmVudCAweDgwIGJlZm9yZSByZS1ldmFs dWF0aW5nIHRoZSBfRklUP8KgwqBJJ20gdGhpbmtpbmcgYWJvdXQNCj4gPiBzb21lIHRpbWUNCj4g PiBpbiB0aGUgZnV0dXJlIHdoZW4gdGhlcmUgbWlnaHQgYmUgbW9yZSB0aGFuIG9uZSBldmVudC4N Cj4gDQo+IFllcywgZ29vZCBpZGVhLg0KDQpTb3VuZHMgZ29vZCwgcGFydCBvZiB0aGUgc2FtZSBw YXRjaCBvciBzZXBhcmF0ZWx5Pw==