diff for duplicates of <1471591694.2691.39.camel@intel.com> diff --git a/a/1.txt b/N1/1.txt index ff868ac..124c659 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,8 +1,8 @@ -On 四, 2016-08-18 at 11:39 -0700, Eric Anholt wrote: +On ?, 2016-08-18 at 11:39 -0700, Eric Anholt wrote: > Eric Anholt <eric@anholt.net> writes: > > > -> > kernel@martin.sperl.org writes: +> > kernel at martin.sperl.org writes: > > > > > > > > From: Martin Sperl <kernel@martin.sperl.org> @@ -15,12 +15,12 @@ On 四, 2016-08-18 at 11:39 -0700, Eric Anholt wrote: > > > Signed-off-by: Martin Sperl <kernel@martin.sperl.org> > > > > > > ChangeLog: -> > > V1 -> V2: added specific settings depending on compatiblity -> > > added trip point based on register -> > > setting up ctrl-register if HW is not enabled by firmware -> > > as per recommendation of Eric (untested) -> > > check that clock frequency is in range -> > > (1.9 - 5MHz - as per comment in clk-bcm2835.c) +> > > ?V1 -> V2: added specific settings depending on compatiblity +> > > ???added trip point based on register +> > > ???setting up ctrl-register if HW is not enabled by firmware +> > > ?????as per recommendation of Eric (untested) +> > > ???check that clock frequency is in range +> > > ?????(1.9 - 5MHz - as per comment in clk-bcm2835.c) > > > --- > > > > > > diff --git a/drivers/thermal/bcm/Makefile @@ -49,28 +49,28 @@ On 四, 2016-08-18 at 11:39 -0700, Eric Anholt wrote: > > > + rate = clk_get_rate(data->clk); > > > + if ((rate < 1920000) || (rate > 5000000)) { > > > + dev_warn(&pdev->dev, -> > > + "Clock %pCn is running at %pCr Hz, +> > > + ?"Clock %pCn is running at %pCr Hz, > > > which is outside the recommended range of 1.9 to 5.0 MHz\n", -> > > + data->clk, data->clk); +> > > + ?data->clk, data->clk); > > > + } > > > + > > > + /* register it */ > > > + tz = thermal_zone_device_register("bcm2835_thermal", -> > > + 1, 0, data, -> > > + &bcm2835_thermal_ops, -> > > + NULL, 0, 0); +> > > + ??1, 0, data, +> > > + ??&bcm2835_thermal_ops, +> > > + ??NULL, 0, 0); > > I notice that the polling_delay is set to 0, but we're not using -> > interrupts to trigger the trip. Is it valid to expose a trip +> > interrupts to trigger the trip.??Is it valid to expose a trip > > without a -> > polling_delay or interrupts? Should passive_delay be set as well? +> > polling_delay or interrupts???Should passive_delay be set as well? > > -> > This is up to the thermal maintainers. As far as I'm concerned, +> > This is up to the thermal maintainers.??As far as I'm concerned, > > it's: > > > > Acked-by: Eric Anholt <eric@anholt.net> > > > > One it lands I'll pull the defconfig and DT bits. -> Ping on this question to thermal maintainers. I'd still love to see +> Ping on this question to thermal maintainers.??I'd still love to see > this driver land. hmmm, how is this driver supposed to work? diff --git a/a/content_digest b/N1/content_digest index 63e467e..1e86990 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,29 +2,17 @@ "ref\01463495753-967-3-git-send-email-kernel@martin.sperl.org\0" "ref\087mvn6qa2x.fsf@eliezer.anholt.net\0" "ref\087r39lvs4v.fsf@eliezer.anholt.net\0" - "From\0Zhang Rui <rui.zhang@intel.com>\0" - "Subject\0Re: [PATCH V3 2/5] thermal: bcm2835: add thermal driver for bcm2835 soc\0" + "From\0rui.zhang@intel.com (Zhang Rui)\0" + "Subject\0[PATCH V3 2/5] thermal: bcm2835: add thermal driver for bcm2835 soc\0" "Date\0Fri, 19 Aug 2016 15:28:14 +0800\0" - "To\0Eric Anholt <eric@anholt.net>" - kernel@martin.sperl.org - Eduardo Valentin <edubezval@gmail.com> - Rob Herring <robh+dt@kernel.org> - Pawel Moll <pawel.moll@arm.com> - Mark Rutland <mark.rutland@arm.com> - Stephen Warren <swarren@wwwdotorg.org> - Lee Jones <lee@kernel.org> - Russell King <linux@arm.linux.org.uk> - linux-pm@vger.kernel.org - devicetree@vger.kernel.org - linux-rpi-kernel@lists.infradead.org - " linux-arm-kernel@lists.infradead.org\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" - "On \345\233\233, 2016-08-18 at 11:39 -0700, Eric Anholt wrote:\n" + "On ?, 2016-08-18 at 11:39 -0700, Eric Anholt wrote:\n" "> Eric Anholt <eric@anholt.net> writes:\n" "> \n" "> > \n" - "> > kernel@martin.sperl.org writes:\n" + "> > kernel at martin.sperl.org writes:\n" "> > \n" "> > > \n" "> > > From: Martin Sperl <kernel@martin.sperl.org>\n" @@ -37,12 +25,12 @@ "> > > Signed-off-by: Martin Sperl <kernel@martin.sperl.org>\n" "> > > \n" "> > > ChangeLog:\n" - "> > > \302\240V1 -> V2: added specific settings depending on compatiblity\n" - "> > > \t\302\240\302\240\302\240added trip point based on register\n" - "> > > \t\302\240\302\240\302\240setting up ctrl-register if HW is not enabled by firmware\n" - "> > > \t\302\240\302\240\302\240\302\240\302\240as per recommendation of Eric (untested)\n" - "> > > \t\302\240\302\240\302\240check that clock frequency is in range\n" - "> > > \t\302\240\302\240\302\240\302\240\302\240(1.9 - 5MHz - as per comment in clk-bcm2835.c)\n" + "> > > ?V1 -> V2: added specific settings depending on compatiblity\n" + "> > > \t???added trip point based on register\n" + "> > > \t???setting up ctrl-register if HW is not enabled by firmware\n" + "> > > \t?????as per recommendation of Eric (untested)\n" + "> > > \t???check that clock frequency is in range\n" + "> > > \t?????(1.9 - 5MHz - as per comment in clk-bcm2835.c)\n" "> > > ---\n" "> > > \n" "> > > diff --git a/drivers/thermal/bcm/Makefile\n" @@ -71,28 +59,28 @@ "> > > +\trate = clk_get_rate(data->clk);\n" "> > > +\tif ((rate < 1920000) || (rate > 5000000)) {\n" "> > > +\t\tdev_warn(&pdev->dev,\n" - "> > > +\t\t\t\302\240\"Clock %pCn is running at %pCr Hz,\n" + "> > > +\t\t\t?\"Clock %pCn is running at %pCr Hz,\n" "> > > which is outside the recommended range of 1.9 to 5.0 MHz\\n\",\n" - "> > > +\t\t\t\302\240data->clk, data->clk);\n" + "> > > +\t\t\t?data->clk, data->clk);\n" "> > > +\t}\n" "> > > +\n" "> > > +\t/* register it */\n" "> > > +\ttz = thermal_zone_device_register(\"bcm2835_thermal\",\n" - "> > > +\t\t\t\t\t\302\240\302\2401, 0, data,\n" - "> > > +\t\t\t\t\t\302\240\302\240&bcm2835_thermal_ops,\n" - "> > > +\t\t\t\t\t\302\240\302\240NULL, 0, 0);\n" + "> > > +\t\t\t\t\t??1, 0, data,\n" + "> > > +\t\t\t\t\t??&bcm2835_thermal_ops,\n" + "> > > +\t\t\t\t\t??NULL, 0, 0);\n" "> > I notice that the polling_delay is set to 0, but we're not using\n" - "> > interrupts to trigger the trip.\302\240\302\240Is it valid to expose a trip\n" + "> > interrupts to trigger the trip.??Is it valid to expose a trip\n" "> > without a\n" - "> > polling_delay or interrupts?\302\240\302\240Should passive_delay be set as well?\n" + "> > polling_delay or interrupts???Should passive_delay be set as well?\n" "> > \n" - "> > This is up to the thermal maintainers.\302\240\302\240As far as I'm concerned,\n" + "> > This is up to the thermal maintainers.??As far as I'm concerned,\n" "> > it's:\n" "> > \n" "> > Acked-by: Eric Anholt <eric@anholt.net>\n" "> > \n" "> > One it lands I'll pull the defconfig and DT bits.\n" - "> Ping on this question to thermal maintainers.\302\240\302\240I'd still love to see\n" + "> Ping on this question to thermal maintainers.??I'd still love to see\n" "> this driver land.\n" "\n" "hmmm, how is this driver supposed to work?\n" @@ -103,4 +91,4 @@ "thanks,\n" rui -b7259ffde7b1fdc80ada4a4775025018cb4a5c705907ec2b01cc7e5383a29f49 +a22a69d6cb00a6dfc9773c0ad3d64c021c765605e0cd5e16a6f2ec3f7f34ee68
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.