From: "André Draszik" <git@andred.net>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-networking][PATCH 1/3] ifenslave: fix QA warning for GNU_HASH
Date: Fri, 19 Aug 2016 11:09:16 +0100 [thread overview]
Message-ID: <1471601356.24738.2.camel@andred.net> (raw)
In-Reply-To: <0159b82ac947ad69460adcec9d79ee83b76d2a7b.1471600808.git.yi.zhao@windriver.com>
On Fr, 2016-08-19 at 18:04 +0800, Yi Zhao wrote:
> Set LDFLAGS explicitly for do_compile
>
> Signed-off-by: Yi Zhao <yi.zhao@windriver.com>
> ---
> meta-networking/recipes-support/ifenslave/ifenslave_1.1.0.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-networking/recipes-support/ifenslave/ifenslave_1.1.0.bb
> b/meta-networking/recipes-support/ifenslave/ifenslave_1.1.0.bb
> index acc0864..385bc80 100644
> --- a/meta-networking/recipes-support/ifenslave/ifenslave_1.1.0.bb
> +++ b/meta-networking/recipes-support/ifenslave/ifenslave_1.1.0.bb
> @@ -10,7 +10,7 @@ SRC_URI[md5sum] = "56126cd1013cefe0ce6f81613e677bdd"
> SRC_URI[sha256sum] =
> "7917bf34de80a2492eb225adf9168c83a4854ac8a008ed0fd5b3fd147ccd3041"
>
> do_compile() {
> - ${CC} ifenslave.c -o ifenslave
> + ${CC} ${LDFLAGS} ifenslave.c -o ifenslave
While you're fixing the gcc invocation here, wouldn't it make sense to add
CFLAGS as well? (Maybe in a separate patch).
Cheers,
Andre'
next prev parent reply other threads:[~2016-08-19 10:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-19 10:04 [meta-networking][PATCH 0/3] NO_GNU_HASH warning fixes Yi Zhao
2016-08-19 10:04 ` [meta-networking][PATCH 1/3] ifenslave: fix QA warning for GNU_HASH Yi Zhao
2016-08-19 10:09 ` André Draszik [this message]
2016-08-19 16:45 ` Khem Raj
2016-08-22 2:04 ` Yi Zhao
2016-08-19 10:04 ` [meta-networking][PATCH 2/3] ipvsadm: " Yi Zhao
2016-08-19 10:04 ` [meta-networking][PATCH 3/3] iscsitarget: " Yi Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471601356.24738.2.camel@andred.net \
--to=git@andred.net \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.