From: "Manoharan, Rajkumar" <rmanohar@qti.qualcomm.com>
To: "Valo, Kalle" <kvalo@qca.qualcomm.com>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: master-pending: ODEBUG: free active (active state 0) object type: timer_list hint: ath10k_htt_rx_ring_refill_retry+0x0/0x10 [ath10k_core]
Date: Fri, 19 Aug 2016 12:14:47 +0000 [thread overview]
Message-ID: <1471608887214.2763@qti.qualcomm.com> (raw)
In-Reply-To: <878tvtyo1b.fsf@kamboji.qca.qualcomm.com>
[...]
>>
>> [ 277.244673] ------------[ cut here ]------------
>> [ 277.244685] WARNING: CPU: 2 PID: 2162 at lib/debugobjects.c:263 debug_print_object+0x85/0xa0
>> [ 277.244707] ODEBUG: free active (active state 0) object type: timer_list hint: ath10k_htt_rx_ring_refill_retry+0x0/0x10 [ath10k_core]
>
> I bisected this to:
>
> [v2] ath10k: implement NAPI support
>
> https://patchwork.kernel.org/patch/9240975/
>
> I'll reply to that patch for more info.
>
Oops.. my bad.. Sorry for the regression..Good that it is captured at earliest.
Thanks Kalle for reporting the issue.
It seems during deinit, driver is not waiting for NAPI completion. What debug options should be enabled to see this warning?
If possible, could you please try below change?
diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c
index 33380fba5948..29fc9052e51a 100644
--- a/drivers/net/wireless/ath/ath10k/pci.c
+++ b/drivers/net/wireless/ath/ath10k/pci.c
@@ -1759,6 +1759,7 @@ void ath10k_pci_ce_deinit(struct ath10k *ar)
void ath10k_pci_flush(struct ath10k *ar)
{
+ napi_synchronize(&ar->napi);
ath10k_pci_rx_retry_sync(ar);
ath10k_pci_buffer_cleanup(ar);
}
-Rajkumar
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2016-08-19 12:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-18 15:09 master-pending: ODEBUG: free active (active state 0) object type: timer_list hint: ath10k_htt_rx_ring_refill_retry+0x0/0x10 [ath10k_core] Valo, Kalle
2016-08-18 15:18 ` Ben Greear
2016-08-22 14:25 ` Valo, Kalle
2016-08-18 15:20 ` Valo, Kalle
2016-08-19 11:51 ` Valo, Kalle
2016-08-19 12:14 ` Manoharan, Rajkumar [this message]
2016-08-22 14:22 ` Valo, Kalle
2016-08-24 15:39 ` Manoharan, Rajkumar
2016-08-26 17:43 ` Valo, Kalle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471608887214.2763@qti.qualcomm.com \
--to=rmanohar@qti.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.