From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f69.google.com (mail-it0-f69.google.com [209.85.214.69]) by kanga.kvack.org (Postfix) with ESMTP id 058DE6B0261 for ; Fri, 19 Aug 2016 16:18:48 -0400 (EDT) Received: by mail-it0-f69.google.com with SMTP id j124so8604165ith.2 for ; Fri, 19 Aug 2016 13:18:48 -0700 (PDT) Received: from smtprelay.hostedemail.com (smtprelay0217.hostedemail.com. [216.40.44.217]) by mx.google.com with ESMTPS id l143si9630488iol.251.2016.08.19.13.18.47 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Aug 2016 13:18:47 -0700 (PDT) Message-ID: <1471637924.3893.48.camel@perches.com> Subject: Re: [PATCH 0/2] fs, proc: optimize smaps output formatting From: Joe Perches Date: Fri, 19 Aug 2016 13:18:44 -0700 In-Reply-To: <1471628595.3893.23.camel@perches.com> References: <1471519888-13829-1-git-send-email-mhocko@kernel.org> <1471601580-17999-1-git-send-email-mhocko@kernel.org> <1471628595.3893.23.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko , Andrew Morton Cc: Jann Horn , linux-mm@kvack.org, LKML On Fri, 2016-08-19 at 10:43 -0700, Joe Perches wrote: > And this would definitely be faster if seq_has_overflowed() was > used somewhere in the iteration loop. Adding a seq_has_overflowed() test seems unnecessary as the fs/seq_file.c traverse() static function already does a seq_has_overflowed(). And I get: $ t_mm (your allocate all vma program modified to show count) count: 65514 pid:2051 $ wc -c /proc/2051/smaps 39515615 /proc/2051/smaps smap vma output is a little more than 600 bytes per vma. I'll look around to see how best go use single_open_size assuming 768 bytes/vma rounded up to the next PAGE_SIZE. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932185AbcHSUTM (ORCPT ); Fri, 19 Aug 2016 16:19:12 -0400 Received: from smtprelay0198.hostedemail.com ([216.40.44.198]:48455 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754611AbcHSUTK (ORCPT ); Fri, 19 Aug 2016 16:19:10 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 30,2,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:421:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2194:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3351:3622:3653:3865:3867:3868:3870:3871:4321:5007:7903:9108:10010:10400:10848:11026:11232:11658:11914:12049:12296:12517:12519:12555:12679:12740:13069:13311:13357:13439:13870:13894:14659:14721:21080:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:1:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: floor55_86b3eb7927844 X-Filterd-Recvd-Size: 1561 Message-ID: <1471637924.3893.48.camel@perches.com> Subject: Re: [PATCH 0/2] fs, proc: optimize smaps output formatting From: Joe Perches To: Michal Hocko , Andrew Morton Cc: Jann Horn , linux-mm@kvack.org, LKML Date: Fri, 19 Aug 2016 13:18:44 -0700 In-Reply-To: <1471628595.3893.23.camel@perches.com> References: <1471519888-13829-1-git-send-email-mhocko@kernel.org> <1471601580-17999-1-git-send-email-mhocko@kernel.org> <1471628595.3893.23.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-08-19 at 10:43 -0700, Joe Perches wrote: > And this would definitely be faster if seq_has_overflowed() was > used somewhere in the iteration loop. Adding a seq_has_overflowed() test seems unnecessary as the fs/seq_file.c traverse() static function already does a seq_has_overflowed(). And I get: $ t_mm (your allocate all vma program modified to show count) count: 65514 pid:2051 $ wc -c /proc/2051/smaps  39515615 /proc/2051/smaps smap vma output is a little more than 600 bytes per vma. I'll look around to see how best go use single_open_size assuming 768 bytes/vma rounded up to the next PAGE_SIZE.