From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oleg Drokin Date: Sat, 20 Aug 2016 17:34:29 -0400 Subject: [lustre-devel] [PATCH 12/13] staging/lustre: Remove unused cp_error from struct cl_page In-Reply-To: <1471728870-518753-1-git-send-email-green@linuxhacker.ru> References: <1471728870-518753-1-git-send-email-green@linuxhacker.ru> Message-ID: <1471728870-518753-13-git-send-email-green@linuxhacker.ru> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Greg Kroah-Hartman , devel@driverdev.osuosl.org, Andreas Dilger Cc: Linux Kernel Mailing List , Lustre Development List , Oleg Drokin cp_error member is not really set anywhere, so kill it and the only printing user of it too. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/cl_object.h | 2 -- drivers/staging/lustre/lustre/obdclass/cl_page.c | 4 ++-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/lustre/lustre/include/cl_object.h b/drivers/staging/lustre/lustre/include/cl_object.h index 78613a9..6d8f956 100644 --- a/drivers/staging/lustre/lustre/include/cl_object.h +++ b/drivers/staging/lustre/lustre/include/cl_object.h @@ -726,8 +726,6 @@ struct cl_page { struct mutex cp_mutex; /** Linkage of pages within cl_req. */ struct list_head cp_flight; - /** Transfer error. */ - int cp_error; /** * Page type. Only CPT_TRANSIENT is used so far. Immutable after diff --git a/drivers/staging/lustre/lustre/obdclass/cl_page.c b/drivers/staging/lustre/lustre/obdclass/cl_page.c index db2dc6b..d903f71 100644 --- a/drivers/staging/lustre/lustre/obdclass/cl_page.c +++ b/drivers/staging/lustre/lustre/obdclass/cl_page.c @@ -989,9 +989,9 @@ void cl_page_header_print(const struct lu_env *env, void *cookie, lu_printer_t printer, const struct cl_page *pg) { (*printer)(env, cookie, - "page@%p[%d %p %d %d %d %p %p %#x]\n", + "page@%p[%d %p %d %d %p %p %#x]\n", pg, atomic_read(&pg->cp_ref), pg->cp_obj, - pg->cp_state, pg->cp_error, pg->cp_type, + pg->cp_state, pg->cp_type, pg->cp_owner, pg->cp_req, pg->cp_flags); } EXPORT_SYMBOL(cl_page_header_print); -- 2.7.4 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753261AbcHTVf5 (ORCPT ); Sat, 20 Aug 2016 17:35:57 -0400 Received: from linuxhacker.ru ([217.76.32.60]:36786 "EHLO fiona.linuxhacker.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753043AbcHTVfS (ORCPT ); Sat, 20 Aug 2016 17:35:18 -0400 From: Oleg Drokin To: Greg Kroah-Hartman , devel@driverdev.osuosl.org, Andreas Dilger Cc: Linux Kernel Mailing List , Lustre Development List , Oleg Drokin Subject: [PATCH 12/13] staging/lustre: Remove unused cp_error from struct cl_page Date: Sat, 20 Aug 2016 17:34:29 -0400 Message-Id: <1471728870-518753-13-git-send-email-green@linuxhacker.ru> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1471728870-518753-1-git-send-email-green@linuxhacker.ru> References: <1471728870-518753-1-git-send-email-green@linuxhacker.ru> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org cp_error member is not really set anywhere, so kill it and the only printing user of it too. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/cl_object.h | 2 -- drivers/staging/lustre/lustre/obdclass/cl_page.c | 4 ++-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/lustre/lustre/include/cl_object.h b/drivers/staging/lustre/lustre/include/cl_object.h index 78613a9..6d8f956 100644 --- a/drivers/staging/lustre/lustre/include/cl_object.h +++ b/drivers/staging/lustre/lustre/include/cl_object.h @@ -726,8 +726,6 @@ struct cl_page { struct mutex cp_mutex; /** Linkage of pages within cl_req. */ struct list_head cp_flight; - /** Transfer error. */ - int cp_error; /** * Page type. Only CPT_TRANSIENT is used so far. Immutable after diff --git a/drivers/staging/lustre/lustre/obdclass/cl_page.c b/drivers/staging/lustre/lustre/obdclass/cl_page.c index db2dc6b..d903f71 100644 --- a/drivers/staging/lustre/lustre/obdclass/cl_page.c +++ b/drivers/staging/lustre/lustre/obdclass/cl_page.c @@ -989,9 +989,9 @@ void cl_page_header_print(const struct lu_env *env, void *cookie, lu_printer_t printer, const struct cl_page *pg) { (*printer)(env, cookie, - "page@%p[%d %p %d %d %d %p %p %#x]\n", + "page@%p[%d %p %d %d %p %p %#x]\n", pg, atomic_read(&pg->cp_ref), pg->cp_obj, - pg->cp_state, pg->cp_error, pg->cp_type, + pg->cp_state, pg->cp_type, pg->cp_owner, pg->cp_req, pg->cp_flags); } EXPORT_SYMBOL(cl_page_header_print); -- 2.7.4