diff for duplicates of <1471786649.2188.4.camel@intel.com> diff --git a/a/1.txt b/N1/1.txt index 8f0d967..312eaae 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,14 +1,14 @@ -On 五, 2016-08-19 at 11:59 -0700, Eric Anholt wrote: +On ?, 2016-08-19 at 11:59 -0700, Eric Anholt wrote: > Zhang Rui <rui.zhang@intel.com> writes: > > > -> > On 四, 2016-08-18 at 11:39 -0700, Eric Anholt wrote: +> > On ?, 2016-08-18 at 11:39 -0700, Eric Anholt wrote: > > > > > > Eric Anholt <eric@anholt.net> writes: > > > > > > > > > > > -> > > > kernel@martin.sperl.org writes: +> > > > kernel at martin.sperl.org writes: > > > > > > > > > > > > > > @@ -22,13 +22,13 @@ On 五, 2016-08-19 at 11:59 -0700, Eric Anholt wrote: > > > > > Signed-off-by: Martin Sperl <kernel@martin.sperl.org> > > > > > > > > > > ChangeLog: -> > > > > V1 -> V2: added specific settings depending on compatiblity -> > > > > added trip point based on register -> > > > > setting up ctrl-register if HW is not enabled by +> > > > > ?V1 -> V2: added specific settings depending on compatiblity +> > > > > ???added trip point based on register +> > > > > ???setting up ctrl-register if HW is not enabled by > > > > > firmware -> > > > > as per recommendation of Eric (untested) -> > > > > check that clock frequency is in range -> > > > > (1.9 - 5MHz - as per comment in clk-bcm2835.c) +> > > > > ?????as per recommendation of Eric (untested) +> > > > > ???check that clock frequency is in range +> > > > > ?????(1.9 - 5MHz - as per comment in clk-bcm2835.c) > > > > > --- > > > > > > > > > > diff --git a/drivers/thermal/bcm/Makefile @@ -58,32 +58,32 @@ On 五, 2016-08-19 at 11:59 -0700, Eric Anholt wrote: > > > > > + rate = clk_get_rate(data->clk); > > > > > + if ((rate < 1920000) || (rate > 5000000)) { > > > > > + dev_warn(&pdev->dev, -> > > > > + "Clock %pCn is running at %pCr Hz, +> > > > > + ?"Clock %pCn is running at %pCr Hz, > > > > > which is outside the recommended range of 1.9 to 5.0 MHz\n", -> > > > > + data->clk, data->clk); +> > > > > + ?data->clk, data->clk); > > > > > + } > > > > > + > > > > > + /* register it */ > > > > > + tz = thermal_zone_device_register("bcm2835_thermal", -> > > > > + 1, 0, data, -> > > > > + &bcm2835_thermal_o +> > > > > + ??1, 0, data, +> > > > > + ??&bcm2835_thermal_o > > > > > ps, -> > > > > + NULL, 0, 0); +> > > > > + ??NULL, 0, 0); > > > > I notice that the polling_delay is set to 0, but we're not > > > > using -> > > > interrupts to trigger the trip. Is it valid to expose a trip +> > > > interrupts to trigger the trip.??Is it valid to expose a trip > > > > without a -> > > > polling_delay or interrupts? Should passive_delay be set as +> > > > polling_delay or interrupts???Should passive_delay be set as > > > > well? > > > > -> > > > This is up to the thermal maintainers. As far as I'm +> > > > This is up to the thermal maintainers.??As far as I'm > > > > concerned, > > > > it's: > > > > > > > > Acked-by: Eric Anholt <eric@anholt.net> > > > > > > > > One it lands I'll pull the defconfig and DT bits. -> > > Ping on this question to thermal maintainers. I'd still love to +> > > Ping on this question to thermal maintainers.??I'd still love to > > > see > > > this driver land. > > hmmm, how is this driver supposed to work? @@ -92,7 +92,7 @@ On 五, 2016-08-19 at 11:59 -0700, Eric Anholt wrote: > > temperature and trip point information via thermal sysfs interface, > > but > > kernel thermal control is a no-op here, right? -> Yeah. It seems useful to be able to get the information. Once we +> Yeah.??It seems useful to be able to get the information.??Once we > land > this, I hope someone can add interrupt support so that there are > actual @@ -100,7 +100,7 @@ On 五, 2016-08-19 at 11:59 -0700, Eric Anholt wrote: sounds reasonable to me. Another question, why you need a separate directory for a single -file, bcm2835_thermal.c? +file,?bcm2835_thermal.c? thanks, rui diff --git a/a/content_digest b/N1/content_digest index c65c021..2198521 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -4,35 +4,23 @@ "ref\087r39lvs4v.fsf@eliezer.anholt.net\0" "ref\01471591694.2691.39.camel@intel.com\0" "ref\087inuwd1p4.fsf@eliezer.anholt.net\0" - "From\0Zhang Rui <rui.zhang@intel.com>\0" - "Subject\0Re: [PATCH V3 2/5] thermal: bcm2835: add thermal driver for bcm2835 soc\0" + "From\0rui.zhang@intel.com (Zhang Rui)\0" + "Subject\0[PATCH V3 2/5] thermal: bcm2835: add thermal driver for bcm2835 soc\0" "Date\0Sun, 21 Aug 2016 21:37:29 +0800\0" - "To\0Eric Anholt <eric@anholt.net>" - kernel@martin.sperl.org - Eduardo Valentin <edubezval@gmail.com> - Rob Herring <robh+dt@kernel.org> - Pawel Moll <pawel.moll@arm.com> - Mark Rutland <mark.rutland@arm.com> - Stephen Warren <swarren@wwwdotorg.org> - Lee Jones <lee@kernel.org> - Russell King <linux@arm.linux.org.uk> - linux-pm@vger.kernel.org - devicetree@vger.kernel.org - linux-rpi-kernel@lists.infradead.org - " linux-arm-kernel@lists.infradead.org\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" - "On \344\272\224, 2016-08-19 at 11:59 -0700, Eric Anholt wrote:\n" + "On ?, 2016-08-19 at 11:59 -0700, Eric Anholt wrote:\n" "> Zhang Rui <rui.zhang@intel.com> writes:\n" "> \n" "> > \n" - "> > On \345\233\233, 2016-08-18 at 11:39 -0700, Eric Anholt wrote:\n" + "> > On ?, 2016-08-18 at 11:39 -0700, Eric Anholt wrote:\n" "> > > \n" "> > > Eric Anholt <eric@anholt.net> writes:\n" "> > > \n" "> > > > \n" "> > > > \n" - "> > > > kernel@martin.sperl.org writes:\n" + "> > > > kernel at martin.sperl.org writes:\n" "> > > > \n" "> > > > > \n" "> > > > > \n" @@ -46,13 +34,13 @@ "> > > > > Signed-off-by: Martin Sperl <kernel@martin.sperl.org>\n" "> > > > > \n" "> > > > > ChangeLog:\n" - "> > > > > \302\240V1 -> V2: added specific settings depending on compatiblity\n" - "> > > > > \t\302\240\302\240\302\240added trip point based on register\n" - "> > > > > \t\302\240\302\240\302\240setting up ctrl-register if HW is not enabled by\n" + "> > > > > ?V1 -> V2: added specific settings depending on compatiblity\n" + "> > > > > \t???added trip point based on register\n" + "> > > > > \t???setting up ctrl-register if HW is not enabled by\n" "> > > > > firmware\n" - "> > > > > \t\302\240\302\240\302\240\302\240\302\240as per recommendation of Eric (untested)\n" - "> > > > > \t\302\240\302\240\302\240check that clock frequency is in range\n" - "> > > > > \t\302\240\302\240\302\240\302\240\302\240(1.9 - 5MHz - as per comment in clk-bcm2835.c)\n" + "> > > > > \t?????as per recommendation of Eric (untested)\n" + "> > > > > \t???check that clock frequency is in range\n" + "> > > > > \t?????(1.9 - 5MHz - as per comment in clk-bcm2835.c)\n" "> > > > > ---\n" "> > > > > \n" "> > > > > diff --git a/drivers/thermal/bcm/Makefile\n" @@ -82,32 +70,32 @@ "> > > > > +\trate = clk_get_rate(data->clk);\n" "> > > > > +\tif ((rate < 1920000) || (rate > 5000000)) {\n" "> > > > > +\t\tdev_warn(&pdev->dev,\n" - "> > > > > +\t\t\t\302\240\"Clock %pCn is running at %pCr Hz,\n" + "> > > > > +\t\t\t?\"Clock %pCn is running at %pCr Hz,\n" "> > > > > which is outside the recommended range of 1.9 to 5.0 MHz\\n\",\n" - "> > > > > +\t\t\t\302\240data->clk, data->clk);\n" + "> > > > > +\t\t\t?data->clk, data->clk);\n" "> > > > > +\t}\n" "> > > > > +\n" "> > > > > +\t/* register it */\n" "> > > > > +\ttz = thermal_zone_device_register(\"bcm2835_thermal\",\n" - "> > > > > +\t\t\t\t\t\302\240\302\2401, 0, data,\n" - "> > > > > +\t\t\t\t\t\302\240\302\240&bcm2835_thermal_o\n" + "> > > > > +\t\t\t\t\t??1, 0, data,\n" + "> > > > > +\t\t\t\t\t??&bcm2835_thermal_o\n" "> > > > > ps,\n" - "> > > > > +\t\t\t\t\t\302\240\302\240NULL, 0, 0);\n" + "> > > > > +\t\t\t\t\t??NULL, 0, 0);\n" "> > > > I notice that the polling_delay is set to 0, but we're not\n" "> > > > using\n" - "> > > > interrupts to trigger the trip.\302\240\302\240Is it valid to expose a trip\n" + "> > > > interrupts to trigger the trip.??Is it valid to expose a trip\n" "> > > > without a\n" - "> > > > polling_delay or interrupts?\302\240\302\240Should passive_delay be set as\n" + "> > > > polling_delay or interrupts???Should passive_delay be set as\n" "> > > > well?\n" "> > > > \n" - "> > > > This is up to the thermal maintainers.\302\240\302\240As far as I'm\n" + "> > > > This is up to the thermal maintainers.??As far as I'm\n" "> > > > concerned,\n" "> > > > it's:\n" "> > > > \n" "> > > > Acked-by: Eric Anholt <eric@anholt.net>\n" "> > > > \n" "> > > > One it lands I'll pull the defconfig and DT bits.\n" - "> > > Ping on this question to thermal maintainers.\302\240\302\240I'd still love to\n" + "> > > Ping on this question to thermal maintainers.??I'd still love to\n" "> > > see\n" "> > > this driver land.\n" "> > hmmm, how is this driver supposed to work?\n" @@ -116,7 +104,7 @@ "> > temperature and trip point information via thermal sysfs interface,\n" "> > but\n" "> > kernel thermal control is a no-op here, right?\n" - "> Yeah.\302\240\302\240It seems useful to be able to get the information.\302\240\302\240Once we\n" + "> Yeah.??It seems useful to be able to get the information.??Once we\n" "> land\n" "> this, I hope someone can add interrupt support so that there are\n" "> actual\n" @@ -124,9 +112,9 @@ "\n" "sounds reasonable to me.\n" "Another question, why you need a separate directory for a single\n" - "file,\302\240bcm2835_thermal.c?\n" + "file,?bcm2835_thermal.c?\n" "\n" "thanks,\n" rui -ffc94bdc9935224d90003057e9c5e0406a43a31350646ced4153de3afdfb8921 +efa20e831306ead6ff0ece7b71047a83d5bb53f0e3ae1cb9e9e32b05cbb45662
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.