From mboxrd@z Thu Jan  1 00:00:00 1970
From: Joe Perches <joe@perches.com>
Subject: Re: [PATCH 1/1] drm/amdgpu/gmc7: remove dead code
Date: Sun, 21 Aug 2016 11:29:11 -0700
Message-ID: <1471804151.3746.7.camel@perches.com>
References: <1471802792-3059-1-git-send-email-xypron.glpk@gmx.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 8bit
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <1471802792-3059-1-git-send-email-xypron.glpk@gmx.de>
Sender: linux-kernel-owner@vger.kernel.org
To: Heinrich Schuchardt <xypron.glpk@gmx.de>, Alex Deucher <alexander.deucher@amd.com>, Christian =?ISO-8859-1?Q?K=F6nig?= <christian.koenig@amd.com>
Cc: David Airlie <airlied@linux.ie>, Chunming Zhou <David1.Zhou@amd.com>, Ken Wang <Qingqing.Wang@amd.com>, Tom St Denis <tom.stdenis@amd.com>, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
List-Id: dri-devel@lists.freedesktop.org

On Sun, 2016-08-21 at 20:06 +0200, Heinrich Schuchardt wrote:
> In an if block for (running == 0) running cannot be non-zero.

This code could also be better unindented by one level
(all of the block would fit 80 columns) by changing:

	if (running == 0) {
		[code...]
	}

	return 0;

to:

	if (running)
		return 0;

	[code...]

	return 0;
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c
[]
> @@ -203,11 +203,6 @@ static int gmc_v7_0_mc_load_microcode(struct amdgpu_device *adev)
>  	running = REG_GET_FIELD(RREG32(mmMC_SEQ_SUP_CNTL), MC_SEQ_SUP_CNTL, RUN);
>  
>  	if (running == 0) {
> -		if (running) {
> -			blackout = RREG32(mmMC_SHARED_BLACKOUT_CNTL);
> -			WREG32(mmMC_SHARED_BLACKOUT_CNTL, blackout | 1);
> -		}
> -
>  		/* reset the engine and set to writable */
>  		WREG32(mmMC_SEQ_SUP_CNTL, 0x00000008);
>  		WREG32(mmMC_SEQ_SUP_CNTL, 0x00000010);
> @@ -239,9 +234,6 @@ static int gmc_v7_0_mc_load_microcode(struct amdgpu_device *adev)
>  				break;
>  			udelay(1);
>  		}
> -
> -		if (running)
> -			WREG32(mmMC_SHARED_BLACKOUT_CNTL, blackout);
>  	}
>  
>  	return 0;