diff for duplicates of <1471851940.2188.22.camel@intel.com> diff --git a/a/1.txt b/N1/1.txt index ea31105..e6f643b 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,22 +1,22 @@ -On 日, 2016-08-21 at 19:21 +0200, Martin Sperl wrote: +On ?, 2016-08-21 at 19:21 +0200, Martin Sperl wrote: > > > > On 21.08.2016, at 15:37, Zhang Rui <rui.zhang@intel.com> wrote: > > > > > -> > > On 五, 2016-08-19 at 11:59 -0700, Eric Anholt wrote: +> > > On ?, 2016-08-19 at 11:59 -0700, Eric Anholt wrote: > > > Zhang Rui <rui.zhang@intel.com> writes: > > > > > > > > > > > > > > > > -> > > > > On 四, 2016-08-18 at 11:39 -0700, Eric Anholt wrote: +> > > > > On ?, 2016-08-18 at 11:39 -0700, Eric Anholt wrote: > > > > > > > > > > Eric Anholt <eric@anholt.net> writes: > > > > > > > > > > > > > > > > > > > > > > > -> > > > > > kernel@martin.sperl.org writes: +> > > > > > kernel at martin.sperl.org writes: > > > > > > > > > > > > > > > > > > > > @@ -32,14 +32,14 @@ On 日, 2016-08-21 at 19:21 +0200, Martin Sperl wrote: > > > > > > > Signed-off-by: Martin Sperl <kernel@martin.sperl.org> > > > > > > > > > > > > > > ChangeLog: -> > > > > > > V1 -> V2: added specific settings depending on +> > > > > > > ?V1 -> V2: added specific settings depending on > > > > > > > compatiblity -> > > > > > > added trip point based on register -> > > > > > > setting up ctrl-register if HW is not enabled by +> > > > > > > ??????added trip point based on register +> > > > > > > ??????setting up ctrl-register if HW is not enabled by > > > > > > > firmware -> > > > > > > as per recommendation of Eric (untested) -> > > > > > > check that clock frequency is in range -> > > > > > > (1.9 - 5MHz - as per comment in clk-bcm2835.c) +> > > > > > > ????????as per recommendation of Eric (untested) +> > > > > > > ??????check that clock frequency is in range +> > > > > > > ????????(1.9 - 5MHz - as per comment in clk-bcm2835.c) > > > > > > > --- > > > > > > > > > > > > > > diff --git a/drivers/thermal/bcm/Makefile @@ -49,7 +49,7 @@ On 日, 2016-08-21 at 19:21 +0200, Martin Sperl wrote: > > > > > > > --- /dev/null > > > > > > > +++ b/drivers/thermal/bcm/Makefile > > > > > > > @@ -0,0 +1 @@ -> > > > > > > +obj-$(CONFIG_BCM2835_THERMAL) := +> > > > > > > +obj-$(CONFIG_BCM2835_THERMAL)????????:= > > > > > > > bcm2835_thermal.o > > > > > > > diff --git a/drivers/thermal/bcm/bcm2835_thermal.c > > > > > > > b/drivers/thermal/bcm/bcm2835_thermal.c @@ -64,40 +64,40 @@ On 日, 2016-08-21 at 19:21 +0200, Martin Sperl wrote: > > > > > > > *pdev) > > > > > > > +{ > > > > > > > -> > > > > > > + /* enable clock and check rate */ -> > > > > > > + clk_prepare_enable(data->clk); -> > > > > > > + rate = clk_get_rate(data->clk); -> > > > > > > + if ((rate < 1920000) || (rate > 5000000)) { -> > > > > > > + dev_warn(&pdev->dev, -> > > > > > > + "Clock %pCn is running at %pCr Hz, +> > > > > > > +????/* enable clock and check rate */ +> > > > > > > +????clk_prepare_enable(data->clk); +> > > > > > > +????rate = clk_get_rate(data->clk); +> > > > > > > +????if ((rate < 1920000) || (rate > 5000000)) { +> > > > > > > +????????dev_warn(&pdev->dev, +> > > > > > > +?????????????"Clock %pCn is running at %pCr Hz, > > > > > > > which is outside the recommended range of 1.9 to 5.0 > > > > > > > MHz\n", -> > > > > > > + data->clk, data->clk); -> > > > > > > + } +> > > > > > > +?????????????data->clk, data->clk); +> > > > > > > +????} > > > > > > > + -> > > > > > > + /* register it */ -> > > > > > > + tz = thermal_zone_device_register("bcm2835_thermal", -> > > > > > > + 1, 0, data, -> > > > > > > + &bcm2835_thermal_o +> > > > > > > +????/* register it */ +> > > > > > > +????tz = thermal_zone_device_register("bcm2835_thermal", +> > > > > > > +??????????????????????1, 0, data, +> > > > > > > +??????????????????????&bcm2835_thermal_o > > > > > > > ps, -> > > > > > > + NULL, 0, 0); +> > > > > > > +??????????????????????NULL, 0, 0); > > > > > > I notice that the polling_delay is set to 0, but we're not > > > > > > using -> > > > > > interrupts to trigger the trip. Is it valid to expose a +> > > > > > interrupts to trigger the trip.??Is it valid to expose a > > > > > > trip > > > > > > without a -> > > > > > polling_delay or interrupts? Should passive_delay be set +> > > > > > polling_delay or interrupts???Should passive_delay be set > > > > > > as > > > > > > well? > > > > > > -> > > > > > This is up to the thermal maintainers. As far as I'm +> > > > > > This is up to the thermal maintainers.??As far as I'm > > > > > > concerned, > > > > > > it's: > > > > > > > > > > > > Acked-by: Eric Anholt <eric@anholt.net> > > > > > > > > > > > > One it lands I'll pull the defconfig and DT bits. -> > > > > Ping on this question to thermal maintainers. I'd still love +> > > > > Ping on this question to thermal maintainers.??I'd still love > > > > > to > > > > > see > > > > > this driver land. @@ -109,7 +109,7 @@ On 日, 2016-08-21 at 19:21 +0200, Martin Sperl wrote: > > > > interface, > > > > but > > > > kernel thermal control is a no-op here, right? -> > > Yeah. It seems useful to be able to get the information. Once +> > > Yeah.??It seems useful to be able to get the information.??Once > > > we > > > land > > > this, I hope someone can add interrupt support so that there are diff --git a/a/content_digest b/N1/content_digest index 3d4e892..e90aeed 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -6,43 +6,31 @@ "ref\087inuwd1p4.fsf@eliezer.anholt.net\0" "ref\01471786649.2188.4.camel@intel.com\0" "ref\046FE06A3-5A7D-41D7-827B-C7B35E42E2C5@martin.sperl.org\0" - "From\0Zhang Rui <rui.zhang@intel.com>\0" - "Subject\0Re: [PATCH V3 2/5] thermal: bcm2835: add thermal driver for bcm2835 soc\0" + "From\0rui.zhang@intel.com (Zhang Rui)\0" + "Subject\0[PATCH V3 2/5] thermal: bcm2835: add thermal driver for bcm2835 soc\0" "Date\0Mon, 22 Aug 2016 15:45:40 +0800\0" - "To\0Martin Sperl <kernel@martin.sperl.org>\0" - "Cc\0Eric Anholt <eric@anholt.net>" - Eduardo Valentin <edubezval@gmail.com> - Rob Herring <robh+dt@kernel.org> - Pawel Moll <pawel.moll@arm.com> - Mark Rutland <mark.rutland@arm.com> - Stephen Warren <swarren@wwwdotorg.org> - Lee Jones <lee@kernel.org> - Russell King <linux@arm.linux.org.uk> - linux-pm@vger.kernel.org - devicetree@vger.kernel.org - linux-rpi-kernel@lists.infradead.org - " linux-arm-kernel@lists.infradead.org\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" - "On \346\227\245, 2016-08-21 at 19:21 +0200, Martin Sperl wrote:\n" + "On ?, 2016-08-21 at 19:21 +0200, Martin Sperl wrote:\n" "> > \n" "> > On 21.08.2016, at 15:37, Zhang Rui <rui.zhang@intel.com> wrote:\n" "> > \n" "> > > \n" - "> > > On \344\272\224, 2016-08-19 at 11:59 -0700, Eric Anholt wrote:\n" + "> > > On ?, 2016-08-19 at 11:59 -0700, Eric Anholt wrote:\n" "> > > Zhang Rui <rui.zhang@intel.com> writes:\n" "> > > \n" "> > > > \n" "> > > > \n" "> > > > > \n" - "> > > > > On \345\233\233, 2016-08-18 at 11:39 -0700, Eric Anholt wrote:\n" + "> > > > > On ?, 2016-08-18 at 11:39 -0700, Eric Anholt wrote:\n" "> > > > > \n" "> > > > > Eric Anholt <eric@anholt.net> writes:\n" "> > > > > \n" "> > > > > > \n" "> > > > > > \n" "> > > > > > \n" - "> > > > > > kernel@martin.sperl.org writes:\n" + "> > > > > > kernel at martin.sperl.org writes:\n" "> > > > > > \n" "> > > > > > > \n" "> > > > > > > \n" @@ -58,14 +46,14 @@ "> > > > > > > Signed-off-by: Martin Sperl <kernel@martin.sperl.org>\n" "> > > > > > > \n" "> > > > > > > ChangeLog:\n" - "> > > > > > > \302\240V1 -> V2: added specific settings depending on\n" + "> > > > > > > ?V1 -> V2: added specific settings depending on\n" "> > > > > > > compatiblity\n" - "> > > > > > > \302\240\302\240\302\240\302\240\302\240\302\240added trip point based on register\n" - "> > > > > > > \302\240\302\240\302\240\302\240\302\240\302\240setting up ctrl-register if HW is not enabled by\n" + "> > > > > > > ??????added trip point based on register\n" + "> > > > > > > ??????setting up ctrl-register if HW is not enabled by\n" "> > > > > > > firmware\n" - "> > > > > > > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240as per recommendation of Eric (untested)\n" - "> > > > > > > \302\240\302\240\302\240\302\240\302\240\302\240check that clock frequency is in range\n" - "> > > > > > > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240(1.9 - 5MHz - as per comment in clk-bcm2835.c)\n" + "> > > > > > > ????????as per recommendation of Eric (untested)\n" + "> > > > > > > ??????check that clock frequency is in range\n" + "> > > > > > > ????????(1.9 - 5MHz - as per comment in clk-bcm2835.c)\n" "> > > > > > > ---\n" "> > > > > > > \n" "> > > > > > > diff --git a/drivers/thermal/bcm/Makefile\n" @@ -75,7 +63,7 @@ "> > > > > > > --- /dev/null\n" "> > > > > > > +++ b/drivers/thermal/bcm/Makefile\n" "> > > > > > > @@ -0,0 +1 @@\n" - "> > > > > > > +obj-$(CONFIG_BCM2835_THERMAL)\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240:=\n" + "> > > > > > > +obj-$(CONFIG_BCM2835_THERMAL)????????:=\n" "> > > > > > > bcm2835_thermal.o\n" "> > > > > > > diff --git a/drivers/thermal/bcm/bcm2835_thermal.c\n" "> > > > > > > b/drivers/thermal/bcm/bcm2835_thermal.c\n" @@ -90,40 +78,40 @@ "> > > > > > > *pdev)\n" "> > > > > > > +{\n" "> > > > > > > \n" - "> > > > > > > +\302\240\302\240\302\240\302\240/* enable clock and check rate */\n" - "> > > > > > > +\302\240\302\240\302\240\302\240clk_prepare_enable(data->clk);\n" - "> > > > > > > +\302\240\302\240\302\240\302\240rate = clk_get_rate(data->clk);\n" - "> > > > > > > +\302\240\302\240\302\240\302\240if ((rate < 1920000) || (rate > 5000000)) {\n" - "> > > > > > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240dev_warn(&pdev->dev,\n" - "> > > > > > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\"Clock %pCn is running at %pCr Hz,\n" + "> > > > > > > +????/* enable clock and check rate */\n" + "> > > > > > > +????clk_prepare_enable(data->clk);\n" + "> > > > > > > +????rate = clk_get_rate(data->clk);\n" + "> > > > > > > +????if ((rate < 1920000) || (rate > 5000000)) {\n" + "> > > > > > > +????????dev_warn(&pdev->dev,\n" + "> > > > > > > +?????????????\"Clock %pCn is running at %pCr Hz,\n" "> > > > > > > which is outside the recommended range of 1.9 to 5.0\n" "> > > > > > > MHz\\n\",\n" - "> > > > > > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240data->clk, data->clk);\n" - "> > > > > > > +\302\240\302\240\302\240\302\240}\n" + "> > > > > > > +?????????????data->clk, data->clk);\n" + "> > > > > > > +????}\n" "> > > > > > > +\n" - "> > > > > > > +\302\240\302\240\302\240\302\240/* register it */\n" - "> > > > > > > +\302\240\302\240\302\240\302\240tz = thermal_zone_device_register(\"bcm2835_thermal\",\n" - "> > > > > > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\2401, 0, data,\n" - "> > > > > > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240&bcm2835_thermal_o\n" + "> > > > > > > +????/* register it */\n" + "> > > > > > > +????tz = thermal_zone_device_register(\"bcm2835_thermal\",\n" + "> > > > > > > +??????????????????????1, 0, data,\n" + "> > > > > > > +??????????????????????&bcm2835_thermal_o\n" "> > > > > > > ps,\n" - "> > > > > > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240NULL, 0, 0);\n" + "> > > > > > > +??????????????????????NULL, 0, 0);\n" "> > > > > > I notice that the polling_delay is set to 0, but we're not\n" "> > > > > > using\n" - "> > > > > > interrupts to trigger the trip.\302\240\302\240Is it valid to expose a\n" + "> > > > > > interrupts to trigger the trip.??Is it valid to expose a\n" "> > > > > > trip\n" "> > > > > > without a\n" - "> > > > > > polling_delay or interrupts?\302\240\302\240Should passive_delay be set\n" + "> > > > > > polling_delay or interrupts???Should passive_delay be set\n" "> > > > > > as\n" "> > > > > > well?\n" "> > > > > > \n" - "> > > > > > This is up to the thermal maintainers.\302\240\302\240As far as I'm\n" + "> > > > > > This is up to the thermal maintainers.??As far as I'm\n" "> > > > > > concerned,\n" "> > > > > > it's:\n" "> > > > > > \n" "> > > > > > Acked-by: Eric Anholt <eric@anholt.net>\n" "> > > > > > \n" "> > > > > > One it lands I'll pull the defconfig and DT bits.\n" - "> > > > > Ping on this question to thermal maintainers.\302\240\302\240I'd still love\n" + "> > > > > Ping on this question to thermal maintainers.??I'd still love\n" "> > > > > to\n" "> > > > > see\n" "> > > > > this driver land.\n" @@ -135,7 +123,7 @@ "> > > > interface,\n" "> > > > but\n" "> > > > kernel thermal control is a no-op here, right?\n" - "> > > Yeah.\302\240\302\240It seems useful to be able to get the information.\302\240\302\240Once\n" + "> > > Yeah.??It seems useful to be able to get the information.??Once\n" "> > > we\n" "> > > land\n" "> > > this, I hope someone can add interrupt support so that there are\n" @@ -162,4 +150,4 @@ "rui\n" > Thanks, Martin -03e91c377c576c109a225d64b8b5c86ba8b2eb4dc9d81ce92de3f46ebb3d79ae +56a2f09d65ce509074a74233196f493a4508136d13edab2c2afa22ced12c2361
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.