From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f70.google.com (mail-oi0-f70.google.com [209.85.218.70]) by kanga.kvack.org (Postfix) with ESMTP id 73D5E6B0069 for ; Mon, 22 Aug 2016 04:01:03 -0400 (EDT) Received: by mail-oi0-f70.google.com with SMTP id p18so295283422oic.0 for ; Mon, 22 Aug 2016 01:01:03 -0700 (PDT) Received: from smtprelay.hostedemail.com (smtprelay0182.hostedemail.com. [216.40.44.182]) by mx.google.com with ESMTPS id d75si15007175ith.69.2016.08.22.01.01.02 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Aug 2016 01:01:02 -0700 (PDT) Message-ID: <1471852859.3746.42.camel@perches.com> Subject: Re: [PATCH 2/2] proc: task_mmu: Reduce output processing cpu time From: Joe Perches Date: Mon, 22 Aug 2016 01:00:59 -0700 In-Reply-To: <20160822072414.GB13596@dhcp22.suse.cz> References: <2c1ea0d8f35fa5ddea477369b273d6d91c5bf2e2.1471679737.git.joe@perches.com> <20160822072414.GB13596@dhcp22.suse.cz> Content-Type: text/plain; charset="ISO-8859-1" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: linux-kernel@vger.kernel.org, Andrew Morton , Jann Horn , linux-mm@kvack.org On Mon, 2016-08-22 at 09:24 +0200, Michal Hocko wrote: > On Sat 20-08-16 01:00:17, Joe Perches wrote: > [...] > > > > static int proc_maps_open(struct inode *inode, struct file *file, > > const struct seq_operations *ops, int psize) > > { > > - struct proc_maps_private *priv = __seq_open_private(file, ops, psize); > > + struct proc_maps_private *priv; > > + struct mm_struct *mm; > > + > > + mm = proc_mem_open(inode, PTRACE_MODE_READ); > > + if (IS_ERR(mm)) > > + return PTR_ERR(mm); > > > > + priv = __seq_open_private_bufsize(file, ops, psize, > > + mm && mm->map_count ? > > + mm->map_count * 0x300 : PAGE_SIZE); > NAK to this! > > Seriously, this just gives any random user access to user > defined amount of memory which not accounted, not reclaimable and a > potential consumer of any higher order blocks. I completely disagree here with your rationale here. I think you didn't read the code and didn't try it either. This code is identical to the previous code but it simply estimates the required output size first. > Besides that, at least one show_smap output will always fit inside the > single page and AFAIR (it's been quite a while since I've looked into > seq_file internals) the buffer grows only when the single show doesn't > fit in. It's never been like that as far as I know. Please read fs/seq_file.c:traverse() This code starts with a PAGE_SIZE block of memory then if the complete output doesn't fit, stops, frees that block of memory, and retries the complete output with a last block size allocated << 1 and tries again. > I really do not understand why you insist on code duplication rather > than reuse but if you really insist then just make this (without the > above __seq_open_private_bufsize, re-measure and add the results to the > changelog and repost. I've tried it, I wish you would. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752824AbcHVICS (ORCPT ); Mon, 22 Aug 2016 04:02:18 -0400 Received: from smtprelay0209.hostedemail.com ([216.40.44.209]:59545 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750839AbcHVIBD (ORCPT ); Mon, 22 Aug 2016 04:01:03 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:960:966:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2196:2198:2199:2200:2393:2559:2562:2690:2692:2693:2731:2828:2901:2912:3138:3139:3140:3141:3142:3354:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4321:4385:5007:6119:7903:8603:9040:10004:10400:10450:10455:10848:11026:11232:11473:11658:11783:11914:12043:12214:12296:12438:12517:12519:12740:13069:13141:13153:13161:13228:13229:13230:13311:13357:13439:13869:13894:14096:14097:14659:14721:19904:19999:21080:21451:30005:30012:30051:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:4,LUA_SUMMARY:none X-HE-Tag: value74_7d4ceacef1106 X-Filterd-Recvd-Size: 2830 Message-ID: <1471852859.3746.42.camel@perches.com> Subject: Re: [PATCH 2/2] proc: task_mmu: Reduce output processing cpu time From: Joe Perches To: Michal Hocko Cc: linux-kernel@vger.kernel.org, Andrew Morton , Jann Horn , linux-mm@kvack.org Date: Mon, 22 Aug 2016 01:00:59 -0700 In-Reply-To: <20160822072414.GB13596@dhcp22.suse.cz> References: <2c1ea0d8f35fa5ddea477369b273d6d91c5bf2e2.1471679737.git.joe@perches.com> <20160822072414.GB13596@dhcp22.suse.cz> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2016-08-22 at 09:24 +0200, Michal Hocko wrote: > On Sat 20-08-16 01:00:17, Joe Perches wrote: > [...] > > > >  static int proc_maps_open(struct inode *inode, struct file *file, > >   const struct seq_operations *ops, int psize) > >  { > > - struct proc_maps_private *priv = __seq_open_private(file, ops, psize); > > + struct proc_maps_private *priv; > > + struct mm_struct *mm; > > + > > + mm = proc_mem_open(inode, PTRACE_MODE_READ); > > + if (IS_ERR(mm)) > > + return PTR_ERR(mm); > >   > > + priv = __seq_open_private_bufsize(file, ops, psize, > > +   mm && mm->map_count ? > > +   mm->map_count * 0x300 : PAGE_SIZE); > NAK to this! > > Seriously, this just gives any random user access to user > defined amount of memory which not accounted, not reclaimable and a > potential consumer of any higher order blocks. I completely disagree here with your rationale here. I think you didn't read the code and didn't try it either. This code is identical to the previous code but it simply estimates the required output size first. > Besides that, at least one show_smap output will always fit inside the > single page and AFAIR (it's been quite a while since I've looked into > seq_file internals) the buffer grows only when the single show doesn't > fit in. It's never been like that as far as I know. Please read fs/seq_file.c:traverse() This code starts with a PAGE_SIZE block of memory then if the complete output doesn't fit, stops, frees that block of memory, and retries the complete output with a last block size allocated << 1 and tries again. > I really do not understand why you insist on code duplication rather > than reuse but if you really insist then just make this (without the > above __seq_open_private_bufsize, re-measure and add the results to the > changelog and repost. I've tried it, I wish you would.