diff for duplicates of <1471854614.3746.46.camel@perches.com> diff --git a/a/1.txt b/N1/1.txt index b0d8a3d..f125497 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -3,8 +3,8 @@ On Mon, 2016-08-22 at 01:00 -0700, Joe Perches wrote: > > On Sat 20-08-16 01:00:17, Joe Perches wrote: [] > > > static int proc_maps_open(struct inode *inode, struct file *file, -> > > const struct seq_operations *ops, int psize) -> > > { +> > > const struct seq_operations *ops, int psize) +> > > { > > > - struct proc_maps_private *priv = __seq_open_private(file, ops, psize); > > > + struct proc_maps_private *priv; > > > + struct mm_struct *mm; @@ -12,10 +12,10 @@ On Mon, 2016-08-22 at 01:00 -0700, Joe Perches wrote: > > > + mm = proc_mem_open(inode, PTRACE_MODE_READ); > > > + if (IS_ERR(mm)) > > > + return PTR_ERR(mm); -> > > +> > > > > > + priv = __seq_open_private_bufsize(file, ops, psize, -> > > + mm && mm->map_count ? -> > > + mm->map_count * 0x300 : PAGE_SIZE); +> > > + mm && mm->map_count ? +> > > + mm->map_count * 0x300 : PAGE_SIZE); > > NAK to this! > > > > Seriously, this just gives any random user access to user @@ -25,9 +25,3 @@ On Mon, 2016-08-22 at 01:00 -0700, Joe Perches wrote: And with further review and your comment above, I withdraw this patch. cheers, Joe - --- -To unsubscribe, send a message with 'unsubscribe linux-mm' in -the body to majordomo@kvack.org. For more info on Linux MM, -see: http://www.linux-mm.org/ . -Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> diff --git a/a/content_digest b/N1/content_digest index 354f1b5..9667254 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -17,8 +17,8 @@ "> > On Sat 20-08-16 01:00:17, Joe Perches wrote:\n" "[]\n" "> > > static int proc_maps_open(struct inode *inode, struct file *file,\n" - "> > > \t\t\tconst struct seq_operations *ops, int psize)\n" - "> > > {\n" + "> > > \302\240\t\t\tconst struct seq_operations *ops, int psize)\n" + "> > > \302\240{\n" "> > > -\tstruct proc_maps_private *priv = __seq_open_private(file, ops, psize);\n" "> > > +\tstruct proc_maps_private *priv;\n" "> > > +\tstruct mm_struct *mm;\n" @@ -26,10 +26,10 @@ "> > > +\tmm = proc_mem_open(inode, PTRACE_MODE_READ);\n" "> > > +\tif (IS_ERR(mm))\n" "> > > +\t\treturn PTR_ERR(mm);\n" - "> > > \n" + "> > > \302\240\n" "> > > +\tpriv = __seq_open_private_bufsize(file, ops, psize,\n" - "> > > +\t\t\t\t\t mm && mm->map_count ?\n" - "> > > +\t\t\t\t\t mm->map_count * 0x300 : PAGE_SIZE);\n" + "> > > +\t\t\t\t\t\302\240\302\240mm && mm->map_count ?\n" + "> > > +\t\t\t\t\t\302\240\302\240mm->map_count * 0x300 : PAGE_SIZE);\n" "> > NAK to this!\n" "> > \n" "> > Seriously, this just gives any random user access to user\n" @@ -38,12 +38,6 @@ "> I completely disagree here with your rationale here.\n" "\n" "And with further review and your comment above, I withdraw this patch.\n" - "cheers, Joe\n" - "\n" - "--\n" - "To unsubscribe, send a message with 'unsubscribe linux-mm' in\n" - "the body to majordomo@kvack.org. For more info on Linux MM,\n" - "see: http://www.linux-mm.org/ .\n" - "Don't email: <a href=mailto:\"dont@kvack.org\"> email@kvack.org </a>" + cheers, Joe -46a7b68cad6a3929b0df6c8157744e495ac950197be0cf239f30c4088136bdcb +c80e9fc1012d327712666a1a2851265eb43c917187d4bedd30dd9dfa0a677a86
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.