From: Hannes Reinecke <hare@suse.de>
To: Nic Bellinger <nab@linux-iscsi.org>
Cc: target-devel@vger.kernel.org, linux-scsi@vger.kernel.org,
Martin Wilck <martin.wilck@suse.com>,
Hannes Reinecke <hare@suse.de>
Subject: [PATCH 0/6] tcm_fc fixes
Date: Mon, 22 Aug 2016 10:54:05 +0200 [thread overview]
Message-ID: <1471856051-87398-1-git-send-email-hare@suse.de> (raw)
Hi Nic,
here's a set of patches and fixes I've found during debugging
FCoE over virtio.
The first two fix a race condition I've encountered during starting
and stopping initiators; they are similar to your prior patches,
but I still think they should be applied to avoid any race issues.
The next three are just minor cleanups, but the last one is
_absolutely_ crucial.
With the current code tcm_fc will behave _very_ odd if you're
running in a virtualized environment, as the xid allocator in libfc
will be thouroughly thrashed by sending frames on _other_ cpus than
those the originator frame got received on.
This causes frames to be delayed (by up to several minutes)
leading to I/O errors on the initiator side.
As usual, comments and reviews are welcome.
Hannes Reinecke (6):
target: fix hang in target_wait_for_sess_cmds()
target: fix potential race window in target_sess_cmd_list_waiting()
target/tcm_fc: print command pointer in debug message
target/tcm_fc: return detailed error in ft_sess_create()
target/tcm_fc: Update debugging statements to match libfc usage
target/tcm_fc: use CPU affinity for responses
drivers/target/target_core_transport.c | 28 ++++++++++++++---------
drivers/target/tcm_fc/tfc_cmd.c | 4 ++--
drivers/target/tcm_fc/tfc_sess.c | 42 +++++++++++++++++++++++-----------
3 files changed, 48 insertions(+), 26 deletions(-)
--
1.8.5.6
next reply other threads:[~2016-08-22 8:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-22 8:54 Hannes Reinecke [this message]
2016-08-22 8:54 ` [PATCH 1/6] target: fix hang in target_wait_for_sess_cmds() Hannes Reinecke
2016-10-21 8:00 ` Nicholas A. Bellinger
2016-08-22 8:54 ` [PATCH 2/6] target: fix potential race window in target_sess_cmd_list_waiting() Hannes Reinecke
2016-10-21 8:19 ` Nicholas A. Bellinger
2016-08-22 8:54 ` [PATCH 3/6] target/tcm_fc: print command pointer in debug message Hannes Reinecke
2016-08-22 8:54 ` [PATCH 4/6] target/tcm_fc: return detailed error in ft_sess_create() Hannes Reinecke
2016-08-22 8:54 ` [PATCH 5/6] target/tcm_fc: Update debugging statements to match libfc usage Hannes Reinecke
2016-08-23 18:07 ` Bart Van Assche
2016-08-22 8:54 ` [PATCH 6/6] target/tcm_fc: use CPU affinity for responses Hannes Reinecke
2016-10-21 7:46 ` [PATCH 0/6] tcm_fc fixes Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471856051-87398-1-git-send-email-hare@suse.de \
--to=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.wilck@suse.com \
--cc=nab@linux-iscsi.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.