From: Chin Liang See <clsee@altera.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/2] ARM: Move SYS_CACHELINE_SIZE over to Kconfig
Date: Mon, 22 Aug 2016 22:18:24 +0800 [thread overview]
Message-ID: <1471875504.2574.6.camel@altera.com> (raw)
In-Reply-To: <20160822133902.GC5342@bill-the-cat>
On Mon, 2016-08-22 at 09:39 -0400, Tom Rini wrote:
> On Mon, Aug 22, 2016 at 09:24:04PM +0800, Chin Liang See wrote:
> > Hi Tom,
> >
> > On Mon, 2016-08-22 at 08:22 -0400, Tom Rini wrote:
> > > This series moves the CONFIG_SYS_CACHELINE_SIZE. First, in
> > > nearly
> > > all
> > > cases we are mirroring the values used by the Linux Kernel here.
> > > Also,
> > > so long as (and in this case, it is true) we implement flushes in
> > > hunks
> > > that are no larger than the smallest implementation (and given
> > > that
> > > we
> > > mirror the Linux Kernel, again we are fine) it is OK to align
> > > higher.
> > > The biggest changes here are that we always use 64 bytes for
> > > CPU_V7
> > > even
> > > if for example the underlying core is only 32 bytes (this mirrors
> > > Linux). Second, we say ARM64 uses 64 bytes not 128 (as found in
> > > the
> > > Linux Kernel) as we do not need multi-platform support (to this
> > > degree)
> > > and only the Cavium ThunderX 88xx series has a use for such large
> > > alignment.
> > >
> > >
> > ...
> >
> > > arch/arm/Kconfig | 27
> >
> > > ...
> >
> > >
> > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> > > index aef901c3f448..e6d4a2043854 100644
> > > --- a/arch/arm/Kconfig
> > > +++ b/arch/arm/Kconfig
> > > @@ -7,6 +7,7 @@ config SYS_ARCH
> > >
> >
> > ...
> >
> > >
> > > config CPU_V7
> > > bool
> > > select HAS_VBAR
> > > select HAS_THUMB2
> > > + select SYS_CACHE_SHIFT_6
> > >
> >
> > CPU_V7 should use SYS_CACHE_SHIFT_5 which is 32 bytes cache lines.
>
> No, some V7 are 32 and some are 64, for example Cortex-A8.
>
Thanks Tom as you are right where its non standard across v7. In this
case, 64 will works for 32 case.
Acked-by: Chin Liang See <clsee@altera.com>
Thanks
Chin Liang
p/s: Reduced the mailing list as earlier email intention is to check
whether my earlier statement might not true in certain SoCs :)
next prev parent reply other threads:[~2016-08-22 14:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-22 12:22 [U-Boot] [PATCH v2 1/2] ARM: Move SYS_CACHELINE_SIZE over to Kconfig Tom Rini
2016-08-22 12:22 ` [U-Boot] [PATCH v2 2/2] arch/arm/Kconfig: Whitespace correction Tom Rini
2016-08-29 12:01 ` [U-Boot] [U-Boot, v2, " Tom Rini
2016-08-22 12:41 ` [U-Boot] [PATCH v2 1/2] ARM: Move SYS_CACHELINE_SIZE over to Kconfig Masahiro Yamada
2016-08-22 13:24 ` Chin Liang See
2016-08-22 13:39 ` Tom Rini
2016-08-22 14:18 ` Chin Liang See [this message]
2016-08-22 14:44 ` Ladislav Michl
2016-08-22 14:59 ` Tom Rini
2016-08-22 16:34 ` Stephen Warren
2016-08-22 16:55 ` Tom Rini
2016-08-24 15:20 ` Paul Kocialkowski
2016-08-29 12:01 ` [U-Boot] [U-Boot, v2, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471875504.2574.6.camel@altera.com \
--to=clsee@altera.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.