All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [dev-queue PATCH v2 2/3] i40e: Enable VF specific ethtool statistics via VF Port representor netdevs.
Date: Mon, 22 Aug 2016 16:13:32 -0700	[thread overview]
Message-ID: <1471907612.2325.27.camel@intel.com> (raw)
In-Reply-To: <57BB2980.50902@intel.com>

On Mon, 2016-08-22 at 09:34 -0700, Samudrala, Sridhar wrote:
> > So one change you need to this is to swap the rx_ and tx_ portion of
> > the strings.? You have to keep in mind this is a switch port
> > representation so the Rx and Tx values are swapped.? Every byte the VF
> > receives is actually a byte that we transmitted to the VF.
> >
> > You could probably also add a comment above this block stating that
> > the two were swapped and why.
> >
> Yes. As we are saying that this netdev represents the switch port?
> corresponding to the VF, it makes
> sense to swap the rx and tx stats.
> 
> Jeff,
> Should i submit a patch on top of this patchset as it is already in?
> dev-queue branch?
> Or resubmit the patchset as a v3 with this update.

Alex is correct, please re-submit the series with the desired changes to
this and any other patches, please. ?I can drop this series from my tree if
that helps you.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20160822/788f622d/attachment-0001.asc>

  parent reply	other threads:[~2016-08-22 23:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-18 17:54 [Intel-wired-lan] [dev-queue PATCH v2 0/3] Add VF Port representor support for SR-IOV VFs Sridhar Samudrala
2016-08-18 17:54 ` [Intel-wired-lan] [dev-queue PATCH v2 1/3] i40e: Introduce VF port representor/control netdevs Sridhar Samudrala
2016-08-19 16:00   ` Bowers, AndrewX
2016-08-18 17:55 ` [Intel-wired-lan] [dev-queue PATCH v2 2/3] i40e: Enable VF specific ethtool statistics via VF Port representor netdevs Sridhar Samudrala
2016-08-19 16:03   ` Bowers, AndrewX
2016-08-19 16:08   ` Alexander Duyck
2016-08-22 16:34     ` Samudrala, Sridhar
2016-08-22 17:04       ` Alexander Duyck
2016-08-22 23:13       ` Jeff Kirsher [this message]
2016-08-22 23:53         ` Samudrala, Sridhar
2016-08-18 17:55 ` [Intel-wired-lan] [dev-queue PATCH v2 3/3] i40e: Introduce devlink interface Sridhar Samudrala
2016-08-19 21:52   ` Bowers, AndrewX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1471907612.2325.27.camel@intel.com \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.