From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [RFC PATCH 0/2] Move PMDs out of lib directory Date: Mon, 11 May 2015 11:47:17 +0200 Message-ID: <1471925.FRZW63X2uB@xps13> References: <1431012951-6423-1-git-send-email-bruce.richardson@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Bruce Richardson Return-path: Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) by dpdk.org (Postfix) with ESMTP id 13B7AC410 for ; Mon, 11 May 2015 11:47:58 +0200 (CEST) Received: by wizk4 with SMTP id k4so98290388wiz.1 for ; Mon, 11 May 2015 02:47:57 -0700 (PDT) In-Reply-To: <1431012951-6423-1-git-send-email-bruce.richardson@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-05-07 16:35, Bruce Richardson: > The "lib" directory is getting very crowded, with both general libs and > poll mode drivers in it. This patch set proposes to move the PMDs out of the > lib folder and to put them in a separate "pmds" folder. This should help > with code browse-ability as the number of libs, and pmds increases. > > Comments or objections? When someone is looking for a driver implementation and check what is done in DPDK, it will be easier to open a directory named "drivers" rather than "pmds". I agree that they are not really libs as they are used as plugins. So they deserve a separate directory at the top level. Moreover, I suspect that the dataplane managed by DPDK can be extended to crypto and storage devices in the near future. So, I would suggest drivers/net drivers/crypto drivers/storage This kind of split could help to clearly define the responsibilities of some new git subtrees. Don't you think we could also remove the librte_pmd_ prefix for these new directories? Ultimately, I'd like to see the subdirectories for e1000, ixgbe and i40e renamed to base/.