From: Sinan Kaya <okaya@codeaurora.org>
To: dmaengine@vger.kernel.org, timur@codeaurora.org,
cov@codeaurora.org, vinod.koul@intel.com, jcm@redhat.com
Cc: agross@codeaurora.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Sinan Kaya <okaya@codeaurora.org>,
Dan Williams <dan.j.williams@intel.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Dave Jiang <dave.jiang@intel.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 2/3] dmaengine: qcom_hidma: report transfer errors with new interface
Date: Tue, 23 Aug 2016 00:48:10 -0400 [thread overview]
Message-ID: <1471927691-28827-3-git-send-email-okaya@codeaurora.org> (raw)
In-Reply-To: <1471927691-28827-1-git-send-email-okaya@codeaurora.org>
Pass the DMA errors to the client by passing a result argument. The HW only
supports a generic error when something goes wrong. That's why, using
DMA_TRANS_ABORTED all the time.
Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
---
drivers/dma/qcom/hidma.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/qcom/hidma.c b/drivers/dma/qcom/hidma.c
index b8493ba..ea24863 100644
--- a/drivers/dma/qcom/hidma.c
+++ b/drivers/dma/qcom/hidma.c
@@ -126,6 +126,7 @@ static void hidma_process_completed(struct hidma_chan *mchan)
list_for_each_entry_safe(mdesc, next, &list, node) {
enum dma_status llstat;
struct dmaengine_desc_callback cb;
+ struct dmaengine_result result;
desc = &mdesc->desc;
@@ -141,10 +142,15 @@ static void hidma_process_completed(struct hidma_chan *mchan)
spin_lock_irqsave(&mchan->lock, irqflags);
list_move(&mdesc->node, &mchan->free);
- spin_unlock_irqrestore(&mchan->lock, irqflags);
if (llstat == DMA_COMPLETE)
- dmaengine_desc_callback_invoke(&cb, NULL);
+ result.result = DMA_TRANS_NOERROR;
+ else
+ result.result = DMA_TRANS_ABORTED;
+
+ spin_unlock_irqrestore(&mchan->lock, irqflags);
+
+ dmaengine_desc_callback_invoke(&cb, &result);
}
}
--
1.8.2.1
WARNING: multiple messages have this Message-ID (diff)
From: okaya@codeaurora.org (Sinan Kaya)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3 2/3] dmaengine: qcom_hidma: report transfer errors with new interface
Date: Tue, 23 Aug 2016 00:48:10 -0400 [thread overview]
Message-ID: <1471927691-28827-3-git-send-email-okaya@codeaurora.org> (raw)
In-Reply-To: <1471927691-28827-1-git-send-email-okaya@codeaurora.org>
Pass the DMA errors to the client by passing a result argument. The HW only
supports a generic error when something goes wrong. That's why, using
DMA_TRANS_ABORTED all the time.
Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
---
drivers/dma/qcom/hidma.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/qcom/hidma.c b/drivers/dma/qcom/hidma.c
index b8493ba..ea24863 100644
--- a/drivers/dma/qcom/hidma.c
+++ b/drivers/dma/qcom/hidma.c
@@ -126,6 +126,7 @@ static void hidma_process_completed(struct hidma_chan *mchan)
list_for_each_entry_safe(mdesc, next, &list, node) {
enum dma_status llstat;
struct dmaengine_desc_callback cb;
+ struct dmaengine_result result;
desc = &mdesc->desc;
@@ -141,10 +142,15 @@ static void hidma_process_completed(struct hidma_chan *mchan)
spin_lock_irqsave(&mchan->lock, irqflags);
list_move(&mdesc->node, &mchan->free);
- spin_unlock_irqrestore(&mchan->lock, irqflags);
if (llstat == DMA_COMPLETE)
- dmaengine_desc_callback_invoke(&cb, NULL);
+ result.result = DMA_TRANS_NOERROR;
+ else
+ result.result = DMA_TRANS_ABORTED;
+
+ spin_unlock_irqrestore(&mchan->lock, irqflags);
+
+ dmaengine_desc_callback_invoke(&cb, &result);
}
}
--
1.8.2.1
next prev parent reply other threads:[~2016-08-23 4:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-23 4:48 [PATCH V3 0/3] dmaengine: qcom_hidma: add error reporting Sinan Kaya
2016-08-23 4:48 ` Sinan Kaya
2016-08-23 4:48 ` [PATCH V3 1/3] dmaengine: qcom_hidma: release the descriptor before the callback Sinan Kaya
2016-08-23 4:48 ` Sinan Kaya
2016-08-23 4:48 ` Sinan Kaya [this message]
2016-08-23 4:48 ` [PATCH V3 2/3] dmaengine: qcom_hidma: report transfer errors with new interface Sinan Kaya
2016-08-23 4:48 ` [PATCH V3 3/3] dmaengine: qcom_hidma: add error reporting for tx_status Sinan Kaya
2016-08-23 4:48 ` Sinan Kaya
2016-08-30 17:04 ` Vinod Koul
2016-08-30 17:04 ` Vinod Koul
2016-08-30 17:37 ` Sinan Kaya
2016-08-30 17:37 ` Sinan Kaya
2016-08-30 17:51 ` Sinan Kaya
2016-08-30 17:51 ` Sinan Kaya
2016-08-31 4:21 ` Vinod Koul
2016-08-31 4:21 ` Vinod Koul
2016-08-29 15:30 ` [PATCH V3 0/3] dmaengine: qcom_hidma: add error reporting Sinan Kaya
2016-08-29 15:30 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471927691-28827-3-git-send-email-okaya@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=agross@codeaurora.org \
--cc=andy.shevchenko@gmail.com \
--cc=cov@codeaurora.org \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=jcm@redhat.com \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=timur@codeaurora.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.