All of lore.kernel.org
 help / color / mirror / Atom feed
From: james_p_freyensee@linux.intel.com (J Freyensee)
Subject: [PATCH] nvme-cli/fabrics: Added hostnqn parameter to connect command
Date: Tue, 23 Aug 2016 16:42:04 -0700	[thread overview]
Message-ID: <1471995724.23443.32.camel@linux.intel.com> (raw)
In-Reply-To: <1471946706-18036-1-git-send-email-roysh@mellanox.com>

On Tue, 2016-08-23@13:05 +0300, Roy Shterman wrote:
> Added user-defined 'hostnqn' to 'connect' command
> so users could use the allowed_hosts attribute on the target and
> still
> connect to target with nvme-cli tool.
> 
> usage examples:
> 	nvme discover -t <TRANSPORT> -a <ADDRESS> -s <SERVICE_ID> -q
> <USER-DEFINED_HOSTNQN>

I believe the example needs to be changed from 'discover' to 'connect'
;-)

Jay

> 
> Signed-off-by: Roy Shterman <roysh at mellanox.com>
> ---
> ?fabrics.c |????2 ++
> ?1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/fabrics.c b/fabrics.c
> index 26c4e22..942e987 100644
> --- a/fabrics.c
> +++ b/fabrics.c
> @@ -711,6 +711,8 @@ int connect(const char *desc, int argc, char
> **argv)
> ?			"transport address" },
> ?		{"trsvcid", 's', "LIST", CFG_STRING, &cfg.trsvcid,
> required_argument,
> ?			"transport service id (e.g. IP port)" },
> +		{"hostnqn", 'q', "LIST", CFG_STRING, &cfg.hostnqn,
> required_argument,
> +			"user-defined hostnqn" },
> ?		{0},
> ?	};
> ?

  reply	other threads:[~2016-08-23 23:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-23 10:05 [PATCH] nvme-cli/fabrics: Added hostnqn parameter to connect command Roy Shterman
2016-08-23 23:42 ` J Freyensee [this message]
2016-08-24  6:48   ` Roy Shterman
  -- strict thread matches above, loose matches on Subject: below --
2016-08-24  6:53 Roy Shterman
2016-08-24 14:58 ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1471995724.23443.32.camel@linux.intel.com \
    --to=james_p_freyensee@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.