From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53725) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bcgZj-0002JG-8u for qemu-devel@nongnu.org; Wed, 24 Aug 2016 18:23:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bcgZi-00068h-2y for qemu-devel@nongnu.org; Wed, 24 Aug 2016 18:23:11 -0400 Message-ID: <1472077377.2246.41.camel@kernel.crashing.org> From: Benjamin Herrenschmidt Date: Thu, 25 Aug 2016 08:22:57 +1000 In-Reply-To: <4a78a3a5-91ba-b3bd-a59c-d1ebf9f1470b@reactos.org> References: <4a78a3a5-91ba-b3bd-a59c-d1ebf9f1470b@reactos.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] ppc: regression in 2.7.0-rc3 on rfi/rfid/hrfi instructions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Herv=E9?= Poussineau , qemu-devel , "qemu-ppc@nongnu.org" On Wed, 2016-08-24 at 20:39 +0200, Herv=C3=A9 Poussineau wrote: > Hi, >=20 > Following patch regresses Linux boot on PReP machine: Where do I find the source for that kernel ? Cheers, Ben. > commit a2e71b28e832346409efc795ecd1f0a2bcb705a3 > Author: Benjamin Herrenschmidt > Date:=C2=A0=C2=A0=C2=A0Tue Jun 21 23:48:46 2016 +0200 >=20 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0ppc: Fix rfi/rfid/hrfi/... emulation >=20 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0This reworks emulation of the various "rf= i" variants. I removed > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0some masking bits that I couldn't make se= nse of, the only bit > that > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0I am aware we should mask here is POW, th= e CPU's MSR mask should > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0take care of the rest. >=20 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0This also fixes some problems when runnin= g 32-bit userspace > under > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0a 64-bit kernel. >=20 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0This patch broke 32bit OpenBIOS when run = under a 970 cpu. A fix > was > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0proposed here : >=20 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0https://www.coreb= oot.org/pipermail/openbios/2016-June/009452 > .html >=20 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Signed-off-by: Benjamin Herrenschmidt > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Reviewed-by: David Gibson > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0[clg: updated the commit log with the ref= erence of the openbios > fix ] > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Signed-off-by: C=C3=A9dric Le Goater > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0[dwg: Remove hunk which disabled rfi on 6= 4-bit CPUS.=C2=A0=C2=A0The change > was > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0correct, but we need to fix OpenBIO= S before applying it] > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Signed-off-by: David Gibson >=20 > Test case: > - Download: http://www.juneau-lug.org/zImage.initrd.sandalfoot > - Run: qemu-system-ppc -M prep -kernel zImage.initrd.sandalfoot >=20 > Firmware starts, loads kernel, but seems to error out just after PS/2 > detection. >=20 > Reverting the commit and fixing the conflict makes it work again, up > to shell. >=20 > Herv=C3=A9