From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752054AbcHZSI6 (ORCPT ); Fri, 26 Aug 2016 14:08:58 -0400 Received: from smtprelay0041.hostedemail.com ([216.40.44.41]:42102 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752026AbcHZSIz (ORCPT ); Fri, 26 Aug 2016 14:08:55 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:960:968:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1537:1566:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2693:2828:3138:3139:3140:3141:3142:3622:3865:3868:3873:4321:5007:8957:10004:10400:10848:11232:11658:11914:12043:12438:12740:13069:13311:13357:13439:14659:14721:21080:21451:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: sheep34_7c12fca27742e X-Filterd-Recvd-Size: 1196 Message-ID: <1472234851.4914.51.camel@perches.com> Subject: Re: [PATCH v2] Staging: wlan-ng: replace switch-case statements with macro From: Joe Perches To: Claudiu Beznea , gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Fri, 26 Aug 2016 11:07:31 -0700 In-Reply-To: <1472234297-7777-1-git-send-email-claudiu.beznea@gmail.com> References: <1472234297-7777-1-git-send-email-claudiu.beznea@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-08-26 at 20:58 +0300, Claudiu Beznea wrote: > This patch removes multiple switch-case statements > with a new macro. The macro will generate the > corresponding bit mask based on the key index > received as input. Can you go a little farther and remove the #define DIDmib_dot11smt_dot11WEPDefaultKeysTable_dot11WEPDefaultKey<#> and uses too?