From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: Wei Yongjun <weiyj.lk@gmail.com>, Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH -next] HID: intel_ish-hid: Use kzalloc instead of kmalloc/memset
Date: Fri, 26 Aug 2016 11:52:20 -0700 [thread overview]
Message-ID: <1472237540.2694.1.camel@linux.intel.com> (raw)
In-Reply-To: <1471793450-24245-1-git-send-email-weiyj.lk@gmail.com>
On Sun, 2016-08-21 at 15:30 +0000, Wei Yongjun wrote:
> Use kzalloc rather than kmalloc followed by memset with 0.
>
> Generated by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
>
> Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> drivers/hid/intel-ish-hid/ishtp/client-buffers.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/hid/intel-ish-hid/ishtp/client-buffers.c
> b/drivers/hid/intel-ish-hid/ishtp/client-buffers.c
> index 3f5ce5e..b9b917d 100644
> --- a/drivers/hid/intel-ish-hid/ishtp/client-buffers.c
> +++ b/drivers/hid/intel-ish-hid/ishtp/client-buffers.c
> @@ -73,11 +73,10 @@ int ishtp_cl_alloc_tx_ring(struct ishtp_cl *cl)
> for (j = 0; j < cl->tx_ring_size; ++j) {
> struct ishtp_cl_tx_ring *tx_buf;
>
> - tx_buf = kmalloc(sizeof(struct ishtp_cl_tx_ring),
> GFP_KERNEL);
> + tx_buf = kzalloc(sizeof(struct ishtp_cl_tx_ring),
> GFP_KERNEL);
> if (!tx_buf)
> goto out;
>
> - memset(tx_buf, 0, sizeof(struct ishtp_cl_tx_ring));
> tx_buf->send_buf.data = kmalloc(len, GFP_KERNEL);
> if (!tx_buf->send_buf.data) {
> kfree(tx_buf);
>
>
>
prev parent reply other threads:[~2016-08-26 19:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-21 15:30 [PATCH -next] HID: intel_ish-hid: Use kzalloc instead of kmalloc/memset Wei Yongjun
2016-08-26 18:52 ` Srinivas Pandruvada [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472237540.2694.1.camel@linux.intel.com \
--to=srinivas.pandruvada@linux.intel.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=weiyj.lk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.