From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: Wei Yongjun <weiyj.lk@gmail.com>, Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Wei Yongjun <weiyongjun1@huawei.com>, linux-input@vger.kernel.org
Subject: Re: [PATCH -next] HID: intel-ish-hid: use module_pci_driver to simplify the code
Date: Fri, 26 Aug 2016 12:00:24 -0700 [thread overview]
Message-ID: <1472238024.2694.4.camel@linux.intel.com> (raw)
In-Reply-To: <1471793316-23880-1-git-send-email-weiyj.lk@gmail.com>
On Sun, 2016-08-21 at 15:28 +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Use the module_pci_driver() macro to make the code simpler
> by eliminating module_init and module_exit calls.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> drivers/hid/intel-ish-hid/ipc/pci-ish.c | 13 +------------
> 1 file changed, 1 insertion(+), 12 deletions(-)
>
> diff --git a/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> index b14d6f4..42f0bee 100644
> --- a/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> +++ b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> @@ -311,18 +311,7 @@ static struct pci_driver ish_driver = {
> .driver.pm = ISHTP_ISH_PM_OPS,
> };
>
> -static int __init ish_driver_init(void)
> -{
> - return pci_register_driver(&ish_driver);
> -}
> -
> -static void __exit ish_driver_exit(void)
> -{
> - pci_unregister_driver(&ish_driver);
> -}
> -
> -module_init(ish_driver_init);
> -module_exit(ish_driver_exit);
> +module_pci_driver(ish_driver);
>
> /* Original author */
> MODULE_AUTHOR("Daniel Drubin <daniel.drubin@intel.com>");
>
>
>
prev parent reply other threads:[~2016-08-26 19:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-21 15:28 [PATCH -next] HID: intel-ish-hid: use module_pci_driver to simplify the code Wei Yongjun
2016-08-26 19:00 ` Srinivas Pandruvada [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472238024.2694.4.camel@linux.intel.com \
--to=srinivas.pandruvada@linux.intel.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=weiyj.lk@gmail.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.