From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Cédric Le Goater" <clg@kaod.org>,
"David Gibson" <david@gibson.dropbear.id.au>
Cc: qemu-ppc@nongnu.org, Alexander Graf <agraf@suse.de>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/3] ppc/pnv: add skeleton PowerNV platform
Date: Sat, 27 Aug 2016 08:48:10 +1000 [thread overview]
Message-ID: <1472251690.2889.69.camel@kernel.crashing.org> (raw)
In-Reply-To: <0bfc38b7-e4a6-17a8-1ab2-485e45b09eda@kaod.org>
On Fri, 2016-08-26 at 16:47 +0200, Cédric Le Goater wrote:
> >> +static void powernv_machine_class_init(ObjectClass *oc, void
> *data)
> >> +{
> >> + MachineClass *mc = MACHINE_CLASS(oc);
> >> +
> >> + mc->init = ppc_powernv_init;
> >> + mc->reset = ppc_powernv_reset;
> >> + mc->block_default_type = IF_IDE;
> >
> > IDE? Really?
>
> nah :) It's SCSI again now.
>
> I was trying to reconcile all the little hunks in the different
> patches of Ben. IF_IDE was introduced at the end of the patchset.
> I suppose that adding a ISA bus to PowerNV had some influence :)
It's meant to be IF_IDE, the default interface is AHCI.
Cheers,
Ben.
next prev parent reply other threads:[~2016-08-26 22:48 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-05 9:15 [Qemu-devel] [PATCH 0/3] ppc/pnc: add a minimal platform Cédric Le Goater
2016-08-05 9:15 ` [Qemu-devel] [PATCH 1/3] ppc/pnv: add skeleton PowerNV platform Cédric Le Goater
2016-08-16 2:12 ` David Gibson
2016-08-26 14:47 ` Cédric Le Goater
2016-08-26 22:48 ` Benjamin Herrenschmidt [this message]
2016-08-29 14:17 ` David Gibson
2016-08-29 14:16 ` David Gibson
2016-08-05 9:15 ` [Qemu-devel] [PATCH 2/3] ppc/pnv: add a PnvChip object Cédric Le Goater
2016-08-05 9:44 ` Benjamin Herrenschmidt
2016-08-05 16:48 ` Cédric Le Goater
2016-08-05 22:43 ` Benjamin Herrenschmidt
2016-08-16 2:18 ` David Gibson
2016-08-16 2:21 ` David Gibson
2016-08-26 16:31 ` Cédric Le Goater
2016-08-05 9:15 ` [Qemu-devel] [PATCH 3/3] ppc/pnv: add a PowerNVCPUCore object Cédric Le Goater
2016-08-16 2:39 ` David Gibson
2016-08-16 5:02 ` Benjamin Herrenschmidt
2016-08-26 17:55 ` Cédric Le Goater
2016-08-26 17:49 ` Cédric Le Goater
2016-08-29 14:30 ` David Gibson
2016-08-30 6:15 ` Benjamin Herrenschmidt
2016-08-30 6:28 ` David Gibson
2016-08-31 1:06 ` Benjamin Herrenschmidt
2016-08-30 7:23 ` Cédric Le Goater
2016-09-05 1:45 ` David Gibson
2016-09-06 7:45 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472251690.2889.69.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=agraf@suse.de \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.