From: Joe Perches <joe@perches.com>
To: Nicolas Iooss <nicolas.iooss_linux@m4x.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
alsa-devel@alsa-project.org, Julia Lawall <julia.lawall@lip6.fr>,
Dan Capenter <error27@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Misuses of ** ? (was Re: [PATCH 1/1] ASoC: Intel: Atom: add a missing star in a memcpy call)
Date: Sun, 28 Aug 2016 10:50:36 -0700 [thread overview]
Message-ID: <1472406636.26978.95.camel@perches.com> (raw)
In-Reply-To: <20160828173945.27721-1-nicolas.iooss_linux@m4x.org>
On Sun, 2016-08-28 at 19:39 +0200, Nicolas Iooss wrote:
> In sst_prepare_and_post_msg(), when a response is received in "block",
> the following code gets executed:
>
> *data = kzalloc(block->size, GFP_KERNEL);
> memcpy(data, (void *) block->data, block->size);
Yuck, thanks.
Julia, Dan, could cocci or smatch help find any other
similar misuses here?
next prev parent reply other threads:[~2016-08-28 17:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-28 17:39 [PATCH 1/1] ASoC: Intel: Atom: add a missing star in a memcpy call Nicolas Iooss
2016-08-28 17:50 ` Joe Perches [this message]
2016-08-28 18:52 ` Misuses of ** ? (was Re: [PATCH 1/1] ASoC: Intel: Atom: add a missing star in a memcpy call) Nicolas Iooss
2016-08-28 19:38 ` Julia Lawall
2016-08-28 20:34 ` Joe Perches
2016-08-28 21:40 ` Julia Lawall
2016-08-28 21:54 ` Joe Perches
2016-08-28 18:17 ` [PATCH 1/1] ASoC: Intel: Atom: add a missing star in a memcpy call Joe Perches
2016-08-28 18:31 ` Nicolas Iooss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472406636.26978.95.camel@perches.com \
--to=joe@perches.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=error27@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.iooss_linux@m4x.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.