From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: Misuses of ** ? (was Re: [PATCH 1/1] ASoC: Intel: Atom: add a missing star in a memcpy call) Date: Sun, 28 Aug 2016 13:34:13 -0700 Message-ID: <1472416453.26978.115.camel@perches.com> References: <20160828173945.27721-1-nicolas.iooss_linux@m4x.org> <1472406636.26978.95.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Julia Lawall , Nicolas Iooss Cc: alsa-devel@alsa-project.org, Dan Capenter , Liam Girdwood , Mark Brown , linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org On Sun, 2016-08-28 at 21:38 +0200, Julia Lawall wrote: > On Sun, 28 Aug 2016, Nicolas Iooss wrote: > > On 28/08/16 19:50, Joe Perches wrote: > > > On Sun, 2016-08-28 at 19:39 +0200, Nicolas Iooss wrote: > > >> In sst_prepare_and_post_msg(), when a response is received in "block", > > >> the following code gets executed: > > >> > > >>     *data = kzalloc(block->size, GFP_KERNEL); > > >>     memcpy(data, (void *) block->data, block->size); > > > > > > Yuck, thanks. > > > > > > Julia, Dan, could cocci or smatch help find any other > > > similar misuses here? [] > I tried the following semantic patch, that is quite general, and the fixed > issue was the only report. > > @@ > expression x,y,sz; > identifier f,g; > @@ > > * *x = f(sz,...); >   ... > * g(x,y,sz); Hi Julia, This would find exactly the same form, but I think the question is are there assignments of a **pp that should have been *pp Something like: @@ type P; P **pp; @@ * pp = \|\|(..., sizeof(P), ...)