diff for duplicates of <1472519215.5512.30.camel@perches.com> diff --git a/a/1.txt b/N1/1.txt index eab6636..c0ea12c 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -12,9 +12,9 @@ One completely trivial note: > diff --git a/mm/slab.c b/mm/slab.c [] > @@ -1394,24 +1395,27 @@ slab_out_of_memory(struct kmem_cache *cachep, gfp_t gfpflags, int nodeid) -> for_each_kmem_cache_node(cachep, node, n) { -> unsigned long active_objs = 0, num_objs = 0, free_objects = 0; -> unsigned long active_slabs = 0, num_slabs = 0; +> for_each_kmem_cache_node(cachep, node, n) { +> unsigned long active_objs = 0, num_objs = 0, free_objects = 0; +> unsigned long active_slabs = 0, num_slabs = 0; > + unsigned long num_slabs_partial = 0, num_slabs_free = 0; > + unsigned long num_slabs_full; [] @@ -24,25 +24,19 @@ One completely trivial note: vs > @@ -4111,6 +4119,8 @@ void get_slabinfo(struct kmem_cache *cachep, struct slabinfo *sinfo) -> unsigned long num_objs; -> unsigned long active_slabs = 0; -> unsigned long num_slabs, free_objects = 0, shared_avail = 0; +> unsigned long num_objs; +> unsigned long active_slabs = 0; +> unsigned long num_slabs, free_objects = 0, shared_avail = 0; > + unsigned long num_slabs_partial = 0, num_slabs_free = 0; > + unsigned long num_slabs_full = 0; [] > + num_slabs_full = num_slabs - (num_slabs_partial + num_slabs_free); It seems odd to have different initialization styles -for num_slabs_full. It seems the second one doesn't +for num_slabs_full. It seems the second one doesn't need to be initialized. It'd also be nicer I think if the two declarations blocks had more similar layouts. -Maybe in a follow-on patch. Or not. Your choice. - --- -To unsubscribe, send a message with 'unsubscribe linux-mm' in -the body to majordomo@kvack.org. For more info on Linux MM, -see: http://www.linux-mm.org/ . -Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> +Maybe in a follow-on patch. Or not. Your choice. diff --git a/a/content_digest b/N1/content_digest index c6fdacc..52dc9ef 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -27,9 +27,9 @@ "> diff --git a/mm/slab.c b/mm/slab.c\n" "[]\n" "> @@ -1394,24 +1395,27 @@ slab_out_of_memory(struct kmem_cache *cachep, gfp_t gfpflags, int nodeid)\n" - "> \tfor_each_kmem_cache_node(cachep, node, n) {\n" - "> \t\tunsigned long active_objs = 0, num_objs = 0, free_objects = 0;\n" - "> \t\tunsigned long active_slabs = 0, num_slabs = 0;\n" + "> \302\240\tfor_each_kmem_cache_node(cachep, node, n) {\n" + "> \302\240\t\tunsigned long active_objs = 0, num_objs = 0, free_objects = 0;\n" + "> \302\240\t\tunsigned long active_slabs = 0, num_slabs = 0;\n" "> +\t\tunsigned long num_slabs_partial = 0, num_slabs_free = 0;\n" "> +\t\tunsigned long num_slabs_full;\n" "[]\n" @@ -39,27 +39,21 @@ "vs\n" "\n" "> @@ -4111,6 +4119,8 @@ void get_slabinfo(struct kmem_cache *cachep, struct slabinfo *sinfo)\n" - "> \tunsigned long num_objs;\n" - "> \tunsigned long active_slabs = 0;\n" - "> \tunsigned long num_slabs, free_objects = 0, shared_avail = 0;\n" + "> \302\240\tunsigned long num_objs;\n" + "> \302\240\tunsigned long active_slabs = 0;\n" + "> \302\240\tunsigned long num_slabs, free_objects = 0, shared_avail = 0;\n" "> +\tunsigned long num_slabs_partial = 0, num_slabs_free = 0;\n" "> +\tunsigned long num_slabs_full = 0;\n" "[]\n" "> +\tnum_slabs_full = num_slabs - (num_slabs_partial + num_slabs_free);\n" "\n" "It seems odd to have different initialization styles\n" - "for num_slabs_full. It seems the second one doesn't\n" + "for num_slabs_full. \302\240It seems the second one doesn't\n" "need to be initialized.\n" "\n" "It'd also be nicer I think if the two declarations\n" "blocks had more similar layouts.\n" "\n" - "Maybe in a follow-on patch. Or not. Your choice.\n" - "\n" - "--\n" - "To unsubscribe, send a message with 'unsubscribe linux-mm' in\n" - "the body to majordomo@kvack.org. For more info on Linux MM,\n" - "see: http://www.linux-mm.org/ .\n" - "Don't email: <a href=mailto:\"dont@kvack.org\"> email@kvack.org </a>" + "Maybe in a follow-on patch. \302\240Or not. \302\240Your choice." -6ace5e2e30b6b953471d881c1cf85d89b2209ea8813012be7832a43096ce54f6 +ccfa7e98b77c67a304e1a7bf86a1c01889e916a24782cfa8562a14d748d90698
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.