From: Joe Perches <joe@perches.com>
To: Moshe Green <mgmoshes@gmail.com>,
sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
gregkh@linuxfoundation.org
Cc: linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/9] staging: sm750fb: fix block comment style issues in ddk750_chip.c
Date: Tue, 30 Aug 2016 19:19:23 +0000 [thread overview]
Message-ID: <1472584763.5512.119.camel@perches.com> (raw)
In-Reply-To: <ad80e695e9730861466d5960359b06af27ca7c30.1472583825.git.mgmoshes@gmail.com>
On Tue, 2016-08-30 at 22:05 +0300, Moshe Green wrote:
> Fix block comment * prefix and trailing */ warnings found
> by the checkpatch.pl tool in ddk750_chip.c.
[]
> diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
[]
> @@ -320,8 +320,10 @@ unsigned int calcPllValue(unsigned int request_orig, pll_value_t *pll)
> int max_d = 6;
>
> if (getChipType() = SM750LE) {
> - /* SM750LE don't have prgrammable PLL and M/N values to work on.
> - Just return the requested clock. */
> + /* SM750LE don't have
> + * prgrammable PLL and M/N values to work on
Might as well fix the programmable typo too.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Moshe Green <mgmoshes@gmail.com>,
sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
gregkh@linuxfoundation.org
Cc: linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/9] staging: sm750fb: fix block comment style issues in ddk750_chip.c
Date: Tue, 30 Aug 2016 12:19:23 -0700 [thread overview]
Message-ID: <1472584763.5512.119.camel@perches.com> (raw)
In-Reply-To: <ad80e695e9730861466d5960359b06af27ca7c30.1472583825.git.mgmoshes@gmail.com>
On Tue, 2016-08-30 at 22:05 +0300, Moshe Green wrote:
> Fix block comment * prefix and trailing */ warnings found
> by the checkpatch.pl tool in ddk750_chip.c.
[]
> diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
[]
> @@ -320,8 +320,10 @@ unsigned int calcPllValue(unsigned int request_orig, pll_value_t *pll)
> int max_d = 6;
>
> if (getChipType() == SM750LE) {
> - /* SM750LE don't have prgrammable PLL and M/N values to work on.
> - Just return the requested clock. */
> + /* SM750LE don't have
> + * prgrammable PLL and M/N values to work on
Might as well fix the programmable typo too.
next prev parent reply other threads:[~2016-08-30 19:19 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 19:04 [PATCH 1/9] staging: sm750fb: fix line length coding style issue in ddk750_chip.c Moshe Green
2016-08-30 19:04 ` Moshe Green
2016-08-30 19:04 ` [PATCH 2/9] " Moshe Green
2016-08-30 19:04 ` Moshe Green
2016-08-30 19:04 ` [PATCH 3/9] staging: sm750fb: fix coding style issues " Moshe Green
2016-08-30 19:04 ` Moshe Green
2016-08-30 19:04 ` [PATCH 4/9] " Moshe Green
2016-08-30 19:04 ` Moshe Green
2016-08-30 19:05 ` [PATCH 5/9] " Moshe Green
2016-08-30 19:05 ` Moshe Green
2016-08-30 19:05 ` [PATCH 6/9] staging: sm750fb: fix line length coding style issue " Moshe Green
2016-08-30 19:05 ` Moshe Green
2016-08-30 19:05 ` [PATCH 7/9] staging: sm750fb: fix block comment style issues " Moshe Green
2016-08-30 19:05 ` Moshe Green
2016-08-30 19:19 ` Joe Perches [this message]
2016-08-30 19:19 ` Joe Perches
2016-08-30 19:42 ` moshe green
2016-08-30 19:42 ` moshe green
2016-08-30 19:05 ` [PATCH 8/9] staging: sm750fb: fix line length coding style issue " Moshe Green
2016-08-30 19:05 ` Moshe Green
2016-08-30 19:06 ` [PATCH 9/9] " Moshe Green
2016-08-30 19:06 ` Moshe Green
2016-09-01 16:04 ` [PATCH 1/9] " Greg KH
2016-09-01 16:04 ` Greg KH
2016-09-02 8:28 ` moshe green
2016-09-02 8:28 ` moshe green
2016-09-02 11:35 ` Greg KH
2016-09-02 11:35 ` Greg KH
2016-09-03 19:57 ` Moshe Green
2016-09-03 19:57 ` Moshe Green
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472584763.5512.119.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgmoshes@gmail.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.