From: Greg <gvrose8192@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: netdev@vger.kernel.org, Greg Rose <grose@lightfleet.com>
Subject: Re: [PATCH] net/ethernet: Use ether_addr_copy rather than memcpy
Date: Wed, 31 Aug 2016 09:42:23 -0700 [thread overview]
Message-ID: <1472661743.3889.1.camel@gmail.com> (raw)
In-Reply-To: <1472661685.4176.10.camel@perches.com>
On Wed, 2016-08-31 at 09:41 -0700, Joe Perches wrote:
> On Wed, 2016-08-31 at 09:32 -0700, Greg Rose wrote:
> > I'm not sure why this hasn't been done before because it seems obvious,
> > so maybe there is some reason that memcpy is used instead of
> > ether_addr_copy in this code. But let's try this anyway.
> >
> > Change memcpy to ether_addr_copy.
>
> I looked at this once and gave up given the need to verify all
> the possible callers that require an __aligned(2) source address.
>
Ha, I figured there must be some reason for it. OK, patch withdrawn.
Thanks!
next prev parent reply other threads:[~2016-08-31 16:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-31 16:32 [PATCH] net/ethernet: Use ether_addr_copy rather than memcpy Greg Rose
2016-08-31 16:41 ` Joe Perches
2016-08-31 16:42 ` Greg [this message]
2016-08-31 18:32 ` Eric Dumazet
2016-08-31 18:34 ` Greg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472661743.3889.1.camel@gmail.com \
--to=gvrose8192@gmail.com \
--cc=grose@lightfleet.com \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.