From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Dave Gordon <david.s.gordon@intel.com>, intel-gfx@lists.freedesktop.org
Cc: Mika Kuoppala <mika.kuoppala@intel.com>
Subject: Re: [PATCH] Another flavour of for_each_engine_masked()
Date: Thu, 01 Sep 2016 17:36:28 +0300 [thread overview]
Message-ID: <1472740588.8006.4.camel@linux.intel.com> (raw)
In-Reply-To: <1472739464-19399-1-git-send-email-david.s.gordon@intel.com>
On to, 2016-09-01 at 15:17 +0100, Dave Gordon wrote:
> This macro was recently updated to skip testing for non-existent or
> uninteresting engines by using ffs() to directly find the next engine of
> interest. However, it required the introduction of a caller-provided
> temporary variable, which some people regard as inelegant. So, this
> patch provides another variant, which still uses the fast-skip mechanism
> but without requiring the temporary, for the cost of a slight increase
> in code size (~20 bytes per callsite).
I did the same kind of modification, it got Nacked.
I'd myself vote for loosing the temporary for 20 bytes too.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-09-01 14:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-27 7:54 [CI 1/2] drm/i915: Tidy reporting busy status during i915_gem_retire_requests() Chris Wilson
2016-08-27 7:54 ` [CI 2/2] drm/i915: Make for_each_engine_masked() more compact and quicker Chris Wilson
2016-09-01 14:17 ` [PATCH] Another flavour of for_each_engine_masked() Dave Gordon
2016-09-01 14:36 ` Joonas Lahtinen [this message]
2016-09-01 14:48 ` Chris Wilson
2016-09-01 16:59 ` Dave Gordon
2016-08-27 8:21 ` ✗ Fi.CI.BAT: warning for series starting with [CI,1/2] drm/i915: Tidy reporting busy status during i915_gem_retire_requests() Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472740588.8006.4.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=david.s.gordon@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.