From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: Ath10k probe response error related to mac80211 commit.
Date: Thu, 01 Sep 2016 20:01:51 +0200 [thread overview]
Message-ID: <1472752911.9608.11.camel@sipsolutions.net> (raw)
In-Reply-To: <cf9852df-6d14-baf6-af0a-9cc78c448fde@candelatech.com> (sfid-20160901_182956_271900_20A93AB4)
> If someone has any idea of why this patch might trigger it, please
> let me know.
> I'll keep digging in the meantime...
>
> Revert "mac80211: don't advertise NL80211_FEATURE_FULL_AP_CLIENT_STATE"
>
With a sufficiently recent hostapd/wpa_supplicant, the patch will cause
a station entry to be added to the firmware before sending the
authentication frame.
Why, of all frames, probe response frames should be corrupted I don't
know - I could imagine auth/assoc replies being treated differently
since they are now with a station entry rather than without.
> This only breaks AP mode (station mode works fine).
It also has no impact on anything but AP mode, as even indicated by the
name of the flag :)
Anyway, I was pretty sure this was safe and it does help other drivers
to have the full state, but I guess you can make the driver opt out of
the flag again (just unset it before register_hw).
johannes
next prev parent reply other threads:[~2016-09-01 22:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-01 16:29 Ath10k probe response error related to mac80211 commit Ben Greear
2016-09-01 18:01 ` Johannes Berg [this message]
2016-09-01 18:23 ` Ben Greear
2016-09-01 18:53 ` Johannes Berg
2016-09-01 19:00 ` Ben Greear
2016-09-01 20:52 ` Ben Greear
2016-09-01 20:52 ` Ben Greear
2016-09-02 12:09 ` Michal Kazior
2016-09-02 12:09 ` Michal Kazior
2016-09-02 13:30 ` Ben Greear
2016-09-02 13:30 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472752911.9608.11.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.