From: Joe Perches <joe@perches.com>
To: Woojung.Huh@microchip.com, davem@davemloft.net
Cc: steve.glendinning@shawell.net, netdev@vger.kernel.org,
UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net-next 2/3] smsc95xx: Add register define
Date: Fri, 02 Sep 2016 13:40:01 -0700 [thread overview]
Message-ID: <1472848801.22931.7.camel@perches.com> (raw)
In-Reply-To: <9235D6609DB808459E95D78E17F2E43D409100A1@CHN-SV-EXMX02.mchp-main.com>
On Fri, 2016-09-02 at 20:34 +0000, Woojung.Huh@microchip.com wrote:
> From: Woojung Huh <woojung.huh@microchip.com>
>
> Add STRAP_STATUS defines.
[]
> diff --git a/drivers/net/usb/smsc95xx.h b/drivers/net/usb/smsc95xx.h
[]
> @@ -144,6 +144,14 @@
>
> #define BURST_CAP (0x38)
>
> +#define STRAP_STATUS (0x3C)
> +#define STRAP_STATUS_PWR_SEL_ (0x00000020)
> +#define STRAP_STATUS_AMDIX_EN_ (0x00000010)
> +#define STRAP_STATUS_PORT_SWAP_ (0x00000008)
> +#define STRAP_STATUS_EEP_SIZE_ (0x00000004)
> +#define STRAP_STATUS_RMT_WKP_ (0x00000002)
> +#define STRAP_STATUS_EEP_DISABLE_ (0x00000001)
Using BIT would be more common.
Ending the #defines with an underscore is just odd
and unappealing.
next prev parent reply other threads:[~2016-09-02 20:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 20:34 [PATCH net-next 2/3] smsc95xx: Add register define Woojung.Huh
2016-09-02 20:40 ` Joe Perches [this message]
2016-09-06 20:27 ` David Miller
2016-09-06 21:18 ` [PATCH] smsc95xx: Remove trailing underscores from macros and uses Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472848801.22931.7.camel@perches.com \
--to=joe@perches.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=Woojung.Huh@microchip.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=steve.glendinning@shawell.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.