diff for duplicates of <1472854985.2946.45.camel@linux.intel.com> diff --git a/a/1.txt b/N1/1.txt index d927a71..4d8d099 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,10 +1,10 @@ -On Fri, 2016-09-02@14:43 -0700, Andy Lutomirski wrote: +On Fri, 2016-09-02 at 14:43 -0700, Andy Lutomirski wrote: > On Fri, Sep 2, 2016 at 2:15 PM, J Freyensee > <james_p_freyensee@linux.intel.com> wrote: > > -> > On Tue, 2016-08-30@14:59 -0700, Andy Lutomirski wrote: +> > On Tue, 2016-08-30 at 14:59 -0700, Andy Lutomirski wrote: > > > -> > > NVME devices can advertise multiple power states.??These states +> > > NVME devices can advertise multiple power states. These states > > > can > > > be either "operational" (the device is fully functional but > > > possibly @@ -14,7 +14,7 @@ On Fri, 2016-09-02@14:43 -0700, Andy Lutomirski wrote: > > > back > > > up when needed. > > > -> > > The hardware configuration is a table.??For each state, an entry +> > > The hardware configuration is a table. For each state, an entry > > > in > > > the table indicates the next deeper non-operational state, if > > > any, @@ -26,18 +26,18 @@ On Fri, 2016-09-02@14:43 -0700, Andy Lutomirski wrote: > > > time > > > equal to 100% of the total latency (entry plus exit) associated > > > with -> > > that state.??A sysfs attribute 'apst_max_latency_us' gives the +> > > that state. A sysfs attribute 'apst_max_latency_us' gives the > > > maximum acceptable latency in ns; non-operational states with > > > total -> > > latency greater than this value will not be used.??As a special +> > > latency greater than this value will not be used. As a special > > > case, apst_max_latency_us=0 will disable APST entirely. > > > > May I ask a dumb question? > > > > How does this work with multiple NVMe devices plugged into a -> > system???I +> > system? I > > would have thought we'd want one apst_max_latency_us entry per NVMe -> > controller for individual control of each device???I have two +> > controller for individual control of each device? I have two > > Fultondale-class devices plugged into a system I tried these > > patches on > > (the 4.8-rc4 kernel) and I'm not sure how the single @@ -49,9 +49,9 @@ On Fri, 2016-09-02@14:43 -0700, Andy Lutomirski wrote: > Ah, I faked you out :( > > The module parameter (nvme_core/parameters/apst_max_latency_us) just -> sets the default for newly probed devices.??The actual setting is in +> sets the default for newly probed devices. The actual setting is in > /sys/devices/whatever (symlinked from /sys/block/nvme0n1/devices, for -> example).??Perhaps I should name the former +> example). Perhaps I should name the former > default_apst_max_latency_us. It would certainly be more describable to understand what the entry is diff --git a/a/content_digest b/N1/content_digest index f33c6fe..95a0e7a 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,18 +2,25 @@ "ref\06e6c3cd47858160bf8e34f2edb481c0ef5092d5b.1472594203.git.luto@kernel.org\0" "ref\01472850905.2946.20.camel@linux.intel.com\0" "ref\0CALCETrVoMEzmjfj--e09F8Ss8Dp9CFAmuuBhFoHOSNDoxHu6aQ@mail.gmail.com\0" - "From\0james_p_freyensee@linux.intel.com (J Freyensee)\0" - "Subject\0[PATCH v2 3/3] nvme: Enable autonomous power state transitions\0" + "From\0J Freyensee <james_p_freyensee@linux.intel.com>\0" + "Subject\0Re: [PATCH v2 3/3] nvme: Enable autonomous power state transitions\0" "Date\0Fri, 02 Sep 2016 15:23:05 -0700\0" + "To\0Andy Lutomirski <luto@amacapital.net>\0" + "Cc\0Jens Axboe <axboe@fb.com>" + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + linux-nvme@lists.infradead.org + Keith Busch <keith.busch@intel.com> + Andy Lutomirski <luto@kernel.org> + " Christoph Hellwig <hch@lst.de>\0" "\00:1\0" "b\0" - "On Fri, 2016-09-02@14:43 -0700, Andy Lutomirski wrote:\n" + "On Fri, 2016-09-02 at 14:43 -0700, Andy Lutomirski wrote:\n" "> On Fri, Sep 2, 2016 at 2:15 PM, J Freyensee\n" "> <james_p_freyensee@linux.intel.com> wrote:\n" "> > \n" - "> > On Tue, 2016-08-30@14:59 -0700, Andy Lutomirski wrote:\n" + "> > On Tue, 2016-08-30 at 14:59 -0700, Andy Lutomirski wrote:\n" "> > > \n" - "> > > NVME devices can advertise multiple power states.??These states\n" + "> > > NVME devices can advertise multiple power states.\302\240\302\240These states\n" "> > > can\n" "> > > be either \"operational\" (the device is fully functional but\n" "> > > possibly\n" @@ -23,7 +30,7 @@ "> > > back\n" "> > > up when needed.\n" "> > > \n" - "> > > The hardware configuration is a table.??For each state, an entry\n" + "> > > The hardware configuration is a table.\302\240\302\240For each state, an entry\n" "> > > in\n" "> > > the table indicates the next deeper non-operational state, if\n" "> > > any,\n" @@ -35,18 +42,18 @@ "> > > time\n" "> > > equal to 100% of the total latency (entry plus exit) associated\n" "> > > with\n" - "> > > that state.??A sysfs attribute 'apst_max_latency_us' gives the\n" + "> > > that state.\302\240\302\240A sysfs attribute 'apst_max_latency_us' gives the\n" "> > > maximum acceptable latency in ns; non-operational states with\n" "> > > total\n" - "> > > latency greater than this value will not be used.??As a special\n" + "> > > latency greater than this value will not be used.\302\240\302\240As a special\n" "> > > case, apst_max_latency_us=0 will disable APST entirely.\n" "> > \n" "> > May I ask a dumb question?\n" "> > \n" "> > How does this work with multiple NVMe devices plugged into a\n" - "> > system???I\n" + "> > system?\302\240\302\240I\n" "> > would have thought we'd want one apst_max_latency_us entry per NVMe\n" - "> > controller for individual control of each device???I have two\n" + "> > controller for individual control of each device?\302\240\302\240I have two\n" "> > Fultondale-class devices plugged into a system I tried these\n" "> > patches on\n" "> > (the 4.8-rc4 kernel) and I'm not sure how the single\n" @@ -58,9 +65,9 @@ "> Ah, I faked you out :(\n" "> \n" "> The module parameter (nvme_core/parameters/apst_max_latency_us) just\n" - "> sets the default for newly probed devices.??The actual setting is in\n" + "> sets the default for newly probed devices.\302\240\302\240The actual setting is in\n" "> /sys/devices/whatever (symlinked from /sys/block/nvme0n1/devices, for\n" - "> example).??Perhaps I should name the former\n" + "> example).\302\240\302\240Perhaps I should name the former\n" "> default_apst_max_latency_us.\n" "\n" "It would certainly be more describable to understand what the entry is\n" @@ -68,4 +75,4 @@ "\n" "Just \"default_apst_latency_us\"? Or maybe it's probably fine as-is." -5acd96e0a587b3dd60fe7ec2a3b567c617fe4d7e39fcee1cd891fc339bdd24eb +16f35a998a884d99262f8e0f82c21cb52a0faea6dc8564f0f5431bbca1a2079c
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.