From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH 2/3] bitbake/knotty: ensure we return non-zero exit code on Ctrl+C
Date: Wed, 22 Feb 2012 21:14:25 +0000 [thread overview]
Message-ID: <1472904.fEsuyk6NFK@helios> (raw)
In-Reply-To: <b0e42ae76c528cf90d3a78acfe8b4cd6b8552d42.1329133148.git.paul.eggleton@linux.intel.com>
On Monday 13 February 2012 11:41:32 Paul Eggleton wrote:
> If the user uses Ctrl+C to exit out of the build, then ensure we return
> a non-zero exit code since the entire build was not completed
> successfully.
>
> If nothing else, this is useful to avoid continuing in the bitbake
> wrapper script in OE-Core if the initial pseudo build is interrupted.
>
> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> ---
> bitbake/lib/bb/ui/knotty.py | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/bitbake/lib/bb/ui/knotty.py b/bitbake/lib/bb/ui/knotty.py
> index e1d42f7..2693a78 100644
> --- a/bitbake/lib/bb/ui/knotty.py
> +++ b/bitbake/lib/bb/ui/knotty.py
> @@ -296,4 +296,9 @@ def main(server, eventHandler):
> if summary:
> print(summary)
>
> + if shutdown:
> + print("Execution was interrupted, returning a non-zero exit code.")
> + if return_value == 0:
> + return_value = 1
> +
> return return_value
Seems I didn't test this well enough. Working on a fix right now.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-02-22 21:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-13 11:41 [PATCH 0/3] bitbake error fixes Paul Eggleton
2012-02-13 11:41 ` [PATCH 1/3] bitbake: show appropriate warnings for universe target Paul Eggleton
2012-02-13 11:41 ` [PATCH 2/3] bitbake/knotty: ensure we return non-zero exit code on Ctrl+C Paul Eggleton
2012-02-22 21:14 ` Paul Eggleton [this message]
2012-02-13 11:41 ` [PATCH 3/3] bitbake/knotty: ensure CommandFailed increases error count Paul Eggleton
2012-02-22 20:25 ` [PATCH 0/3] bitbake error fixes Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472904.fEsuyk6NFK@helios \
--to=paul.eggleton@linux.intel.com \
--cc=bitbake-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.