[Qemu-devel] [PATCH 0/3] Remove some unused CONFIG_* variables

[Qemu-devel] [PATCH 0/3] Remove some unused CONFIG_* variables

[Daniel P. Berrange]

There are a few CONFIG_* variables defined in default-configs/
that are never referenced. These were found using:

 $ for i in `grep -h -E '^CONFIG' default-configs/*  | sed -e 's/=.*//' | sort | uniq`
 do
     echo -n "$i: "
     git grep $i | grep -v default-configs | wc -l
 done | grep  ": 0"
 CONFIG_IPMI_EXTERN: 0
 CONFIG_ISA_MMIO: 0
 CONFIG_PAM: 0
 CONFIG_PIIX_PCI: 0


NB, the IPMI_EXTERN one is special - it should have been
used, so I sent a separate patch for that one.

Daniel P. Berrange (3):
  default-configs: remove CONFIG_PAM
  default-configs: removed obsolete CONFIG_ISA_MMIO
  default-configs: remove CONFIG_PIIX_PCI

 default-configs/arm-softmmu.mak     | 1 -
 default-configs/i386-softmmu.mak    | 2 --
 default-configs/ppc-softmmu.mak     | 1 -
 default-configs/ppc64-softmmu.mak   | 1 -
 default-configs/sparc64-softmmu.mak | 1 -
 default-configs/x86_64-softmmu.mak  | 2 --
 6 files changed, 8 deletions(-)

-- 
2.7.4

[Qemu-devel] [PATCH 1/3] default-configs: remove CONFIG_PAM

[Daniel P. Berrange]

The CONFIG_PAM=y setting was added in

  commit c0907c9e6417cb959dfd9ef6873221536ec91351
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   Tue Feb 5 15:06:20 2013 +0100

    hw: move PCI bridges to hw/pci-* or hw/ARCH

but nothing in that commit, nor anything pre-existing,
ever referenced CONFIG_PAM.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---
 default-configs/i386-softmmu.mak   | 1 -
 default-configs/x86_64-softmmu.mak | 1 -
 2 files changed, 2 deletions(-)

diff --git a/default-configs/i386-softmmu.mak b/default-configs/i386-softmmu.mak
index b177e52..4a89631 100644
--- a/default-configs/i386-softmmu.mak
+++ b/default-configs/i386-softmmu.mak
@@ -37,7 +37,6 @@ CONFIG_I8259=y
 CONFIG_PFLASH_CFI01=y
 CONFIG_TPM_TIS=$(CONFIG_TPM)
 CONFIG_MC146818RTC=y
-CONFIG_PAM=y
 CONFIG_PCI_PIIX=y
 CONFIG_WDT_IB700=y
 CONFIG_XEN_I386=$(CONFIG_XEN)
diff --git a/default-configs/x86_64-softmmu.mak b/default-configs/x86_64-softmmu.mak
index 6e3b312..b2bf736 100644
--- a/default-configs/x86_64-softmmu.mak
+++ b/default-configs/x86_64-softmmu.mak
@@ -37,7 +37,6 @@ CONFIG_I8259=y
 CONFIG_PFLASH_CFI01=y
 CONFIG_TPM_TIS=$(CONFIG_TPM)
 CONFIG_MC146818RTC=y
-CONFIG_PAM=y
 CONFIG_PCI_PIIX=y
 CONFIG_WDT_IB700=y
 CONFIG_XEN_I386=$(CONFIG_XEN)
-- 
2.7.4

[Qemu-devel] [PATCH 2/3] default-configs: removed obsolete CONFIG_ISA_MMIO

[Daniel P. Berrange]

The use of the CONFIG_ISA_MMIO setting was removed in

  commit 61fcb628627ea464dc1954f615ae13edfefd284f
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   Mon Jul 22 15:54:24 2013 +0200

    isa_mmio: delete

but this commit only removed it from some of the default
config files.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---
 default-configs/arm-softmmu.mak     | 1 -
 default-configs/ppc-softmmu.mak     | 1 -
 default-configs/ppc64-softmmu.mak   | 1 -
 default-configs/sparc64-softmmu.mak | 1 -
 4 files changed, 4 deletions(-)

diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak
index 7a19863..e124360 100644
--- a/default-configs/arm-softmmu.mak
+++ b/default-configs/arm-softmmu.mak
@@ -3,7 +3,6 @@
 include pci.mak
 include usb.mak
 CONFIG_VGA=y
-CONFIG_ISA_MMIO=y
 CONFIG_NAND=y
 CONFIG_ECC=y
 CONFIG_SERIAL=y
diff --git a/default-configs/ppc-softmmu.mak b/default-configs/ppc-softmmu.mak
index 4befde3..d4d0f9b 100644
--- a/default-configs/ppc-softmmu.mak
+++ b/default-configs/ppc-softmmu.mak
@@ -3,7 +3,6 @@
 include pci.mak
 include sound.mak
 include usb.mak
-CONFIG_ISA_MMIO=y
 CONFIG_ESCC=y
 CONFIG_M48T59=y
 CONFIG_SERIAL=y
diff --git a/default-configs/ppc64-softmmu.mak b/default-configs/ppc64-softmmu.mak
index c4be59f..db5a4d6 100644
--- a/default-configs/ppc64-softmmu.mak
+++ b/default-configs/ppc64-softmmu.mak
@@ -4,7 +4,6 @@ include pci.mak
 include sound.mak
 include usb.mak
 CONFIG_VIRTIO_VGA=y
-CONFIG_ISA_MMIO=y
 CONFIG_ESCC=y
 CONFIG_M48T59=y
 CONFIG_SERIAL=y
diff --git a/default-configs/sparc64-softmmu.mak b/default-configs/sparc64-softmmu.mak
index 123bb99..c0cdd64 100644
--- a/default-configs/sparc64-softmmu.mak
+++ b/default-configs/sparc64-softmmu.mak
@@ -2,7 +2,6 @@
 
 include pci.mak
 include usb.mak
-CONFIG_ISA_MMIO=y
 CONFIG_M48T59=y
 CONFIG_PTIMER=y
 CONFIG_SERIAL=y
-- 
2.7.4

[Qemu-devel] [PATCH 3/3] default-configs: remove CONFIG_PIIX_PCI

[Daniel P. Berrange]

The CONFIG_PIIX_PCI=y setting was added in

  commit 70615c38ded2a20ad8282b7dcde95482fc0a7744
  Author: Blue Swirl <blauwirbel@gmail.com>
  Date:   Mon Mar 22 20:18:40 2010 +0000

    Compile sound devices only once

but nothing in that commit, nor anything pre-existing,
ever referenced CONFIG_PIIX_PCI.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---
 default-configs/i386-softmmu.mak   | 1 -
 default-configs/x86_64-softmmu.mak | 1 -
 2 files changed, 2 deletions(-)

diff --git a/default-configs/i386-softmmu.mak b/default-configs/i386-softmmu.mak
index 4a89631..0b51360 100644
--- a/default-configs/i386-softmmu.mak
+++ b/default-configs/i386-softmmu.mak
@@ -30,7 +30,6 @@ CONFIG_I8257=y
 CONFIG_IDE_ISA=y
 CONFIG_IDE_PIIX=y
 CONFIG_NE2000_ISA=y
-CONFIG_PIIX_PCI=y
 CONFIG_HPET=y
 CONFIG_APPLESMC=y
 CONFIG_I8259=y
diff --git a/default-configs/x86_64-softmmu.mak b/default-configs/x86_64-softmmu.mak
index b2bf736..7f89503 100644
--- a/default-configs/x86_64-softmmu.mak
+++ b/default-configs/x86_64-softmmu.mak
@@ -30,7 +30,6 @@ CONFIG_I8257=y
 CONFIG_IDE_ISA=y
 CONFIG_IDE_PIIX=y
 CONFIG_NE2000_ISA=y
-CONFIG_PIIX_PCI=y
 CONFIG_HPET=y
 CONFIG_APPLESMC=y
 CONFIG_I8259=y
-- 
2.7.4

Re: [Qemu-devel] [PATCH 0/3] Remove some unused CONFIG_* variables

[Paolo Bonzini]

On 05/09/2016 19:25, Daniel P. Berrange wrote:
> There are a few CONFIG_* variables defined in default-configs/
> that are never referenced. These were found using:
> 
>  $ for i in `grep -h -E '^CONFIG' default-configs/*  | sed -e 's/=.*//' | sort | uniq`
>  do
>      echo -n "$i: "
>      git grep $i | grep -v default-configs | wc -l
>  done | grep  ": 0"
>  CONFIG_IPMI_EXTERN: 0
>  CONFIG_ISA_MMIO: 0
>  CONFIG_PAM: 0
>  CONFIG_PIIX_PCI: 0
> 
> 
> NB, the IPMI_EXTERN one is special - it should have been
> used, so I sent a separate patch for that one.
> 
> Daniel P. Berrange (3):
>   default-configs: remove CONFIG_PAM
>   default-configs: removed obsolete CONFIG_ISA_MMIO
>   default-configs: remove CONFIG_PIIX_PCI
> 
>  default-configs/arm-softmmu.mak     | 1 -
>  default-configs/i386-softmmu.mak    | 2 --
>  default-configs/ppc-softmmu.mak     | 1 -
>  default-configs/ppc64-softmmu.mak   | 1 -
>  default-configs/sparc64-softmmu.mak | 1 -
>  default-configs/x86_64-softmmu.mak  | 2 --
>  6 files changed, 8 deletions(-)
> 

Queued for 2.8, thanks.

Paolo