From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>, Vignesh R <vigneshr@ti.com>,
Yong Li <yong.b.li@intel.com>,
Geert Uytterhoeven <geert+renesas@glider.be>
Cc: linux-gpio <linux-gpio@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/5] gpio: pca953x: coding style fixes
Date: Wed, 07 Sep 2016 14:17:26 +0300 [thread overview]
Message-ID: <1473247046.11323.37.camel@linux.intel.com> (raw)
In-Reply-To: <1473240297-19881-2-git-send-email-bgolaszewski@baylibre.com>
On Wed, 2016-09-07 at 11:24 +0200, Bartosz Golaszewski wrote:
> pca953x_gpio_set_multiple() has some coding style issues that make it
> harder to read. Tweak the code a bit.
>
I would suggest to make this a last patch in the series. Rationale is
that you might have changed same lines by functional changes and the
first patch in such cases just makes a noise. More important, easier way
to back port if anyone is interested in that.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2016-09-07 11:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 9:24 [PATCH v2 0/5] gpio: pca953x: code refactoring Bartosz Golaszewski
2016-09-07 9:24 ` [PATCH v2 1/5] gpio: pca953x: coding style fixes Bartosz Golaszewski
2016-09-07 11:17 ` Andy Shevchenko [this message]
2016-09-07 9:24 ` [PATCH v2 2/5] gpio: pca953x: code shrink Bartosz Golaszewski
2016-09-07 9:24 ` [PATCH v2 3/5] gpio: pca953x: refactor pca953x_write_regs() Bartosz Golaszewski
2016-09-07 9:24 ` [PATCH v2 4/5] gpio: pca953x: remove an unused variable Bartosz Golaszewski
2016-09-07 11:36 ` Andy Shevchenko
2016-09-07 11:40 ` Bartosz Golaszewski
2016-09-07 12:17 ` Andy Shevchenko
2016-09-07 9:24 ` [PATCH v2 5/5] gpio: pca953x: refactor pca953x_read_regs() Bartosz Golaszewski
2016-09-07 11:35 ` Andy Shevchenko
2016-09-07 11:36 ` [PATCH v2 0/5] gpio: pca953x: code refactoring Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473247046.11323.37.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=geert+renesas@glider.be \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vigneshr@ti.com \
--cc=yong.b.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.