diff for duplicates of <1473259777.31962.401.camel@intel.com> diff --git a/a/1.txt b/N1/1.txt index 704bfdd..84fd87d 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -5,7 +5,7 @@ On Tue, 2016-09-06 at 14:46 +0000, Amir Yihie wrote: > Date: Tue, 6 Sep 2016 14:58:38 +0300 > Subject: [PATCH 249/249] net:ethernet:intel:igb_main.c: Add > Throttling disable -> ?option in order to decrease latency usually required by RT +> option in order to decrease latency usually required by RT > applications. > > Add an option to Disable Throttling algorithm , which will result @@ -19,8 +19,8 @@ On Tue, 2016-09-06 at 14:46 +0000, Amir Yihie wrote: > > Signed-off-by: Amir Yihie <amiry@waves.com> > --- -> ?drivers/net/ethernet/intel/igb/igb_main.c | 11 +++++++++++ -> ?1 file changed, 11 insertions(+) +> drivers/net/ethernet/intel/igb/igb_main.c | 11 +++++++++++ +> 1 file changed, 11 insertions(+) > > diff --git a/drivers/net/ethernet/intel/igb/igb_main.c > b/drivers/net/ethernet/intel/igb/igb_main.c @@ -28,9 +28,9 @@ On Tue, 2016-09-06 at 14:46 +0000, Amir Yihie wrote: > --- a/drivers/net/ethernet/intel/igb/igb_main.c > +++ b/drivers/net/ethernet/intel/igb/igb_main.c > @@ -251,6 +251,14 @@ static int debug = -1; -> ?module_param(debug, int, 0); -> ?MODULE_PARM_DESC(debug, "Debug level (0=none,...,16=all)"); -> ? +> module_param(debug, int, 0); +> MODULE_PARM_DESC(debug, "Debug level (0=none,...,16=all)"); +> > +/* Interrupt Throttle Rate (interrupts/sec) > + * > + * Valid Range: 0=off, 3=dynamic conservative @@ -41,23 +41,23 @@ On Tue, 2016-09-06 at 14:46 +0000, Amir Yihie wrote: > (0=off, 3=dynamic conservative)"); > + -This is creating redundant functionality. ?The same can be done via the -ethtool command "ethtool -C <iface> rx-usecs 0". ?Is there some reason +This is creating redundant functionality. The same can be done via the +ethtool command "ethtool -C <iface> rx-usecs 0". Is there some reason why you couldn't use ethtool? -> ?struct igb_reg_info { -> ????????u32 ofs; -> ????????char *name; +> struct igb_reg_info { +> u32 ofs; +> char *name; > @@ -2966,6 +2974,9 @@ static int igb_sw_init(struct igb_adapter > *adapter) -> ????????adapter->rx_itr_setting = IGB_DEFAULT_ITR; -> ????????adapter->tx_itr_setting = IGB_DEFAULT_ITR; -> ? -> +???????if (InterruptThrottleRate == 0) -> +???????????????adapter->rx_itr_setting = InterruptThrottleRate; +> adapter->rx_itr_setting = IGB_DEFAULT_ITR; +> adapter->tx_itr_setting = IGB_DEFAULT_ITR; +> +> + if (InterruptThrottleRate == 0) +> + adapter->rx_itr_setting = InterruptThrottleRate; > + -> ????????/* set default work limits */ -> ????????adapter->tx_work_limit = IGB_DEFAULT_TX_WORK; +> /* set default work limits */ +> adapter->tx_work_limit = IGB_DEFAULT_TX_WORK; If you are going to use InterruptThrottleRate you might as well use it fully instead of making it a boolean value with 0 having one meaning diff --git a/a/content_digest b/N1/content_digest index 757bab0..77a0018 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,9 +1,18 @@ "ref\020abe8058531466d8d60835ce88b6489@Hummer.waves.com\0" "ref\048faffefd02040f7a2af65691454ad3c@Hummer.waves.com\0" "From\0Duyck, Alexander H <alexander.h.duyck@intel.com>\0" - "Subject\0[Intel-wired-lan] [PATCH 249/249] net:ethernet:intel:igb_main.c: Add Throttling disable option in order to decrease latency usually required by RT applications.\0" + "Subject\0Re: [Intel-wired-lan] [PATCH 249/249] net:ethernet:intel:igb_main.c: Add Throttling disable option in order to decrease latency usually required by RT applications.\0" "Date\0Wed, 7 Sep 2016 14:49:39 +0000\0" - "To\0intel-wired-lan@osuosl.org\0" + "To\0amiry@waves.com <amiry@waves.com>" + Kirsher + " Jeffrey T <jeffrey.t.kirsher@intel.com>\0" + "Cc\0linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>" + netdev@vger.kernel.org <netdev@vger.kernel.org> + intel-wired-lan@lists.osuosl.org <intel-wired-lan@lists.osuosl.org> + shannon.nelson@intel.com <shannon.nelson@intel.com> + rostedt@goodmis.org <rostedt@goodmis.org> + matthew.vick@intel.com <matthew.vick@intel.com> + " john.ronciak@intel.com <john.ronciak@intel.com>\0" "\00:1\0" "b\0" "On Tue, 2016-09-06 at 14:46 +0000, Amir Yihie wrote:\n" @@ -13,7 +22,7 @@ "> Date: Tue, 6 Sep 2016 14:58:38 +0300\n" "> Subject: [PATCH 249/249] net:ethernet:intel:igb_main.c: Add\n" "> Throttling disable\n" - "> ?option in order to decrease latency usually required by RT\n" + "> \302\240option in order to decrease latency usually required by RT\n" "> applications.\n" "> \n" "> Add an option to Disable Throttling algorithm , which will result\n" @@ -27,8 +36,8 @@ "> \n" "> Signed-off-by: Amir Yihie <amiry@waves.com>\n" "> ---\n" - "> ?drivers/net/ethernet/intel/igb/igb_main.c | 11 +++++++++++\n" - "> ?1 file changed, 11 insertions(+)\n" + "> \302\240drivers/net/ethernet/intel/igb/igb_main.c | 11 +++++++++++\n" + "> \302\2401 file changed, 11 insertions(+)\n" "> \n" "> diff --git a/drivers/net/ethernet/intel/igb/igb_main.c\n" "> b/drivers/net/ethernet/intel/igb/igb_main.c\n" @@ -36,9 +45,9 @@ "> --- a/drivers/net/ethernet/intel/igb/igb_main.c\n" "> +++ b/drivers/net/ethernet/intel/igb/igb_main.c\n" "> @@ -251,6 +251,14 @@ static int debug = -1;\n" - "> ?module_param(debug, int, 0);\n" - "> ?MODULE_PARM_DESC(debug, \"Debug level (0=none,...,16=all)\");\n" - "> ?\n" + "> \302\240module_param(debug, int, 0);\n" + "> \302\240MODULE_PARM_DESC(debug, \"Debug level (0=none,...,16=all)\");\n" + "> \302\240\n" "> +/* Interrupt Throttle Rate (interrupts/sec)\n" "> + *\n" "> + * Valid Range: 0=off, 3=dynamic conservative\n" @@ -49,23 +58,23 @@ "> (0=off, 3=dynamic conservative)\");\n" "> +\n" "\n" - "This is creating redundant functionality. ?The same can be done via the\n" - "ethtool command \"ethtool -C <iface> rx-usecs 0\". ?Is there some reason\n" + "This is creating redundant functionality. \302\240The same can be done via the\n" + "ethtool command \"ethtool -C <iface> rx-usecs 0\". \302\240Is there some reason\n" "why you couldn't use ethtool?\n" "\n" - "> ?struct igb_reg_info {\n" - "> ????????u32 ofs;\n" - "> ????????char *name;\n" + "> \302\240struct igb_reg_info {\n" + "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240u32 ofs;\n" + "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240char *name;\n" "> @@ -2966,6 +2974,9 @@ static int igb_sw_init(struct igb_adapter\n" "> *adapter)\n" - "> ????????adapter->rx_itr_setting = IGB_DEFAULT_ITR;\n" - "> ????????adapter->tx_itr_setting = IGB_DEFAULT_ITR;\n" - "> ?\n" - "> +???????if (InterruptThrottleRate == 0)\n" - "> +???????????????adapter->rx_itr_setting = InterruptThrottleRate;\n" + "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240adapter->rx_itr_setting = IGB_DEFAULT_ITR;\n" + "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240adapter->tx_itr_setting = IGB_DEFAULT_ITR;\n" + "> \302\240\n" + "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240if (InterruptThrottleRate == 0)\n" + "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240adapter->rx_itr_setting = InterruptThrottleRate;\n" "> +\n" - "> ????????/* set default work limits */\n" - "> ????????adapter->tx_work_limit = IGB_DEFAULT_TX_WORK;\n" + "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240/* set default work limits */\n" + "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240adapter->tx_work_limit = IGB_DEFAULT_TX_WORK;\n" "\n" "If you are going to use InterruptThrottleRate you might as well use it\n" "fully instead of making it a boolean value with 0 having one meaning\n" @@ -75,4 +84,4 @@ "\n" - Alex -e84bce8e66aa966941ea700bb84f7d3f0e3daa4fb043b3ec28b1020e0e491af0 +62b0d792300aa16b11751e6daa49427ea4474c019227109da2b7f11bf995c8c5
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.