From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51210) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhsXT-0001an-9Y for qemu-devel@nongnu.org; Thu, 08 Sep 2016 02:10:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bhsXN-0006PX-4M for qemu-devel@nongnu.org; Thu, 08 Sep 2016 02:10:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46800) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhsXM-0006PJ-Ux for qemu-devel@nongnu.org; Thu, 08 Sep 2016 02:10:13 -0400 Message-ID: <1473315009.6698.10.camel@redhat.com> From: Gerd Hoffmann Date: Thu, 08 Sep 2016 08:10:09 +0200 In-Reply-To: <1473251067.637182699@f71.i.mail.ru> References: <1471984582.966257043@f45.i.mail.ru> <1473247658.28663.61.camel@redhat.com> <1473251067.637182699@f71.i.mail.ru> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/2] SDL2: only show consoles by shortcuts and not hide. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andrei Karas Cc: qemu-devel On Mi, 2016-09-07 at 15:24 +0300, Andrei Karas wrote: > >=D0=A1=D1=80=D0=B5=D0=B4=D0=B0, 7 =D1=81=D0=B5=D0=BD=D1=82=D1=8F=D0=B1= =D1=80=D1=8F 2016, 14:27 +03:00 =D0=BE=D1=82 Gerd Hoffmann : > > > >On Di, 2016-08-23 at 23:36 +0300, Andrei Karas wrote: > >> This fix issue with stuck keys in SDL2 if press one of shortcuts > >> for show/hide consoles. > > > >More detailed description please. How exactly do you end up with stuck > >keys? > For example i using ctrl_grab=3Don option. > Without patch if press rctrl+2 cosole window can be drawed and hidden at = same time many times. > Console drawed or hidden depend only how long keys was pressed. Ah, so you hold down the hotkey and key autorepeat will show/hide the window? > >So, the hotkey works only in case the window is hidden, so you can't > >hide windows with the shortcut any more. Is that intentional? Why? > Because previous explanation i found only solution is limit this keys to > always show windows. You can check ev->key.repeat to detect whenever the keypress is a real one or autorepeat event. cheers, Gerd