From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: sathyanarayanan.kuppuswamy@linux.intel.com, wharms@bfs.de
Cc: dan.carpenter@oracle.com, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, david.a.cohen@linux.intel.com
Subject: Re: [PATCH 1/1] intel-mid: Fix sfi get_platform_data() return value issues
Date: Thu, 08 Sep 2016 09:49:06 +0000 [thread overview]
Message-ID: <1473328146.11323.92.camel@linux.intel.com> (raw)
In-Reply-To: <71e4231f-33dc-9a95-c748-89bc5ec322d5@linux.intel.com>
On Wed, 2016-09-07 at 17:04 -0700, sathyanarayanan kuppuswamy wrote:
> --- a/arch/x86/platform/intel-mid/sfi.c
> > > +++ b/arch/x86/platform/intel-mid/sfi.c
> > > @@ -335,9 +335,12 @@ static void __init sfi_handle_ipc_dev(struct
> > > sfi_device_table_entry *pentry,
> > >
> > > pr_debug("IPC bus, name = %16.16s, irq = 0x%2x\n",
> > > pentry->name, pentry->irq);
> > > +
> > > pdata = intel_mid_sfi_get_pdata(dev, pentry);
> > > - if (IS_ERR(pdata))
> > > + if (IS_ERR(pdata)) {
> > > + pr_err("ipc_device: %s: invalid platform data\n",
> > > pentry->name);
> > > return;
> > > + }
> > This is actually needs more work. We have duplication in sfi.c and
> > platform_ipc.c.
> Yes. But platform_ipc.c implements custom ipc handler for audio ipc
> device. Even though there are duplications between custom handler and
> generic handler in sfi.c, I think its bit early to optimize this. I
> think we should revisit this once we have one more implementation of
> custom ipc handler.
Definitely it's out of scope for now.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: sathyanarayanan.kuppuswamy@linux.intel.com, wharms@bfs.de
Cc: dan.carpenter@oracle.com, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, david.a.cohen@linux.intel.com
Subject: Re: [PATCH 1/1] intel-mid: Fix sfi get_platform_data() return value issues
Date: Thu, 08 Sep 2016 12:49:06 +0300 [thread overview]
Message-ID: <1473328146.11323.92.camel@linux.intel.com> (raw)
In-Reply-To: <71e4231f-33dc-9a95-c748-89bc5ec322d5@linux.intel.com>
On Wed, 2016-09-07 at 17:04 -0700, sathyanarayanan kuppuswamy wrote:
> --- a/arch/x86/platform/intel-mid/sfi.c
> > > +++ b/arch/x86/platform/intel-mid/sfi.c
> > > @@ -335,9 +335,12 @@ static void __init sfi_handle_ipc_dev(struct
> > > sfi_device_table_entry *pentry,
> > >
> > > pr_debug("IPC bus, name = %16.16s, irq = 0x%2x\n",
> > > pentry->name, pentry->irq);
> > > +
> > > pdata = intel_mid_sfi_get_pdata(dev, pentry);
> > > - if (IS_ERR(pdata))
> > > + if (IS_ERR(pdata)) {
> > > + pr_err("ipc_device: %s: invalid platform data\n",
> > > pentry->name);
> > > return;
> > > + }
> > This is actually needs more work. We have duplication in sfi.c and
> > platform_ipc.c.
> Yes. But platform_ipc.c implements custom ipc handler for audio ipc
> device. Even though there are duplications between custom handler and
> generic handler in sfi.c, I think its bit early to optimize this. I
> think we should revisit this once we have one more implementation of
> custom ipc handler.
Definitely it's out of scope for now.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2016-09-08 9:49 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 19:23 [bug report] x86/sfi: Enable enumeration of SD devices Dan Carpenter
2016-08-09 15:32 ` Andy Shevchenko
2016-08-09 17:58 ` Dan Carpenter
2016-08-28 13:31 ` Andy Shevchenko
2016-08-29 20:59 ` Kuppuswamy, Sathyanarayanan
2016-08-30 9:46 ` Andy Shevchenko
2016-08-30 11:06 ` walter harms
2016-08-30 11:13 ` Andy Shevchenko
2016-08-30 18:18 ` Sathyanarayanan Kuppuswamy
2016-09-07 1:04 ` [PATCH 1/1] intel-mid: Fix sfi get_platform_data() return value issues Kuppuswamy Sathyanarayanan
2016-09-07 1:04 ` Kuppuswamy Sathyanarayanan
2016-09-07 12:15 ` Andy Shevchenko
2016-09-07 12:15 ` Andy Shevchenko
2016-09-08 0:04 ` sathyanarayanan kuppuswamy
2016-09-08 0:04 ` sathyanarayanan kuppuswamy
2016-09-08 9:49 ` Andy Shevchenko [this message]
2016-09-08 9:49 ` Andy Shevchenko
2016-09-08 0:05 ` [PATCH v2 " Kuppuswamy Sathyanarayanan
2016-09-08 0:05 ` Kuppuswamy Sathyanarayanan
2016-09-08 12:51 ` Andy Shevchenko
2016-09-08 12:51 ` Andy Shevchenko
2016-09-08 22:41 ` sathyanarayanan kuppuswamy
2016-09-08 22:41 ` sathyanarayanan kuppuswamy
2016-09-09 11:20 ` Andy Shevchenko
2016-09-09 11:20 ` Andy Shevchenko
2016-09-09 2:07 ` [PATCH v3 1/3] " Kuppuswamy Sathyanarayanan
2016-09-09 2:07 ` Kuppuswamy Sathyanarayanan
2016-09-09 2:07 ` [PATCH v3 2/3] intel-mid: Add valid error messages on init failure Kuppuswamy Sathyanarayanan
2016-09-09 2:07 ` Kuppuswamy Sathyanarayanan
2016-09-09 11:27 ` Andy Shevchenko
2016-09-09 11:27 ` Andy Shevchenko
2016-09-09 2:07 ` [PATCH v3 3/3] intel-mid: Move boundry check to the start of init code Kuppuswamy Sathyanarayanan
2016-09-09 2:07 ` Kuppuswamy Sathyanarayanan
2016-09-09 11:30 ` Andy Shevchenko
2016-09-09 11:30 ` Andy Shevchenko
2016-09-01 13:17 ` [bug report] x86/sfi: Enable enumeration of SD devices Andy Shevchenko
2016-09-07 0:51 ` Sathyanarayanan Kuppuswamy
2016-09-07 12:00 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473328146.11323.92.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dan.carpenter@oracle.com \
--cc=david.a.cohen@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.