From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Layton Subject: Re: [samba PATCH] vfs:ceph: convert to using ceph_statx structures and functions, when available Date: Thu, 08 Sep 2016 10:35:55 -0400 Message-ID: <1473345355.2564.8.camel@samba.org> References: <1473344984-22564-1-git-send-email-jlayton@samba.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Return-path: Received: from hr2.samba.org ([144.76.82.148]:58548 "EHLO hr2.samba.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758458AbcIHOgE (ORCPT ); Thu, 8 Sep 2016 10:36:04 -0400 In-Reply-To: <1473344984-22564-1-git-send-email-jlayton@samba.org> Sender: ceph-devel-owner@vger.kernel.org List-ID: To: samba-technical@lists.samba.org Cc: ceph-devel@vger.kernel.org, ira@wakeful.net On Thu, 2016-09-08 at 10:29 -0400, Jeff Layton wrote: > Add a configure test for the ceph_statx function, and use that to > determine whether to compile in new functions that use it and its > variants, or whether to use a the older code that fetches birthtimes > from an xattr. > > For cephwrap_lstat, we can use ceph_statx with the AT_SYMLINK_NOFOLLOW > flag to get the right lookup semantics. > > For setting the times via cephwrap_ntimes, We can just use ceph_setattrx > and pass them all in at the same time. > > > Signed-off-by: Jeff Layton > --- >  source3/modules/vfs_ceph.c | 216 ++++++++++++++++++++++++++++++++++++++------- >  source3/wscript            |   2 + >  2 files changed, 185 insertions(+), 33 deletions(-) > The new interfaces are now merged in the ceph master branch and should ship with the Kraken release. I know however, that Greg F. has some libcephfs API changes queued up that might change these function prototypes. So, it may be good to hold off on merging this into samba master until his work has been merged. Cheers, -- Jeff Layton