diff for duplicates of <1473376846.2092.69.camel@hpe.com> diff --git a/a/1.txt b/N1/1.txt index 262f843..f22a593 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -2,14 +2,14 @@ On Thu, 2016-09-08 at 07:48 -0600, Kani, Toshimitsu wrote: > On Thu, 2016-09-08 at 13:57 +0300, Kirill A. Shutemov wrote: > > > > On Mon, Aug 29, 2016 at 10:00:43PM +0000, Kani, Toshimitsu wrote: - : + : > > > > > > Looking further, these shmem_huge handlings only check pre- -> > > conditions. So, we should be able to make shmem_get_unmapped_are +> > > conditions.  So, we should be able to make shmem_get_unmapped_are > > > a() as a wrapper, which checks such shmem-specific conitions, and -> > > then call __thp_get_unmapped_area() for the actual work. All +> > > then call __thp_get_unmapped_area() for the actual work.  All > > > DAX-specific checks are performed in thp_get_unmapped_area() as -> > > well. We can make __thp_get_unmapped_area() as a common +> > > well.  We can make  __thp_get_unmapped_area() as a common > > > function. > > > > > > I'd prefer to make such change as a separate item, @@ -18,7 +18,7 @@ On Thu, 2016-09-08 at 07:48 -0600, Kani, Toshimitsu wrote: > > Yes, I will submit the change once I finish testing. -I found a bug in the current code, and need some clarification. The +I found a bug in the current code, and need some clarification.  The if-statement below is reverted. === @@ -28,28 +28,25 @@ index fd8b2b5..aec5b49 100644 +++ b/mm/shmem.c @@ -1980,7 +1980,7 @@ unsigned long shmem_get_unmapped_area(struct file *file, - return addr; - sb = shm_mnt->mnt_sb; - } -- if (SHMEM_SB(sb)->huge != SHMEM_HUGE_NEVER) -+ if (SHMEM_SB(sb)->huge == SHMEM_HUGE_NEVER) - return addr; - } +                                return addr; +                        sb = shm_mnt->mnt_sb; +                } +-               if (SHMEM_SB(sb)->huge != SHMEM_HUGE_NEVER) ++               if (SHMEM_SB(sb)->huge == SHMEM_HUGE_NEVER) +                        return addr; +        } === Because of this bug, mounting tmpfs with "huge=never" enables huge page mappings, and "huge=always" or others disables it... -The above simple change will change the default behavior, though. When +The above simple change will change the default behavior, though.  When "huge=" option is not specified, SHMEM_SB(sb)->huge is set to zero, -which is SHMEM_HUGE_NEVER. Therefore, huge page mappings are enabled +which is SHMEM_HUGE_NEVER.  Therefore, huge page mappings are enabled by default because of this bug. What's the intended default behavior of this feature? Thanks, -Toshi -_______________________________________________ -Linux-nvdimm mailing list -Linux-nvdimm@lists.01.org -https://lists.01.org/mailman/listinfo/linux-nvdimm +N‹§²æìr¸›zǧu©ž²Æ {\b†éì¹»\x1c®&Þ–)îÆi¢žØ^n‡r¶‰šŽŠÝ¢j$½§$¢¸\x05¢¹¨è§~Š'.)îÄÃ,yèm¶ŸÿÃ\f%Š{±šj+ƒðèž×¦j)Z†·Ÿ diff --git a/a/content_digest b/N1/content_digest index 2c0c723..7b19286 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -8,33 +8,35 @@ "Subject\0Re: [PATCH v4 RESEND 0/2] Align mmap address for DAX pmd mappings\0" "Date\0Thu, 8 Sep 2016 23:21:46 +0000\0" "To\0kirill@shutemov.name <kirill@shutemov.name>\0" - "Cc\0tytso@mit.edu <tytso@mit.edu>" - mawilcox@microsoft.com <mawilcox@microsoft.com> - david@fromorbit.com <david@fromorbit.com> - linux-nvdimm@lists.01.org <linux-nvdimm@lists.01.org> - hughd@google.com <hughd@google.com> + "Cc\0hughd@google.com <hughd@google.com>" + kirill.shutemov@linux.intel.com <kirill.shutemov@linux.intel.com> linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> linux-mm@kvack.org <linux-mm@kvack.org> adilger.kernel@dilger.ca <adilger.kernel@dilger.ca> - linux-fsdevel@vger.kernel.org <linux-fsdevel@vger.kernel.org> - jack@suse.cz <jack@suse.cz> + mike.kravetz@oracle.com <mike.kravetz@oracle.com> + dan.j.williams@intel.com <dan.j.williams@intel.com> + mawilcox@microsoft.com <mawilcox@microsoft.com> akpm@linux-foundation.org <akpm@linux-foundation.org> - kirill.shutemov@linux.intel.com <kirill.shutemov@linux.intel.com> - " mike.kravetz@oracle.com <mike.kravetz@oracle.com>\0" + linux-nvdimm@lists.01.org <linux-nvdimm@lists.01.org> + linux-fsdevel@vger.kernel.org <linux-fsdevel@vger.kernel.org> + ross.zwisler@linux.intel.com <ross.zwisler@linux.intel.com> + tytso@mit.edu <tytso@mit.edu> + david@fromorbit.com <david@fromorbit.com> + " jack@suse.cz <jack@suse.cz>\0" "\00:1\0" "b\0" "On Thu, 2016-09-08 at 07:48 -0600, Kani, Toshimitsu wrote:\n" "> On Thu, 2016-09-08 at 13:57 +0300, Kirill A. Shutemov wrote:\n" "> > \n" "> > On Mon, Aug 29, 2016 at 10:00:43PM +0000, Kani, Toshimitsu wrote:\n" - "\302\240:\n" + "\303\202\302\240:\n" "> > > \n" "> > > Looking further, these shmem_huge handlings only check pre-\n" - "> > > conditions.\302\240\302\240So,\302\240we\302\240should\302\240be\302\240able\302\240to\302\240make\302\240shmem_get_unmapped_are\n" + "> > > conditions.\303\202\302\240\303\202\302\240So,\303\202\302\240we\303\202\302\240should\303\202\302\240be\303\202\302\240able\303\202\302\240to\303\202\302\240make\303\202\302\240shmem_get_unmapped_are\n" "> > > a() as a wrapper, which checks such shmem-specific conitions, and\n" - "> > > then\302\240call\302\240__thp_get_unmapped_area() for the actual work. \302\240All\n" + "> > > then\303\202\302\240call\303\202\302\240__thp_get_unmapped_area() for the actual work. \303\202\302\240All\n" "> > > DAX-specific checks are performed in thp_get_unmapped_area() as\n" - "> > > well. \302\240We can make \302\240__thp_get_unmapped_area() as a common\n" + "> > > well. \303\202\302\240We can make \303\202\302\240__thp_get_unmapped_area() as a common\n" "> > > function.\n" "> > > \n" "> > > I'd prefer to make such change as a separate item,\n" @@ -43,7 +45,7 @@ "> \n" "> Yes, I will submit the change once I finish testing.\n" "\n" - "I found a bug in the current code, and need some clarification. \302\240The\n" + "I found a bug in the current code, and need some clarification. \303\202\302\240The\n" "if-statement below is reverted.\n" "\n" "===\n" @@ -53,30 +55,27 @@ "+++ b/mm/shmem.c\n" "@@ -1980,7 +1980,7 @@ unsigned long shmem_get_unmapped_area(struct file\n" "*file,\n" - "\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240return addr;\n" - "\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240sb = shm_mnt->mnt_sb;\n" - "\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240}\n" - "-\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240if (SHMEM_SB(sb)->huge != SHMEM_HUGE_NEVER)\n" - "+\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240if (SHMEM_SB(sb)->huge == SHMEM_HUGE_NEVER)\n" - "\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240return addr;\n" - "\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240}\n" + "\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240return addr;\n" + "\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240sb = shm_mnt->mnt_sb;\n" + "\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240}\n" + "-\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240if (SHMEM_SB(sb)->huge != SHMEM_HUGE_NEVER)\n" + "+\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240if (SHMEM_SB(sb)->huge == SHMEM_HUGE_NEVER)\n" + "\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240return addr;\n" + "\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240\303\202\302\240}\n" "===\n" "\n" "Because of this bug, mounting tmpfs with \"huge=never\" enables huge page\n" "mappings, and \"huge=always\" or others disables it...\n" "\n" - "The above simple change will change the default behavior, though. \302\240When\n" + "The above simple change will change the default behavior, though. \303\202\302\240When\n" "\"huge=\" option is not specified, SHMEM_SB(sb)->huge is set to zero,\n" - "which is SHMEM_HUGE_NEVER. \302\240Therefore, huge page mappings are enabled\n" + "which is SHMEM_HUGE_NEVER. \303\202\302\240Therefore, huge page mappings are enabled\n" "by default because of this bug.\n" "\n" "What's the intended default behavior of this feature?\n" "\n" "Thanks,\n" "-Toshi\n" - "_______________________________________________\n" - "Linux-nvdimm mailing list\n" - "Linux-nvdimm@lists.01.org\n" - https://lists.01.org/mailman/listinfo/linux-nvdimm + "N\302\213\302\247\302\262\303\246\303\254r\302\270\302\233z\303\207\302\247u\302\251\302\236\302\262\303\206\302\240{\b\302\255\302\206\303\251\303\254\302\271\302\273\034\302\256&\303\236\302\226)\303\256\303\206i\302\242\302\236\303\230^n\302\207r\302\266\302\211\302\232\302\216\302\212\303\235\302\242j$\302\275\302\247$\302\242\302\270\005\302\242\302\271\302\250\302\255\303\250\302\247~\302\212'.)\303\256\303\204\303\203,y\303\250m\302\266\302\237\303\277\303\203\f%\302\212{\302\261\302\232j+\302\203\303\260\303\250\302\236\303\227\302\246j)Z\302\206\302\267\302\237" -5a576f5dfe2271129b6f2e7760ea31fa26ddeff5cdce72fc15401444f52e629b +402ab1e7d08f4f2ec07fd6a5d48ef4852d3bed65b5267064d9896729aaa2c49f
diff --git a/a/1.txt b/N2/1.txt index 262f843..d4d5022 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -49,7 +49,3 @@ What's the intended default behavior of this feature? Thanks, -Toshi -_______________________________________________ -Linux-nvdimm mailing list -Linux-nvdimm@lists.01.org -https://lists.01.org/mailman/listinfo/linux-nvdimm diff --git a/a/content_digest b/N2/content_digest index 2c0c723..792215d 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -8,19 +8,21 @@ "Subject\0Re: [PATCH v4 RESEND 0/2] Align mmap address for DAX pmd mappings\0" "Date\0Thu, 8 Sep 2016 23:21:46 +0000\0" "To\0kirill@shutemov.name <kirill@shutemov.name>\0" - "Cc\0tytso@mit.edu <tytso@mit.edu>" - mawilcox@microsoft.com <mawilcox@microsoft.com> - david@fromorbit.com <david@fromorbit.com> - linux-nvdimm@lists.01.org <linux-nvdimm@lists.01.org> - hughd@google.com <hughd@google.com> + "Cc\0hughd@google.com <hughd@google.com>" + kirill.shutemov@linux.intel.com <kirill.shutemov@linux.intel.com> linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> linux-mm@kvack.org <linux-mm@kvack.org> adilger.kernel@dilger.ca <adilger.kernel@dilger.ca> - linux-fsdevel@vger.kernel.org <linux-fsdevel@vger.kernel.org> - jack@suse.cz <jack@suse.cz> + mike.kravetz@oracle.com <mike.kravetz@oracle.com> + dan.j.williams@intel.com <dan.j.williams@intel.com> + mawilcox@microsoft.com <mawilcox@microsoft.com> akpm@linux-foundation.org <akpm@linux-foundation.org> - kirill.shutemov@linux.intel.com <kirill.shutemov@linux.intel.com> - " mike.kravetz@oracle.com <mike.kravetz@oracle.com>\0" + linux-nvdimm@lists.01.org <linux-nvdimm@ml01.01.org> + linux-fsdevel@vger.kernel.org <linux-fsdevel@vger.kernel.org> + ross.zwisler@linux.intel.com <ross.zwisler@linux.intel.com> + tytso@mit.edu <tytso@mit.edu> + david@fromorbit.com <david@fromorbit.com> + " jack@suse.cz <jack@suse.cz>\0" "\00:1\0" "b\0" "On Thu, 2016-09-08 at 07:48 -0600, Kani, Toshimitsu wrote:\n" @@ -73,10 +75,6 @@ "What's the intended default behavior of this feature?\n" "\n" "Thanks,\n" - "-Toshi\n" - "_______________________________________________\n" - "Linux-nvdimm mailing list\n" - "Linux-nvdimm@lists.01.org\n" - https://lists.01.org/mailman/listinfo/linux-nvdimm + -Toshi -5a576f5dfe2271129b6f2e7760ea31fa26ddeff5cdce72fc15401444f52e629b +c9bd0513f8adab6c9180f1df27b6b594450db8aefc440ccc90608b6343247522
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.